[Sound-open-firmware] [PATCH] platform: apl: expand max stream number to be 16
On GP-MRB, we may use streams more than 5, here expand it to be 16.
Signed-off-by: Keyon Jie yang.jie@linux.intel.com --- Test with: APL-MRB with tdf8532 codec Linux topic/sof-v4.14: 3ffd39334cb53aced88b8aba17cae3df9ee2736f SOF master: 48a61423f6c2d2bcf5fad854a9b3d37dfb43b546 Tool master: 7ee114d2ed822a0dbfc0dc3a37fd5c4977e00be8 --- src/platform/apollolake/include/platform/platform.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/platform/apollolake/include/platform/platform.h b/src/platform/apollolake/include/platform/platform.h index c9b2757..aefa9b2 100644 --- a/src/platform/apollolake/include/platform/platform.h +++ b/src/platform/apollolake/include/platform/platform.h @@ -65,7 +65,7 @@ struct sof;
/* Platform stream capabilities */ #define PLATFORM_MAX_CHANNELS 4 -#define PLATFORM_MAX_STREAMS 5 +#define PLATFORM_MAX_STREAMS 16
/* clock source used by scheduler for deadline calculations */ #define PLATFORM_SCHED_CLOCK CLK_SSP
On Thu, 2018-05-31 at 16:04 +0800, Keyon Jie wrote:
On GP-MRB, we may use streams more than 5, here expand it to be 16.
Signed-off-by: Keyon Jie yang.jie@linux.intel.com
Test with: APL-MRB with tdf8532 codec Linux topic/sof-v4.14: 3ffd39334cb53aced88b8aba17cae3df9ee2736f SOF master: 48a61423f6c2d2bcf5fad854a9b3d37dfb43b546 Tool master: 7ee114d2ed822a0dbfc0dc3a37fd5c4977e00be8
src/platform/apollolake/include/platform/platform.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, but what about CNL ?
Max channels should also be 8 on CNL and APL.
Liam
On 5/31/18 3:42 AM, Liam Girdwood wrote:
On Thu, 2018-05-31 at 16:04 +0800, Keyon Jie wrote:
On GP-MRB, we may use streams more than 5, here expand it to be 16.
Signed-off-by: Keyon Jie yang.jie@linux.intel.com
Test with: APL-MRB with tdf8532 codec Linux topic/sof-v4.14: 3ffd39334cb53aced88b8aba17cae3df9ee2736f SOF master: 48a61423f6c2d2bcf5fad854a9b3d37dfb43b546 Tool master: 7ee114d2ed822a0dbfc0dc3a37fd5c4977e00be8
src/platform/apollolake/include/platform/platform.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, but what about CNL ?
Max channels should also be 8 on CNL and APL.
What does 'stream' mean here?
if this means PCM front-ends/gateways, then it'll be restricted by debug stuff (trace, probes). If this means DMA channels, we already have information on the number of channels so why do we need a new definition?
On Thu, 2018-05-31 at 07:59 -0500, Pierre-Louis Bossart wrote:
On 5/31/18 3:42 AM, Liam Girdwood wrote:
On Thu, 2018-05-31 at 16:04 +0800, Keyon Jie wrote:
On GP-MRB, we may use streams more than 5, here expand it to be 16.
Signed-off-by: Keyon Jie yang.jie@linux.intel.com
Test with: APL-MRB with tdf8532 codec Linux topic/sof-v4.14: 3ffd39334cb53aced88b8aba17cae3df9ee2736f SOF master: 48a61423f6c2d2bcf5fad854a9b3d37dfb43b546 Tool master: 7ee114d2ed822a0dbfc0dc3a37fd5c4977e00be8
src/platform/apollolake/include/platform/platform.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, but what about CNL ?
Max channels should also be 8 on CNL and APL.
What does 'stream' mean here?
if this means PCM front-ends/gateways, then it'll be restricted by debug stuff (trace, probes). If this means DMA channels, we already have information on the number of channels so why do we need a new definition?
Can also mean host less stream.
Liam
-----Original Message----- From: sound-open-firmware-bounces@alsa-project.org [mailto:sound-open- firmware-bounces@alsa-project.org] On Behalf Of Liam Girdwood Sent: Thursday, May 31, 2018 4:42 PM To: Keyon Jie yang.jie@linux.intel.com; sound-open-firmware@alsa- project.org Subject: Re: [Sound-open-firmware] [PATCH] platform: apl: expand max stream number to be 16
On Thu, 2018-05-31 at 16:04 +0800, Keyon Jie wrote:
On GP-MRB, we may use streams more than 5, here expand it to be 16.
Signed-off-by: Keyon Jie yang.jie@linux.intel.com
Test with: APL-MRB with tdf8532 codec Linux topic/sof-v4.14: 3ffd39334cb53aced88b8aba17cae3df9ee2736f SOF master: 48a61423f6c2d2bcf5fad854a9b3d37dfb43b546 Tool master: 7ee114d2ed822a0dbfc0dc3a37fd5c4977e00be8
src/platform/apollolake/include/platform/platform.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, but what about CNL ?
Max channels should also be 8 on CNL and APL.
For CNL, I have no chance(no requirement from machine driver or tplg file yet actually) to try and confirm about if it can work, so didn't do patch for that at the moment yet.
Thanks, ~Keyon
Liam _______________________________________________ Sound-open-firmware mailing list Sound-open-firmware@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
participants (4)
-
Jie, Yang -
Keyon Jie -
Liam Girdwood -
Pierre-Louis Bossart