[Sound-open-firmware] checkpatch.pl fixes
Hi all,
What is your take on checkpatch.pl fixes for SOF FW?
Diana (CC'ed) is trying to get accustomed with SOF code and while at that she can fix some obvious checkpatch.pl warn / errors.
Does it make sense to send some patches for that?
I know that this kind of fixes can pollute the change history but on the other side code gets a little bit cleaner.
thanks, Daniel.
On 4.3.2019 14.24, Daniel Baluta wrote:
Hi all,
What is your take on checkpatch.pl fixes for SOF FW?
Diana (CC'ed) is trying to get accustomed with SOF code and while at that she can fix some obvious checkpatch.pl warn / errors.
Does it make sense to send some patches for that?
I know that this kind of fixes can pollute the change history but on the other side code gets a little bit cleaner.
Sounds good, my +1 for cleanup!
Cheers, Seppo
thanks, Daniel. _______________________________________________ Sound-open-firmware mailing list Sound-open-firmware@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
On Mon, Mar 4, 2019 at 2:50 PM Seppo Ingalsuo seppo.ingalsuo@linux.intel.com wrote:
On 4.3.2019 14.24, Daniel Baluta wrote:
Hi all,
What is your take on checkpatch.pl fixes for SOF FW?
Diana (CC'ed) is trying to get accustomed with SOF code and while at that she can fix some obvious checkpatch.pl warn / errors.
Does it make sense to send some patches for that?
I know that this kind of fixes can pollute the change history but on the other side code gets a little bit cleaner.
Sounds good, my +1 for cleanup!
Thanks Seppo, we will have a look if no strong option against.
Btw, I noticed that the pre/post commit hooks that enforce checkpatch.pl have been removed from SOF tree. Any idea why?
thanks, Daniel.
On 3/4/19 7:48 AM, Daniel Baluta wrote:
On Mon, Mar 4, 2019 at 2:50 PM Seppo Ingalsuo seppo.ingalsuo@linux.intel.com wrote:
On 4.3.2019 14.24, Daniel Baluta wrote:
Hi all,
What is your take on checkpatch.pl fixes for SOF FW?
Diana (CC'ed) is trying to get accustomed with SOF code and while at that she can fix some obvious checkpatch.pl warn / errors.
Does it make sense to send some patches for that?
I know that this kind of fixes can pollute the change history but on the other side code gets a little bit cleaner.
Sounds good, my +1 for cleanup!
that's fine, I did what i could a couple of weeks back but there are still a lot of changes needed on historical code. In a lot of cases this helps find issues...
Thanks Seppo, we will have a look if no strong option against.
Btw, I noticed that the pre/post commit hooks that enforce checkpatch.pl have been removed from SOF tree. Any idea why?
That's not good. Likely happened when the autotools dependency was removed.
participants (3)
-
Daniel Baluta -
Pierre-Louis Bossart -
Seppo Ingalsuo