24 May
2018
24 May
'18
12:27 p.m.
On Thu, 2018-05-24 at 10:35 +0800, Keyon Jie wrote:
it should be aligned with the definition in machine driver. it do be consistent in machine driver, and they are also same with SSP port number in machine driver(although they could be different, such as the change in this same patch for byt...).
another point is, I am planing to add PCMs for all 6 SSP ports soon, after that, you will still see that the ids here are exactly same with port number.
Ok, we can upstream once this is working on a device with > 1 port e.g 1 SSP and 1 DMIC Unless you have already tested ? Do we need driver patches too ?
You need to add more detail in the commit message too. What you are adding and why it will match Ids.
Liam