Re: [Sound-open-firmware] [PATCH v4 18/20] ASoC: SOF: Add Build support for SOF core and Intel drivers

On Thu, 21 Mar 2019 17:10:53 +0100, Pierre-Louis Bossart wrote:

--- /dev/null +++ b/sound/soc/sof/Kconfig @@ -0,0 +1,141 @@ +config SND_SOC_SOF_TOPLEVEL

• bool "Sound Open Firmware Support"
• help

•      This adds support for Sound Open Firmware (SOF). SOF is a free and
  

•  generic open source audio DSP firmware for multiple devices.
  

•      Say Y if you have such a device that is supported by SOF.
  

•      If unsure select "N".
  

The unaligned indentation. Also in other kconfig help texts.

--- /dev/null +++ b/sound/soc/sof/intel/Kconfig @@ -0,0 +1,222 @@ +config SND_SOC_SOF_INTEL_TOPLEVEL

• bool "SOF support for Intel audio DSPs"
• depends on SND_DMA_SGBUF || COMPILE_TEST

The dependency on SND_DMA_SGBUF can be seen as misleading. The SG-buffer helper actually hides the difference, so it would work even if SGBUF is off. But actually this makes drivers depending on x86, so that's probably the most important (hidden) bits...

That said, I guess we should replace SND_DMA_SGBUF with X86.

thanks,

Takashi