On 16/06/2022 07:31, Dan Carpenter wrote:
The sof_ipc4_volume_put() function returns type bool so returning -ENOENT means returning true. Return false instead.
Good catch,
Acked-by: Peter Ujfalusi peter.ujfalusi@linux.intel.com
Fixes: 955e84fc0b6d ("ASoC: SOF: ipc4-topology: Add control IO ops") Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
sound/soc/sof/ipc4-control.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sof/ipc4-control.c b/sound/soc/sof/ipc4-control.c index 95ee121dd3cf..0d5a578c3496 100644 --- a/sound/soc/sof/ipc4-control.c +++ b/sound/soc/sof/ipc4-control.c @@ -142,7 +142,7 @@ static bool sof_ipc4_volume_put(struct snd_sof_control *scontrol,
if (!widget_found) { dev_err(scomp->dev, "Failed to find widget for kcontrol %s\n", scontrol->name);
return -ENOENT;
return false;}
ret = sof_ipc4_set_volume_data(sdev, swidget, scontrol);