Re: [Sound-open-firmware] [PATCH v14 2/2] mailbox: mediatek: add support for adsp mailbox controller

On Fri, 2022-01-14 at 08:57 -0800, Curtis Malainey wrote:

...

+static struct mtk_adsp_mbox_priv *get_mtk_adsp_mbox_priv(struct mbox_controller *mbox) +{

•   return container_of(mbox, struct mtk_adsp_mbox_priv, mbox);
  

+}

this could probably be inline

Hi Curtis,

I check the symbol table of kernel.

get_mtk_adsp_mbox_priv is decided to inline by compiler.

I think it's ok use inline this function.

on other hand, compile will not use inline definition of mtk_adsp_mbox_xlate for the mbox_controller's implement (I also check the symbole of kernel)

I will update next version for get_mtk_adsp_mbox_priv.

Thank.

...

+static struct mbox_chan *mtk_adsp_mbox_xlate(struct mbox_controller *mbox,

•                                        const struct
  

of_phandle_args *sp) +{

•   return mbox->chans;
  

+}

also could probably benefit from inline