On 03/13/2018 04:00 PM, Liam Girdwood wrote:
On Tue, 2018-03-13 at 15:42 -0500, Pierre-Louis Bossart wrote:
On 3/13/18 3:18 PM, Liam Girdwood wrote:
DAI Widgets need bound to a DAI link to complete the DAPM graph. This is only working atm as we are only using one DAI. Add stream name to DAI widgets to be used by topology binder.
I am pretty sure we removed the stream_name in December since no machine driver actually used them
We did, but everything worked accidentally for one DAI link due to DAI link stream name being NULL and widget name being "". This obviously wont work for multiple DAI links.
IIRC this stream_name created a mess with the topology binding, if you specify a stream_name but the machine driver doesn't have one the binding fails.
Patches sent for that part that also fix the binding logic.
ok, but this will break firmware if I don't take your ASoC patches... And I had to look at the details to figure out that:
"most BE links dont set stream name, so set it to dai link name if it's NULL to help bind widgets."
Now that makes sense :-)