On Tue, Sep 08, 2020 at 10:16:52AM -0400, Michael S. Tsirkin wrote:
On Wed, Aug 26, 2020 at 07:46:32PM +0200, Guennadi Liakhovetski wrote:
Hi,
Next update:
OK could we get some acks from rpmsg folks on this please? It's been quite a while, patchset is not huge.
There is a V6 of this set where Guennadi and I have agreed that patches 2 and 3 have been dealt with. Patch 1 is trivial, leaving only patch 4. I had initially decided to skip it because the vhost driver is completely foreign to me and the cycles to change that are scarse. But this set [1] from Arnaud has brought to the fore issues related to the definition struct rpmsg_ns_msg, also used by Guennadi's work.
As such I don't really have a choice now, I will review this series tomorrow or Thursday.
[1]. https://patchwork.kernel.org/project/linux-remoteproc/list/?series=338335
v5:
- don't hard-code message layout
v4:
- add endianness conversions to comply with the VirtIO standard
v3:
- address several checkpatch warnings
- address comments from Mathieu Poirier
v2:
- update patch #5 with a correct vhost_dev_init() prototype
- drop patch #6 - it depends on a different patch, that is currently an RFC
- address comments from Pierre-Louis Bossart:
- remove "default n" from Kconfig
Linux supports RPMsg over VirtIO for "remote processor" / AMP use cases. It can however also be used for virtualisation scenarios, e.g. when using KVM to run Linux on both the host and the guests. This patch set adds a wrapper API to facilitate writing vhost drivers for such RPMsg-based solutions. The first use case is an audio DSP virtualisation project, currently under development, ready for review and submission, available at https://github.com/thesofproject/linux/pull/1501/commits
Thanks Guennadi
Guennadi Liakhovetski (4): vhost: convert VHOST_VSOCK_SET_RUNNING to a generic ioctl rpmsg: move common structures and defines to headers rpmsg: update documentation vhost: add an RPMsg API
Documentation/rpmsg.txt | 6 +- drivers/rpmsg/virtio_rpmsg_bus.c | 78 +------ drivers/vhost/Kconfig | 7 + drivers/vhost/Makefile | 3 + drivers/vhost/rpmsg.c | 373 +++++++++++++++++++++++++++++++ drivers/vhost/vhost_rpmsg.h | 74 ++++++ include/linux/virtio_rpmsg.h | 83 +++++++ include/uapi/linux/rpmsg.h | 3 + include/uapi/linux/vhost.h | 4 +- 9 files changed, 551 insertions(+), 80 deletions(-) create mode 100644 drivers/vhost/rpmsg.c create mode 100644 drivers/vhost/vhost_rpmsg.h create mode 100644 include/linux/virtio_rpmsg.h
-- 2.28.0