20 Feb
2018
20 Feb
'18
8:33 p.m.
Looking at the code and latest patches I see quite a few differences between APL and CNL that makes no sense to me.
1. why would use a workqueue based on SSP (APL) and CPU (CNL)? 2. why would we initialize the SSP to 25MHz for CNL? It's clearly not a supported frequency, 25MHz can only be reached on BYT and CHT. On a similar note not sure why APL makes a reference to 24 MHz, it should be 24576000. 3. why would we use DMAC class 1/2 on APL and class 6/7 on CNL?
Conversely I always thought there were differences in the HDaudio DMA channel count between APL and CNL, so can we really share common definitions in src/drivers/hda-dma.c ?
Thanks -Pierre