12 Dec
2018
12 Dec
'18
9:53 a.m.
On 12/12/18 1:51 AM, Takashi Iwai wrote:
On Tue, 11 Dec 2018 22:23:05 +0100, Pierre-Louis Bossart wrote:
+static int sof_probe(struct platform_device *pdev) +{
....
- /* register any debug/trace capabilities */
- ret = snd_sof_dbg_init(sdev);
- if (ret < 0) {
dev_err(sdev->dev, "error: failed to init DSP trace/debug %d\n",ret);goto dbg_err;- }
So that's the problem Andy suggested. snd_sof_dbg_init() returns an error for whatever reason, and this is considered as a fatal error and the probe fails. The error about debugfs is no fatal error, it should continue.
Moreover, as I mentioned for another patch (I read that before this one due to the mail delivery order :), it would fail always when CONFIG_DEBUGFS=n. At best, create a wrapper for CONFIG_DEBUGFS=n to return 0 (and void for free).
ok. we'll fix this, point taken.