Re: [PATCH] ASoC: SOF: Move sof_of_machine_select() to core.c from sof-of-dev.c

On Mon, Dec 4, 2023 at 5:46 AM Chen-Yu Tsai wenst@chromium.org wrote:

This reverts commit 014fdeb0d747304111cfecf93df4407c1a0c80db.

Commit 014fdeb0d747 ("ASoC: SOF: Move sof_of_machine_select() to sof-of-dev.c from sof-audio.c") caused a circular dependency between the snd_sof and snd_sof_of modules:

    depmod: ERROR: Cycle detected: snd_sof -> snd_sof_of -> snd_sof
    depmod: ERROR: Found 2 modules in dependency cycles!

Move the function back with sof_machine_select().

Fixes: 014fdeb0d747 ("ASoC: SOF: Move sof_of_machine_select() to sof-of-dev.c from sof-audio.c") Signed-off-by: Chen-Yu Tsai wenst@chromium.org

Thanks for fixing this.

Reviewed-by: Daniel Baluta daniel.baluta@nxp.com