On 6/19/2018 19:01, Liam Girdwood wrote:
On Tue, 2018-06-19 at 17:22 +0800, Xiuli Pan wrote:
diff --git a/src/include/sof/ssp.h b/src/include/sof/ssp.h index fdcfcac..92db71f 100644 --- a/src/include/sof/ssp.h +++ b/src/include/sof/ssp.h @@ -231,6 +231,7 @@ struct ssp_pdata { uint32_t psp; spinlock_t lock; uint32_t state[2]; /* SSP_STATE_ for each direction */
uint32_t lbm;This is probably better as a bitfield flag and probably made generic in sof_ipc_dai_config. That way we can reuse this whole infrastructure for other
ipc_dai_config is a shared structure from host to DSP, it should not be used to save some SSP only stauts and it may also not be generic. This change is made for this reason as your last two comments about adding flag in
struct sof_ipc_dai_config and struct dai with this SSP only status.
Thanks Xiuli
non SSP DAIs.
I would also probably rename to loopback_control;
Liam
completion_t drain_complete; struct sof_ipc_dai_config config; struct sof_ipc_dai_ssp_params params;
Sound-open-firmware mailing list Sound-open-firmware@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware