On Wed, 2018-03-07 at 10:42 +0800, Rander Wang wrote:
On cnl, all the dma share the same interrupt pin, so all the dma controller need to be checked in interrupt function.
Ok, lets go with this for 1.1 and fix properly in 1.2
V2: rebase on master Tested with: SOF master kernel:pierre V4.14 branch
It does not build on all targets
make[2]: Entering directory '/home/lrg/source/reef/reef.git/src/drivers' xtensa-byt-elf-gcc -DHAVE_CONFIG_H -I. -I../../src/include -mtext-section-literals -I /home/lrg/source/reef/reef.git/src/include -I /home/lrg/source/reef/reef.git/../xtensa-root/xtensa-byt-elf/include -I /home/lrg/source/reef/reef.git/src/arch/xtensa/include -I /home/lrg/source/reef/reef.git/src/arch/xtensa/xtos -I /home/lrg/source/reef/reef.git/src/platform/baytrail/include -O2 -g -Wall -Werror -Wl,-EL -Wmissing-prototypes -fno-inline-functions -nostdlib -mlongcalls -MT libdrivers_a-dw-dma.o -MD -MP -MF .deps/libdrivers_a-dw-dma.Tpo -c -o libdrivers_a-dw-dma.o `test -f 'dw-dma.c' || echo './'`dw-dma.c dw-dma.c: In function 'dw_dma_irq_cnl': dw-dma.c:1149:16: error: 'DMA_GP_LP_DMAC0' undeclared (first use in this function) dma = dma_get(DMA_GP_LP_DMAC0); ^ dw-dma.c:1149:16: note: each undeclared identifier is reported only once for each function it appears in dw-dma.c:1155:16: error: 'DMA_GP_LP_DMAC1' undeclared (first use in this function) dma = dma_get(DMA_GP_LP_DMAC1); ^ dw-dma.c: At top level: dw-dma.c:1143:13: error: 'dw_dma_irq_cnl' defined but not used [-Werror=unused-function] static void dw_dma_irq_cnl(void *data) ^ cc1: all warnings being treated as errors
Please resend and make sure it builds for all targets.
Thanks
Liam