On 8/7/19 10:29 AM, Daniel Baluta wrote:
On Tue, Jul 23, 2019 at 6:19 PM Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com wrote:
diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig index 61b97fc55bb2..2aa3a1cdf60c 100644 --- a/sound/soc/sof/Kconfig +++ b/sound/soc/sof/Kconfig @@ -36,6 +36,15 @@ config SND_SOC_SOF_ACPI Say Y if you need this option If unsure select "N".
+config SND_SOC_SOF_DT
tristate "SOF DT enumeration support"select SND_SOC_SOFselect SND_SOC_SOF_OPTIONShelpThis adds support for Device Tree enumeration. This option isrequired to enable i.MX8 devices.Say Y if you need this option. If unsure select "N".[snip]
diff --git a/sound/soc/sof/imx/Kconfig b/sound/soc/sof/imx/Kconfig index fff64a9970f0..fa35994a79c4 100644 --- a/sound/soc/sof/imx/Kconfig +++ b/sound/soc/sof/imx/Kconfig @@ -12,6 +12,7 @@ if SND_SOC_SOF_IMX_TOPLEVEL
config SND_SOC_SOF_IMX8 tristate "SOF support for i.MX8"
select SND_SOC_SOF_DTThis looks upside down. You should select SOF_DT first then include the NXP stuff.
One more thing: So this should be 'depends on SND_SOC_SOF_DT' right?
I would do this:
config SND_SOC_SOF_DT tristate "SOF DT enumeration support" depends on OF # or whatever the top-level DT dependency is select SND_SOC_SOF select SND_SOC_SOF_OPTIONS
config SND_SOC_SOF_IMX_TOPLEVEL bool "SOF support for NXP i.MX audio DSPs" depends on ARM64 && SND_SOC_SOF_DT || COMPILE_TEST if SND_SOC_SOF_IMX_TOPLEVEL
config SND_SOC_SOF_IMX8 tristate "SOF support for i.MX8"
In other words push the dependencies at a higher level.