April 2024 - Sound-open-firmware - mailman.alsa-project.org

Re: [PATCH] ASoC: SOF: Clean up sof_ipc_flood_dfs_write()
by Mark Brown 04 Apr '24

04 Apr '24

On Thu, 04 Apr 2024 10:34:53 +0300, Dan Carpenter wrote: > This function doesn't support partial writes so using > simple_write_to_buffer() doesn't really make sense. It's better to > just use copy_from_user(). > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: SOF: Clean up sof_ipc_flood_dfs_write() commit: 2cfa0eea2675ce569dc80d2c0d2d644a452b77b3 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark

1 0

Re: [PATCH] ASoC: SOF: Disable pointless writes to debugfs file
by Mark Brown 04 Apr '24

04 Apr '24

On Thu, 04 Apr 2024 10:38:45 +0300, Dan Carpenter wrote: > The permissions on this debugfs file are 0444 so it can't be written to. > And writing to the file hasn't done anything since commit 6e9548cdb30e > ("ASoC: SOF: Convert the generic IPC flood test into SOF client"). > Delete the write function. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: SOF: Disable pointless writes to debugfs file commit: 84ae7d9cfa5f6ec284efccedcb7baf7c075774d4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark

1 0

Re: [PATCH] ASoC: SOF: amd: fix for false dsp interrupts
by Mark Brown 04 Apr '24

04 Apr '24

On Thu, 04 Apr 2024 09:47:13 +0530, Vijendar Mukunda wrote: > Before ACP firmware loading, DSP interrupts are not expected. > Sometimes after reboot, it's observed that before ACP firmware is loaded > false DSP interrupt is reported. > Registering the interrupt handler before acp initialization causing false > interrupts sometimes on reboot as ACP reset is not applied. > Correct the sequence by invoking acp initialization sequence prior to > registering interrupt handler. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: SOF: amd: fix for false dsp interrupts commit: b9846a386734e73a1414950ebfd50f04919f5e24 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark

1 0

Re: [PATCH] ASoC: SOF: Clean up sof_ipc_flood_dfs_write()
by Péter Ujfalusi 04 Apr '24

04 Apr '24

On 04/04/2024 10:34, Dan Carpenter wrote: > This function doesn't support partial writes so using > simple_write_to_buffer() doesn't really make sense. It's better to > just use copy_from_user(). > > Signed-off-by: Dan Carpenter <dan.carpenter(a)linaro.org> Thanks, it makes sense. Acked-by: Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> > --- > sound/soc/sof/sof-client-ipc-flood-test.c | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/sound/soc/sof/sof-client-ipc-flood-test.c b/sound/soc/sof/sof-client-ipc-flood-test.c > index c0d6723aed59..1b2e9e25a836 100644 > --- a/sound/soc/sof/sof-client-ipc-flood-test.c > +++ b/sound/soc/sof/sof-client-ipc-flood-test.c > @@ -160,15 +160,20 @@ static ssize_t sof_ipc_flood_dfs_write(struct file *file, const char __user *buf > unsigned long ipc_count = 0; > struct dentry *dentry; > int err; > - size_t size; > char *string; > int ret; > > + if (*ppos != 0) > + return -EINVAL; > + > string = kzalloc(count + 1, GFP_KERNEL); > if (!string) > return -ENOMEM; > > - size = simple_write_to_buffer(string, count, ppos, buffer, count); > + if (copy_from_user(string, buffer, count)) { > + ret = -EFAULT; > + goto out; > + } > > /* > * write op is only supported for ipc_flood_count or > @@ -198,7 +203,7 @@ static ssize_t sof_ipc_flood_dfs_write(struct file *file, const char __user *buf > /* limit max duration/ipc count for flood test */ > if (flood_duration_test) { > if (!ipc_duration_ms) { > - ret = size; > + ret = count; > goto out; > } > > @@ -207,7 +212,7 @@ static ssize_t sof_ipc_flood_dfs_write(struct file *file, const char __user *buf > ipc_duration_ms = MAX_IPC_FLOOD_DURATION_MS; > } else { > if (!ipc_count) { > - ret = size; > + ret = count; > goto out; > } > > @@ -231,9 +236,9 @@ static ssize_t sof_ipc_flood_dfs_write(struct file *file, const char __user *buf > if (err < 0) > dev_err_ratelimited(dev, "debugfs write failed to idle %d\n", err); > > - /* return size if test is successful */ > + /* return count if test is successful */ > if (ret >= 0) > - ret = size; > + ret = count; > out: > kfree(string); > return ret; -- Péter

1 0

Re: [PATCH] ASoC: SOF: Disable pointless writes to debugfs file
by Péter Ujfalusi 04 Apr '24

04 Apr '24

On 04/04/2024 10:38, Dan Carpenter wrote: > The permissions on this debugfs file are 0444 so it can't be written to. > And writing to the file hasn't done anything since commit 6e9548cdb30e > ("ASoC: SOF: Convert the generic IPC flood test into SOF client"). > Delete the write function. I agree, it is not used anymore and ... > > Signed-off-by: Dan Carpenter <dan.carpenter(a)linaro.org> Acked-by: Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> > --- > I haven't tested this patch and there is a risk that it breaks some of > the test scripts. Another option would be to just make it a dummy > function that does { return count; }. But I thought I would try the > better option first. > > Please review this extra carefully. > > sound/soc/sof/debug.c | 19 ------------------- > 1 file changed, 19 deletions(-) > > diff --git a/sound/soc/sof/debug.c b/sound/soc/sof/debug.c > index 7c8aafca8fde..937e51b02a24 100644 > --- a/sound/soc/sof/debug.c > +++ b/sound/soc/sof/debug.c > @@ -19,24 +19,6 @@ > #include "sof-priv.h" > #include "ops.h" > > -static ssize_t sof_dfsentry_write(struct file *file, const char __user *buffer, > - size_t count, loff_t *ppos) > -{ > - size_t size; > - char *string; > - int ret; > - > - string = kzalloc(count+1, GFP_KERNEL); > - if (!string) > - return -ENOMEM; > - > - size = simple_write_to_buffer(string, count, ppos, buffer, count); > - ret = size; > - > - kfree(string); This was not too constructive ;) > - return ret; > -} > - > static ssize_t sof_dfsentry_read(struct file *file, char __user *buffer, > size_t count, loff_t *ppos) > { > @@ -126,7 +108,6 @@ static const struct file_operations sof_dfs_fops = { > .open = simple_open, > .read = sof_dfsentry_read, > .llseek = default_llseek, > - .write = sof_dfsentry_write, > }; > > /* create FS entry for debug files that can expose DSP memories, registers */ -- Péter

1 0