February 2022 - Sound-open-firmware - mailman.alsa-project.org

Re: [Sound-open-firmware] [PATCH] ASoC: SOF: Replace zero-length array with flexible-array member
by Mark Brown 17 Feb '22

17 Feb '22

On Thu, 17 Feb 2022 14:27:55 +0100, Stephen Kitt wrote: > There is a regular need in the kernel to provide a way to declare having > a dynamically sized set of trailing elements in a structure. Kernel code > should always use "flexible array members"[1] for these cases. The older > style of one-element or zero-length arrays should no longer be used[2]. > > This helps with the ongoing efforts to globally enable -Warray-bounds > and get us closer to being able to tighten the FORTIFY_SOURCE routines > on memcpy(). > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: SOF: Replace zero-length array with flexible-array member commit: 4fe6a63077a6d3c143d68f6b96e4051f1d0740ac All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark

1 0

Re: [Sound-open-firmware] [PATCH] ASoC: SOF: Replace zero-length array with flexible-array member
by Pierre-Louis Bossart 17 Feb '22

17 Feb '22

On 2/17/22 10:44, Gustavo A. R. Silva wrote: > On Thu, Feb 17, 2022 at 02:27:55PM +0100, Stephen Kitt wrote: >> There is a regular need in the kernel to provide a way to declare having >> a dynamically sized set of trailing elements in a structure. Kernel code >> should always use "flexible array members"[1] for these cases. The older >> style of one-element or zero-length arrays should no longer be used[2]. >> >> This helps with the ongoing efforts to globally enable -Warray-bounds >> and get us closer to being able to tighten the FORTIFY_SOURCE routines >> on memcpy(). >> >> [1] https://en.wikipedia.org/wiki/Flexible_array_member >> [2] https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-… >> >> Link: https://github.com/KSPP/linux/issues/78 >> Link: https://github.com/KSPP/linux/issues/180 >> Suggested-by: Gustavo A. R. Silva <gustavoars(a)kernel.org> >> Signed-off-by: Stephen Kitt <steve(a)sk2.org> > > Reviewed-by: Gustavo A. R. Silva <gustavoars(a)kernel.org> Thanks for the patch Acked-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> I just realized we have additional cases in this directory (interface between kernel and firmware), I'll send a follow-up patch a channel_map.h: int32_t ch_coeffs[0]; channel_map.h: struct sof_ipc_channel_map ch_map[0]; control.h: struct sof_ipc_ctrl_value_chan chanv[0]; control.h: struct sof_ipc_ctrl_value_comp compv[0]; control.h: struct sof_abi_hdr data[0]; control.h: struct sof_abi_hdr data[0]; > > Thanks! > -- > Gustavo > >> --- >> include/sound/sof/topology.h | 2 +- >> sound/soc/sof/topology.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/include/sound/sof/topology.h b/include/sound/sof/topology.h >> index d12736e14b69..adee6afd1490 100644 >> --- a/include/sound/sof/topology.h >> +++ b/include/sound/sof/topology.h >> @@ -237,7 +237,7 @@ struct sof_ipc_comp_process { >> /* reserved for future use */ >> uint32_t reserved[7]; >> >> - uint8_t data[0]; >> + uint8_t data[]; >> } __packed; >> >> /* frees components, buffers and pipelines >> diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c >> index e72dcae5e7ee..1d119d1dd69d 100644 >> --- a/sound/soc/sof/topology.c >> +++ b/sound/soc/sof/topology.c >> @@ -2164,7 +2164,7 @@ static int sof_process_load(struct snd_soc_component *scomp, int index, >> */ >> if (ipc_data_size) { >> for (i = 0; i < widget->num_kcontrols; i++) { >> - memcpy(&process->data + offset, >> + memcpy(&process->data[offset], >> wdata[i].pdata->data, >> wdata[i].pdata->size); >> offset += wdata[i].pdata->size; >> >> base-commit: f71077a4d84bbe8c7b91b7db7c4ef815755ac5e3 >> -- >> 2.27.0 >>

1 0

[Sound-open-firmware] [PATCH v17 0/2] mtk: add ADSP mailbox controller for MT8195
by allen-kh.cheng 15 Feb '22

15 Feb '22

From: Allen-KH Cheng <Allen-KH.Cheng(a)mediatek.com> Mediatek ADSP IPC is used to send notification or short message between processors with dsp. It will place the message to the share buffer and will access the ADSP mailbox registers to kick dsp. Two mailboxes used to send notification or short message between processors with dsp. This patchset was tested and confirmed on MT8195 cherry board. Based on linux-next changes since v16: - fix WARNING: modpost: missing MODULE_LICENSE() in drivers/mailbox /mtk-adsp-mailbox.o. Add MODULE_LICENSE in the last line. - Due to WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 in checkpatch, we don't remove SPDX-License in line 1. changes since v15: - add paragraphs to describe the config symbols fully changes since v14: - add inline for get_mtk_adsp_mbox_priv changes since v13: - rebase on v5.16-rc8 - add back ptr check from of_device_get_match_data changes since v12: - remove of_device_get_match_data ptr check: of_device_get_match_data(dev) will never going to return NULL. driver probe with compatible mediatek,mt8195-adsp-mbox. changes since v11: - remove useless MODULE_LICENSE changes since v10: - split up v9 into two separate submissions changes since v9: - rename adsp_mbox_chan_ops to mtk_adsp_mbox_chan_ops changes since v8: - remove struct adsp_mbox_ch_info - add get_mtk_adsp_mbox_priv - use mtk_adsp_mbox_priv va_mboxreg address in adsp mbox driver - add struct mtk_adsp_mbox_cfg for DSP mbox register offset - remove adsp mbox register offset hard code define - remove mtk-adsp-ipc.h reference in adsp mbox driver changes since v7: - add mtk prefix for adsp ipc functions - rename adsp_mbox_ch_info to mtk_adsp_mbox_ch_info - remove incorrect reviewers in commit message changes since v6: - dt-bindings: change example dtsi node. - rename config MTK_ADSP_IPC_MBOX to MTK_ADSP_MBOX - remove unused variable - add reviewers changes since v5: - remove some redundant code changes since v4: - use switch ... case in adsp_ipc_recv - add error handling path for chan_name pointer - refine some code to be concise changes since v3: - reorder MTK_ADSP_IPC_MBOX config - remove some redundant code - remove lock in mtk-adsp-mailbox changes since v2: - separate adsp_mailbox into two instances changes since v1: - fix dt_binding_check error Allen-KH Cheng (2): dt-bindings: mailbox: add mtk adsp-mbox document mailbox: mediatek: add support for adsp mailbox controller .../bindings/mailbox/mtk,adsp-mbox.yaml | 52 ++++++ drivers/mailbox/Kconfig | 9 + drivers/mailbox/Makefile | 2 + drivers/mailbox/mtk-adsp-mailbox.c | 176 ++++++++++++++++++ 4 files changed, 239 insertions(+) create mode 100644 Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml create mode 100644 drivers/mailbox/mtk-adsp-mailbox.c -- 2.18.0

2 4

[Sound-open-firmware] logger & Zephyr
by Daniel Baluta 07 Feb '22

07 Feb '22

Hi Marc, Is sof-logger and logging system working with sof/zephyr? For i.MX8 i get this error: [ 15.513398] sof-audio-of-imx8m 3b6e8000.dsp: error: can't set params for DMA for trace -19 [ 15.524768] sof-audio-of-imx8m 3b6e8000.dsp: warning: failed to initialize trace -19 I remember you were working on something about logging. Also, if it is working can you point me the source versions are you using. thanks, Daniel

2 1