- Patch - mailman.alsa-project.org

[PATCH] aplay: use snprintf instead of sprintf in device_list()
by Nishant Kumar Singh 11 Apr '26

11 Apr '26

sprintf() does not perform bounds checking. Replace it with snprintf() using sizeof(name) to follow safer coding practices and make the buffer size explicit, consistent with how similar fixes have been applied elsewhere in the codebase Signed-off-by: Nishant Kumar Singh <nishantsingh2jan1998(a)gmail.com> --- v2: Updated commit message as per review by Stian Skjelstad. Removed mention of "potential overflow" — the fix is retained as snprintf() is considered better practice over sprintf(). --- aplay/aplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aplay/aplay.c b/aplay/aplay.c index 0050032..74ec947 100644 --- a/aplay/aplay.c +++ b/aplay/aplay.c @@ -283,7 +283,7 @@ static void device_list(void) snd_pcm_stream_name(stream)); while (card >= 0) { char name[32]; - sprintf(name, "hw:%d", card); + snprintf(name, sizeof(name), "hw:%d", card); if ((err = snd_ctl_open(&handle, name, 0)) < 0) { error("control open (%i): %s", card, snd_strerror(err)); goto next_card; -- 2.43.0

2 1

[PATCH] aplay: use snprintf instead of sprintf in device_list()
by Kumar S 10 Apr '26

10 Apr '26

Hello, This patch replaces sprintf() with snprintf() when constructing the ALSA control device name string to prevent potential buffer overflow. Using sizeof(name) ensures the write stays within bounds. Signed-off-by: Nishant Kumar Singh <nishantsingh2jan1998(a)gmail.com> From 4ee7555c6260cf9b966a04134efdfcc67b99fe64 Mon Sep 17 00:00:00 2001 From: Nishant Kumar Singh <nishantsingh2jan1998(a)gmail.com> Date: Fri, 27 Mar 2026 03:56:10 +0000 Subject: [PATCH] aplay: use snprintf instead of sprintf in device_list() sprintf() does not perform bounds checking when writing to the name buffer. Replace it with snprintf() using sizeof(name) to ensure the write stays within the allocated buffer and prevent a potential buffer overflow. Signed-off-by: Nishant Kumar Singh <nishantsingh2jan1998(a)gmail.com> --- aplay/aplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aplay/aplay.c b/aplay/aplay.c index 0050032..74ec947 100644 --- a/aplay/aplay.c +++ b/aplay/aplay.c @@ -283,7 +283,7 @@ static void device_list(void) snd_pcm_stream_name(stream)); while (card >= 0) { char name[32]; - sprintf(name, "hw:%d", card); + snprintf(name, sizeof(name), "hw:%d", card); if ((err = snd_ctl_open(&handle, name, 0)) < 0) { error("control open (%i): %s", card, snd_strerror(err)); goto next_card; -- 2.43.0

2 7

🌟 Możliwość Otrzymania Darowizny – 1 000 000 USD 🌟
by brigentkin000＠gmail.com 04 Aug '25

04 Aug '25

🌟 Możliwość Otrzymania Darowizny – 1 000 000 USD 🌟 Nazywam się Susanne Klatten i jestem filantropką zaangażowaną w niesienie realnej pomocy poprzez przemyślane i skuteczne inicjatywy charytatywne. Z przyjemnością ogłaszam globalną inicjatywę dobroczynną, w ramach której dziesięć osób na całym świecie zostało wybranych do otrzymania darowizny w wysokości 1 000 000,00 USD każda. Ten ekskluzywny program filantropijny ma na celu: ✅ Wzmocnienie pozycji jednostek ✅ Zapewnienie stabilności finansowej ✅ Wsparcie w rozwoju osobistym i życiowym Jeśli uważasz, że możesz być jednym z potencjalnych beneficjentów lub chcesz uzyskać więcej informacji na temat procesu ubiegania się o darowiznę, zapraszamy do kontaktu: 📩 guillaumepousaz001(a)proton.me Z niecierpliwością czekamy na Twoją wiadomość i jesteśmy gotowi wesprzeć Cię na każdym etapie tej wyjątkowej szansy. Z wyrazami szacunku, Susanne Klatten Filantropka

1 0

test 12/24
by Jaroslav Kysela 11 Dec '24

11 Dec '24

test 12/24, please, ignore -- Jaroslav Kysela <perex(a)perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

1 0

test2
by Jaroslav Kysela 11 May '23

11 May '23

test2, please, ignore -- Jaroslav Kysela <perex(a)perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

1 0

test
by Jaroslav Kysela 11 May '23

11 May '23

ignore please -- Jaroslav Kysela <perex(a)perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

1 0

Re: [ALSA patch] [PATCH v2] ASoC: Intel: catpt: select WANT_DEV_COREDUMP
by Rojewski, Cezary 17 Nov '20

17 Nov '20

On 2020-11-17 3:52 PM, Gustaw Lewandowski wrote: > From: Piotr Maziarz <piotrx.maziarz(a)linux.intel.com> > > Select WANT_DEV_COREDUMP for catpt driver. > > Signed-off-by: Piotr Maziarz <piotrx.maziarz(a)linux.intel.com> > Signed-off-by: Gustaw Lewandowski <gustaw.lewandowski(a)linux.intel.com> > Thanks for this update, Gustaw. Acked-by: Cezary Rojewski <cezary.rojewski(a)intel.com> > -- > Changes in v2: > - change should be added to catpt only > --- > sound/soc/intel/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig > index a5b446d5af19..52ae7c981f56 100644 > --- a/sound/soc/intel/Kconfig > +++ b/sound/soc/intel/Kconfig > @@ -24,6 +24,7 @@ config SND_SOC_INTEL_CATPT > depends on DMADEVICES && SND_DMA_SGBUF > select DW_DMAC_CORE > select SND_SOC_ACPI_INTEL_MATCH > + select WANT_DEV_COREDUMP > help > Enable support for Intel(R) Haswell and Broadwell platforms > with I2S codec present. This is a recommended option. >

1 0

Re: [ALSA patch] [PATCH v3 1/1] ALSA: hda: Refactor calculating SDnFMT according to specification
by Takashi Iwai 22 Sep '20

22 Sep '20

On Tue, 22 Sep 2020 17:33:32 +0200, Pawel Harlozinski wrote: > > Fix setting SDnFMT based on :wq > High Definition Audio Specification Rev. 1.0a page 48. > > Bits per Sample (BITS): > 000 = 8 bits. The data will be packed in memory in 8-bit containers on 16-bit boundaries. > 001 = 16 bits. The data will be packed in memory in 16-bit containers on 16-bit boundaries. > 010 = 20 bits. The data will be packed in memory in 32-bit containers on 32-bit boundaries. > 011 = 24 bits. The data will be packed in memory in 32-bit containers on 32-bit boundaries. > 100 = 32 bits. The data will be packed in memory in 32-bit containers on 32-bit boundaries. > 101-111 = Reserved > > Set SDnFMT depending on which format was given. > Henceforth split cases for formats 20, 24, 32 bits, > but leave constraints to maxbps. > > Signed-off-by: Pawel Harlozinski <pawel.harlozinski(a)linux.intel.com> As I repeatedly wrote, the bits 20 and 24 cases never hit practically, hence this "refactoring" doesn't give any change in reality. Your commit misses that point. That said, this can be taken as a complementary for the theoretical case, but the situation has to be clarified in the commit log, and the subject should be adjusted as well. thanks, Takashi > > --- > > v3: drop gerrit Change-Id > v2: leave constraints to maxbps > > sound/hda/hdac_device.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/sound/hda/hdac_device.c b/sound/hda/hdac_device.c > index 3e9e9ac804f6..ccc47a10ba63 100644 > --- a/sound/hda/hdac_device.c > +++ b/sound/hda/hdac_device.c > @@ -764,7 +764,14 @@ unsigned int snd_hdac_calc_stream_format(unsigned int rate, > val |= AC_FMT_BITS_16; > break; > case 20: > + val |= AC_FMT_BITS_20; > + break; > case 24: > + if (maxbps >= 24) > + val |= AC_FMT_BITS_24; > + else > + val |= AC_FMT_BITS_20; > + break; > case 32: > if (maxbps >= 32 || format == SNDRV_PCM_FORMAT_FLOAT_LE) > val |= AC_FMT_BITS_32; > -- > 2.17.1 >

1 0

Re: [ALSA patch] [PATCH v2 1/1] ALSA: hda: Refactor calculating SDnFMT according to specification
by Takashi Iwai 21 Sep '20

21 Sep '20

On Mon, 21 Sep 2020 11:42:00 +0200, Pawel Harlozinski wrote: > > Fix setting SDnFMT based on High Definition Audio Specification Rev. 1.0a page 48. > > Bits per Sample (BITS): > 000 = 8 bits. The data will be packed in memory in 8-bit containers on 16-bit boundaries. > 001 = 16 bits. The data will be packed in memory in 16-bit containers on 16-bit boundaries. > 010 = 20 bits. The data will be packed in memory in 32-bit containers on 32-bit boundaries. > 011 = 24 bits. The data will be packed in memory in 32-bit containers on 32-bit boundaries. > 100 = 32 bits. The data will be packed in memory in 32-bit containers on 32-bit boundaries. > 101-111 = Reserved > > Set SDnFMT depending on which format was given. > Henceforth split cases for formats 20, 24, 32 bits, > but leave constraints to maxbps. As mentioned in the previous thread, practically seen, case 20 and 24 are never met, since HD-audio doesn't accept the SNDRV_PCM_FORMAT_20* or _24* due to the 32bit container. So this change is superfluous. I can take the change, but it has to be clarified that it won't affect the behavior on the real hardware but pure theoretical. > Change-Id: I97771b16da14e85b7f35372f5dfc87bb13bb5ce0 Please drop change-id. It's not useful for others. thanks, Takashi > Signed-off-by: Pawel Harlozinski <pawel.harlozinski(a)linux.intel.com> > --- > sound/hda/hdac_device.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/sound/hda/hdac_device.c b/sound/hda/hdac_device.c > index 3e9e9ac804f6..ccc47a10ba63 100644 > --- a/sound/hda/hdac_device.c > +++ b/sound/hda/hdac_device.c > @@ -764,7 +764,14 @@ unsigned int snd_hdac_calc_stream_format(unsigned int rate, > val |= AC_FMT_BITS_16; > break; > case 20: > + val |= AC_FMT_BITS_20; > + break; > case 24: > + if (maxbps >= 24) > + val |= AC_FMT_BITS_24; > + else > + val |= AC_FMT_BITS_20; > + break; > case 32: > if (maxbps >= 32 || format == SNDRV_PCM_FORMAT_FLOAT_LE) > val |= AC_FMT_BITS_32; > -- > 2.17.1 >

1 0

Re: [ALSA patch] [PATCH v2 1/1] ALSA: hda: Refactor calculating SDnFMT according to specification
by Rojewski, Cezary 21 Sep '20

21 Sep '20

On 2020-09-21 11:42 AM, Pawel Harlozinski wrote: > Fix setting SDnFMT based on High Definition Audio Specification Rev. 1.0a page 48. > > Bits per Sample (BITS): > 000 = 8 bits. The data will be packed in memory in 8-bit containers on 16-bit boundaries. > 001 = 16 bits. The data will be packed in memory in 16-bit containers on 16-bit boundaries. > 010 = 20 bits. The data will be packed in memory in 32-bit containers on 32-bit boundaries. > 011 = 24 bits. The data will be packed in memory in 32-bit containers on 32-bit boundaries. > 100 = 32 bits. The data will be packed in memory in 32-bit containers on 32-bit boundaries. > 101-111 = Reserved > > Set SDnFMT depending on which format was given. > Henceforth split cases for formats 20, 24, 32 bits, > but leave constraints to maxbps. > > Change-Id: I97771b16da14e85b7f35372f5dfc87bb13bb5ce0 Hello, checkpatch script should have notified you about need for removing Change-Id. Please remove for the next version. Has there been any explanation for why v2 is sent and what changes have been made between v1 and v2? Czarek > Signed-off-by: Pawel Harlozinski <pawel.harlozinski(a)linux.intel.com> > --- > sound/hda/hdac_device.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/sound/hda/hdac_device.c b/sound/hda/hdac_device.c > index 3e9e9ac804f6..ccc47a10ba63 100644 > --- a/sound/hda/hdac_device.c > +++ b/sound/hda/hdac_device.c > @@ -764,7 +764,14 @@ unsigned int snd_hdac_calc_stream_format(unsigned int rate, > val |= AC_FMT_BITS_16; > break; > case 20: > + val |= AC_FMT_BITS_20; > + break; > case 24: > + if (maxbps >= 24) > + val |= AC_FMT_BITS_24; > + else > + val |= AC_FMT_BITS_20; > + break; > case 32: > if (maxbps >= 32 || format == SNDRV_PCM_FORMAT_FLOAT_LE) > val |= AC_FMT_BITS_32; >

1 0