[alsa-devel] [PATCH] ASoC: core: No need to use strncmp()
Signed-off-by: Dimitris Papastamos dp@opensource.wolfsonmicro.com --- sound/soc/soc-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index d68a486..9f60894 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -2309,7 +2309,7 @@ struct snd_kcontrol *snd_soc_card_get_kcontrol(struct snd_soc_card *soc_card, return NULL;
list_for_each_entry(kctl, &card->controls, list) - if (!strncmp(kctl->id.name, name, sizeof(kctl->id.name))) + if (!strcmp(kctl->id.name, name)) return kctl; return NULL; } @@ -3056,7 +3056,7 @@ int snd_soc_limit_volume(struct snd_soc_codec *codec, return -EINVAL;
list_for_each_entry(kctl, &card->controls, list) { - if (!strncmp(kctl->id.name, name, sizeof(kctl->id.name))) { + if (!strcmp(kctl->id.name, name)) { found = 1; break; }
On Wed, Jul 31, 2013 at 09:44:13AM +0100, Dimitris Papastamos wrote:
Signed-off-by: Dimitris Papastamos dp@opensource.wolfsonmicro.com
Why?
On Wed, Jul 31, 2013 at 10:07:26AM +0100, Mark Brown wrote:
On Wed, Jul 31, 2013 at 09:44:13AM +0100, Dimitris Papastamos wrote:
Signed-off-by: Dimitris Papastamos dp@opensource.wolfsonmicro.com
Why?
Hm, strncmp() suggests that we might not care about the entire string. Although trivial, I thought strcmp() is clearer in this context.
On Wed, Jul 31, 2013 at 10:48:14AM +0100, Dimitris Papastamos wrote:
On Wed, Jul 31, 2013 at 10:07:26AM +0100, Mark Brown wrote:
On Wed, Jul 31, 2013 at 09:44:13AM +0100, Dimitris Papastamos wrote:
Signed-off-by: Dimitris Papastamos dp@opensource.wolfsonmicro.com
Why?
Hm, strncmp() suggests that we might not care about the entire string. Although trivial, I thought strcmp() is clearer in this context.
One of the reasons we use strncmp() here is to avoid going beyond the end of the fixed size buffer.
On Wed, Jul 31, 2013 at 12:01:47PM +0100, Mark Brown wrote:
On Wed, Jul 31, 2013 at 10:48:14AM +0100, Dimitris Papastamos wrote:
On Wed, Jul 31, 2013 at 10:07:26AM +0100, Mark Brown wrote:
On Wed, Jul 31, 2013 at 09:44:13AM +0100, Dimitris Papastamos wrote:
Signed-off-by: Dimitris Papastamos dp@opensource.wolfsonmicro.com
Why?
Hm, strncmp() suggests that we might not care about the entire string. Although trivial, I thought strcmp() is clearer in this context.
One of the reasons we use strncmp() here is to avoid going beyond the end of the fixed size buffer.
Right, surely though the kcontrol names are always null terminated? In any case, looks more safe to strncmp().
On Wed, Jul 31, 2013 at 12:59:29PM +0100, Dimitris Papastamos wrote:
On Wed, Jul 31, 2013 at 12:01:47PM +0100, Mark Brown wrote:
One of the reasons we use strncmp() here is to avoid going beyond the end of the fixed size buffer.
Right, surely though the kcontrol names are always null terminated? In any case, looks more safe to strncmp().
They probably should be but it's easy to get it wrong and hit exactly the array size.
participants (2)
-
Dimitris Papastamos -
Mark Brown