Re: [alsa-devel] [PATCH v3 1/4] ASoc: kirkwood: simplify probe error
On Wed, Jul 31, 2013 at 08:17:39AM +0200, Jean-Francois Moine wrote:
@@ -519,30 +532,17 @@ static int kirkwood_i2s_dev_probe(struct platform_device *pdev)
err = snd_soc_register_component(&pdev->dev, &kirkwood_i2s_component, soc_dai, 1);
- if (!err)
return 0;- dev_err(&pdev->dev, "snd_soc_register_component failed\n");
- if (!IS_ERR(priv->extclk))
clk_disable_unprepare(priv->extclk);- clk_disable_unprepare(priv->clk);
- if (err) {
dev_err(&pdev->dev, "snd_soc_register_component failed\n");goto fail;- }
- return 0;
This doesn't apply to mainline as there's a clk_put() there.
On Sat, 3 Aug 2013 13:39:54 +0100 Russell King - ARM Linux linux@arm.linux.org.uk wrote:
This doesn't apply to mainline as there's a clk_put() there.
Right, it applies to linux-next:
On Fri, 26 Jul 2013 11:32:50 +0100, Mark Brown broonie@kernel.org wrote:
Always submit against where the code will be applied - -next in this case.
On Sat, Aug 03, 2013 at 05:55:13PM +0200, Jean-Francois Moine wrote:
On Sat, 3 Aug 2013 13:39:54 +0100 Russell King - ARM Linux linux@arm.linux.org.uk wrote:
This doesn't apply to mainline as there's a clk_put() there.
Right, it applies to linux-next:
On Fri, 26 Jul 2013 11:32:50 +0100, Mark Brown broonie@kernel.org wrote:
Always submit against where the code will be applied - -next in this case.
Sorry, I'm just not going to bother with your patches unless you start posting them in such a way that interested parties can test them without having to run around and pull random trees. In other words, you should have Cc'd interested parties on that devm_* change patch - especially myself as I was the one who introduced that code.
On Sat, Aug 03, 2013 at 05:10:29PM +0100, Russell King - ARM Linux wrote:
having to run around and pull random trees. In other words, you should have Cc'd interested parties on that devm_* change patch - especially myself as I was the one who introduced that code.
That was me, sorry - Jean-Francios had nothing to do with the patch.
participants (3)
-
Jean-Francois Moine -
Mark Brown -
Russell King - ARM Linux