On Mon, 2011-01-31 at 11:22 +0000, Mark Brown wrote:

On Fri, Jan 28, 2011 at 11:36:47AM -0600, pl bossart wrote:

...

I've been trying to figure out what exactly needs to be filled in UCM configuration files, and so far it's been a pretty frustrating experience with alsa-utils/alsaucm :-(

CCing in Liam - please always remember to CC maintainers.

...

The interactive mode in alsa-utils/alsaucm is broken, I fixed a couple of segfaults and bad output (patches attached), but so far the only thing I can do is list the verbs...It looks like alsa-lib/include/use-case.h and alsa-utils/alsaucm are not aligned, whenever I query with predefined identifiers alsaucm seg faults or provides an error message that doesn't help much. This happens with the latest code.

...

[ume@plb alsaucm]$ ./alsaucm listcards 0: AudioPC this is my AudioPCI card 1: SDP4430 this is my SDP4430 card 2: TestHDA A test HDA card [ume@plb alsaucm]$ ./alsaucm -c AudioPCI list _verbs 0: HiFi Play and record HiFi quality Music. 1: Voice Full duplex low-power voice call

So far so good. Now the fun begins

[ume@plb alsaucm]$ ./alsaucm -c AudioPCI list _devices ./alsaucm: error failed to get list _devices: No such file or directory [ume@plb alsaucm]$ ./alsaucm -c AudioPCI set _verb HiFi ALSA lib main.c:1250:(set_verb_user) error: failed to initialize new use case: HiFi ./alsaucm: error failed to set _verb=HiFi: No such device [ume@plb alsaucm]$ ./alsaucm -c AudioPCI get _verb ./alsaucm: error failed to get _verb: No such file or directory

It looks like we need to improve the config file error reporting here. Adding line numbers would be good.

...

Likewise if the .conf file contains a cset in the default values, then the parser fails (I took the example from src/ucm/parser.c). Commenting out the cset is the only solution. What exactly is this index supposed to mean? SectionDefaults [ cdev "hw:AudioPCI" cset "name='Master Playback Switch',index=2 1,1" ]

Jaroslav is probably best placed to answer about the cset syntax.

The "index" is not required :-

cset "name='Master Playback Switch' 1,1"

...

[ume@plb alsaucm]$ ./alsaucm -c AudioPCI list _verbs ALSA lib main.c:302:(import_master_config) Unable to execute default sequence ALSA lib main.c:637:(snd_use_case_mgr_open) error: failed to import AudioPCI use case configuration -19 ./alsaucm: error failed to open sound card AudioPCI: No such device

Ideally I'd like to write an interface between PulseAudio and UCM, there are existing modules I can reuse to set voice or hifi modes, depending on what the client roles are. But if I can't make the examples work I don't think this is going to go anywhere.

There's some existing work going on with PulseAudio/UCM integration - Liam, I'd CC in Marga but I don't know what her new address.

I've CC'ed Margarita. She has started some work on PA and UCM integration and has some code that can read in the UCM verbs.

Margarita, could you provide a link to your PA git.

Thanks

Liam

...

cset "name='Master Playback Switch' 1,1"

For complete cset command look to 'amixer cset' syntax. You may get list of available identifiers using 'amixer controls'.

Thanks Jaroslav. I had not connected the dots with amixer. Works fine now for the defaults. I am still not able to get/set a verb

$ ./alsaucm -c TestHDA get _verb sh: my: command not found ./alsaucm: error failed to get _verb: No such file or directory

same for set. Isn't _verb a know identifier in src/ucm/main.c?

Thanks, -Pierre

On Mon, Jan 31, 2011 at 7:53 AM, Liam Girdwood lrg@slimlogic.co.uk wrote:

On Mon, 2011-01-31 at 11:22 +0000, Mark Brown wrote:

...

On Fri, Jan 28, 2011 at 11:36:47AM -0600, pl bossart wrote:

...

I've been trying to figure out what exactly needs to be filled in UCM configuration files, and so far it's been a pretty frustrating experience with alsa-utils/alsaucm :-(

CCing in Liam - please always remember to CC maintainers.

...

The interactive mode in alsa-utils/alsaucm is broken, I fixed a couple of segfaults and bad output (patches attached), but so far the only thing I can do is list the verbs...It looks like alsa-lib/include/use-case.h and alsa-utils/alsaucm are not aligned, whenever I query with predefined identifiers alsaucm seg faults or provides an error message that doesn't help much. This happens with the latest code.

...

...

[ume@plb alsaucm]$ ./alsaucm listcards   0: AudioPC     this is my AudioPCI card   1: SDP4430     this is my SDP4430 card   2: TestHDA     A test HDA card [ume@plb alsaucm]$ ./alsaucm -c AudioPCI list _verbs   0: HiFi     Play and record HiFi quality Music.   1: Voice     Full duplex low-power voice call

So far so good. Now the fun begins

[ume@plb alsaucm]$ ./alsaucm -c AudioPCI list _devices ./alsaucm: error failed to get list _devices: No such file or directory [ume@plb alsaucm]$ ./alsaucm -c AudioPCI set _verb HiFi ALSA lib main.c:1250:(set_verb_user) error: failed to initialize new use case: HiFi ./alsaucm: error failed to set _verb=HiFi: No such device [ume@plb alsaucm]$ ./alsaucm -c AudioPCI get _verb ./alsaucm: error failed to get _verb: No such file or directory

It looks like we need to improve the config file error reporting here. Adding line numbers would be good.

...

...

Likewise if the .conf file contains a cset in the default values, then the parser fails (I took the example from src/ucm/parser.c). Commenting out the cset is the only solution. What exactly is this index supposed to mean? SectionDefaults [ cdev "hw:AudioPCI" cset "name='Master Playback Switch',index=2 1,1" ]

Jaroslav is probably best placed to answer about the cset syntax.

The "index" is not required :-

cset "name='Master Playback Switch' 1,1"

...

...

[ume@plb alsaucm]$ ./alsaucm -c AudioPCI list _verbs ALSA lib main.c:302:(import_master_config) Unable to execute default sequence ALSA lib main.c:637:(snd_use_case_mgr_open) error: failed to import AudioPCI use case configuration -19 ./alsaucm: error failed to open sound card AudioPCI: No such device

Ideally I'd like to write an interface between PulseAudio and UCM, there are existing modules I can reuse to set voice or hifi modes, depending on what the client roles are. But if I can't make the examples work I don't think this is going to go anywhere.

There's some existing work going on with PulseAudio/UCM integration - Liam, I'd CC in Marga but I don't know what her new address.

I've CC'ed Margarita. She has started some work on PA and UCM integration and has some code that can read in the UCM verbs.

Margarita, could you provide a link to your PA git.

Here is the link to the PA git, it has the code that can read the ucm verbs.

http://git.slimlogic.co.uk/cgi-bin/cgit.cgi/pulseaudio.git/?h=9.20-ucm

If the following ucm command works then you will not have issues with the patch

$ alsaucm YOUR_CARD listv

Regards, Margarita

Thanks

Liam

Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk

---

Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

On Wed, 2011-02-02 at 09:11 +0100, Jaroslav Kysela wrote:

On Mon, 31 Jan 2011, Margarita Olaya wrote:

...

On Mon, Jan 31, 2011 at 7:53 AM, Liam Girdwood lrg@slimlogic.co.uk wrote:

...

...

Margarita, could you provide a link to your PA git.

Here is the link to the PA git, it has the code that can read the ucm verbs.

http://git.slimlogic.co.uk/cgi-bin/cgit.cgi/pulseaudio.git/?h=9.20-ucm

If the following ucm command works then you will not have issues with the patch

$ alsaucm YOUR_CARD listv

Regards, Margarita

This patch does not use the released UCM API in alsa-lib.

Margarita was using the earlier version of the alsaucm tool here, and was using a pre-release UCM branch. Now updated to use the release.

Also, more work is required to separate ALSA card from UCM card (to support virtual or mixed "soundcards").

Agreed, but Margarita will initially be targeting a simpler system with one sound card and then move on to support a virtual sound card.

Thanks

Liam

On Thu, 2011-02-03 at 09:31 -0600, pl bossart wrote:

...

...

Also, more work is required to separate ALSA card from UCM card (to support virtual or mixed "soundcards").

Agreed, but Margarita will initially be targeting a simpler system with one sound card and then move on to support a virtual sound card.

I quickly looked at the code. Interesting. I was thinking of a different approach where a separate pulseaudio module would open the use case manager, get the list of cards and verbs. this would be done on startup. Doing this inside module-alsa-card results in redundant activity, you're going to re-open and read the verbs for each card.

I should say that the initial design and patch implementation was carried out before Jaroslav added the virtual card support. The initial plan was to compute UCM values per card at startup.

This code is also experimental, Margarita planned to see what worked best with one card at first before moving to virtual card support.

I am also concerned about the card_set_profile() code in module-alsa-card if (nd->profile->is_ucm) { pa_log_debug("set UCM %s", nd->profile->name + 4); return snd_use_case_set(nd->profile->uc_mgr, verb, nd->profile->name + 4); } There's an awful amount of code after the return to handle multiple sinks that may become active for a given profile. Even if you have a single card, it's not clear to me how multiple devices would be handled (eg. voice, music, tones in the 4430 case) if you bypass this code. Are they considered as different sinks from a PulseAudio perspective? The routing and how devices allowed in a specific use case are exposed in PulseAudio isn't clear to me at all.

I don't think Margarita has got this far yet.

Last, looking at the code, I saw this comment /* FIXME: UCM needs to provide API to acquire verb comments */ A change is not needed, the list of verbs already comes as verb0, comment0, verb1, comment1, etc.

Again, this comment was from the ancient code.

My $0.02 -Pierre

I've CC'ed Colin for his $0.02 too. I do agree though, that with virtual card support it does seem right to create a new Pulseaudio module to manage UCM.

At a high level, the new module could :-

Compute use cases for each sound device at init { if (ucm config exists) use UCM config else use existing config method }

Whilst Pulseaudio would use computed use case values for every new client stream (using module-intended-roles ?).

Thoughts ?

Liam