[alsa-devel] bug in alsa-plugins: #if SND_PCM_EXTPLUG_VERSION wrong
in alsa-plugins 1.0.28 and 1.0.29, mix/*.c contain the following line:
#if SND_PCM_EXTPLUG_VERSION >= 0x102
that 0x102 needs to be 0x10002. i have alsa-lib 1.0.26 installed. its headers define SND_PCM_EXTPLUG_VERSION to 0x10001, corresponding to version number 1.0.1. that #if effectively tests for >= 0.1.2, so attempting to build alsa-plugins 1.0.28 or 1.0.29 results in a long list of errors. SND_CHMAP_MONO, SND_CHMAP_FL, etc are undeclared and snd_pcm_chmap_query_t is an unknown type.
in alsa-plugins 1.0.26 SND_PCM_EXTPLUG_VERSION is not tested. i didn't look at 1.0.27
reporting here because the bug tracker is down.
At Wed, 18 Mar 2015 15:58:39 +0000, Ethan Grammatikidis wrote:
in alsa-plugins 1.0.28 and 1.0.29, mix/*.c contain the following line:
#if SND_PCM_EXTPLUG_VERSION >= 0x102
that 0x102 needs to be 0x10002. i have alsa-lib 1.0.26 installed. its headers define SND_PCM_EXTPLUG_VERSION to 0x10001, corresponding to version number 1.0.1. that #if effectively tests for >= 0.1.2, so attempting to build alsa-plugins 1.0.28 or 1.0.29 results in a long list of errors. SND_CHMAP_MONO, SND_CHMAP_FL, etc are undeclared and snd_pcm_chmap_query_t is an unknown type.
in alsa-plugins 1.0.26 SND_PCM_EXTPLUG_VERSION is not tested. i didn't look at 1.0.27
Good catch, I fixed now in git tree.
Takashi
participants (2)
-
Ethan Grammatikidis -
Takashi Iwai