[PATCH][next] ALSA: i2c: tea6330t: Remove redundant initialization of variable err
![](https://secure.gravatar.com/avatar/c355fbcee7cc0c3af0720ef10032ad50.jpg?s=120&d=mm&r=g)
From: Colin Ian King colin.king@canonical.com
The variable err is being initialized with a value that is never read, it is being updated later on. The assignment is redundant and can be removed.
Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King colin.king@canonical.com --- sound/i2c/tea6330t.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/i2c/tea6330t.c b/sound/i2c/tea6330t.c index 742d0f724375..037d6293f728 100644 --- a/sound/i2c/tea6330t.c +++ b/sound/i2c/tea6330t.c @@ -284,7 +284,7 @@ int snd_tea6330t_update_mixer(struct snd_card *card, struct tea6330t *tea; const struct snd_kcontrol_new *knew; unsigned int idx; - int err = -ENOMEM; + int err; u8 default_treble, default_bass; unsigned char bytes[7];
![](https://secure.gravatar.com/avatar/5b19e9d0e834ea10ef75803718ad564b.jpg?s=120&d=mm&r=g)
On Fri, 11 Jun 2021 18:52:23 +0200, Colin King wrote:
From: Colin Ian King colin.king@canonical.com
The variable err is being initialized with a value that is never read, it is being updated later on. The assignment is redundant and can be removed.
Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King colin.king@canonical.com
Thanks, applied.
Takashi
participants (2)
-
Colin King
-
Takashi Iwai