Re: [alsa-devel] [ath5k-devel] Bugs on aspire one A150
On Sat, 2008-12-13 at 16:08 +0200, Nick Kossifidis wrote:
2008/12/13 Maxim Levitsky maximlevitsky@gmail.com:
Hi,
Indeed gpio #3 controls the led. I patched ath5k to use it, and led works now fine.
Please share your patch with the rest and also post an lspci -vnn for your card so we can handle this in a generic way
This just a one liner hack
diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c index 9d2c597..a447937 100644 --- a/drivers/net/wireless/ath5k/base.c +++ b/drivers/net/wireless/ath5k/base.c @@ -2595,6 +2595,11 @@ ath5k_init_leds(struct ath5k_softc *sc) sc->led_pin = 1; sc->led_on = 1; /* active high */ } + + __set_bit(ATH_STAT_LEDSOFT, sc->status); + sc->led_pin = 3; + sc->led_on = 1; + if (!test_bit(ATH_STAT_LEDSOFT, sc->status)) goto out;
lspci -vnn:
03:00.0 Ethernet controller [0200]: Atheros Communications Inc. AR242x 802.11abg Wireless PCI Express Adapter [168c:001c] (rev 01) Subsystem: Foxconn International, Inc. Device [105b:e008] Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0, Cache Line Size: 64 bytes Interrupt: pin A routed to IRQ 18 Region 0: Memory at 55200000 (64-bit, non-prefetchable) [size=64K] Capabilities: <access denied> Kernel driver in use: ath5k Kernel modules: ath5k
Best regards, Maxim Levitsky
On Sat, 2008-12-13 at 16:36 +0200, Maxim Levitsky wrote:
On Sat, 2008-12-13 at 16:08 +0200, Nick Kossifidis wrote:
2008/12/13 Maxim Levitsky maximlevitsky@gmail.com:
Hi,
Indeed gpio #3 controls the led. I patched ath5k to use it, and led works now fine.
Please share your patch with the rest and also post an lspci -vnn for your card so we can handle this in a generic way
This just a one liner hack
diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c index 9d2c597..a447937 100644 --- a/drivers/net/wireless/ath5k/base.c +++ b/drivers/net/wireless/ath5k/base.c @@ -2595,6 +2595,11 @@ ath5k_init_leds(struct ath5k_softc *sc) sc->led_pin = 1; sc->led_on = 1; /* active high */ }
- __set_bit(ATH_STAT_LEDSOFT, sc->status);
- sc->led_pin = 3;
- sc->led_on = 1;
- if (!test_bit(ATH_STAT_LEDSOFT, sc->status)) goto out;
Best regards, Maxim Levitsky
Note: thus makes led to be off by default, otherwise set sc->led_on = 0
this also works
Regards, Maxim Levitsky
participants (1)
-
Maxim Levitsky