[alsa-devel] [patch] alsa-utils check if __USE_BSD is defined before compiling "BSD functions"
Hi,
Another bug/issue I tripped over when compiling alsa-utils in an environment using uClibc to supply the C library functions. Here I have enabled some old BSD style functions. The attached patch will honor them if they are enabled.
Without this patch I get a redefined error during compile.
At Mon, 8 Dec 2008 07:26:02 +0100, Hans-Christian Egtvedt wrote:
Hi,
Another bug/issue I tripped over when compiling alsa-utils in an environment using uClibc to supply the C library functions. Here I have enabled some old BSD style functions. The attached patch will honor them if they are enabled.
Without this patch I get a redefined error during compile.
Hmm, but with this patch, I get undefined reference errors :) alsactl/init_sysfs.c:39: undefined reference to `strlcpy' ....
Checking __USB_BSD seems insufficient, unfortunately.
thanks,
Takashi
-- Best regards, Hans-Christian Egtvedt [2 alsa-utils-1.0.18-check-if-__use_bsd-is-defined.patch <text/x-patch (7bit)>] Index: alsa-utils-1.0.18/alsactl/init_sysdeps.c =================================================================== --- alsa-utils-1.0.18.orig/alsactl/init_sysdeps.c 2008-12-01 08:27:16.000000000 +0100 +++ alsa-utils-1.0.18/alsactl/init_sysdeps.c 2008-12-01 08:27:22.000000000 +0100 @@ -17,7 +17,7 @@
*/
-#ifdef __GLIBC__ +#if defined(__GLIBC__) && !defined(__USE_BSD) static size_t strlcpy(char *dst, const char *src, size_t size) { size_t bytes = 0; [3 <text/plain; us-ascii (7bit)>] _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
On Mon, 08 Dec 2008 08:34:55 +0100 Takashi Iwai tiwai@suse.de wrote:
At Mon, 8 Dec 2008 07:26:02 +0100, Hans-Christian Egtvedt wrote:
Hi,
Another bug/issue I tripped over when compiling alsa-utils in an environment using uClibc to supply the C library functions. Here I have enabled some old BSD style functions. The attached patch will honor them if they are enabled.
Without this patch I get a redefined error during compile.
Hmm, but with this patch, I get undefined reference errors :) alsactl/init_sysfs.c:39: undefined reference to `strlcpy' ....
Checking __USB_BSD seems insufficient, unfortunately.
Perhaps it should be UCLIBC specific? Something like "&& !(defined(__UCLIBC__) && defined(__USE_BSD))"
At Mon, 8 Dec 2008 08:48:48 +0100, Hans-Christian Egtvedt wrote:
On Mon, 08 Dec 2008 08:34:55 +0100 Takashi Iwai tiwai@suse.de wrote:
At Mon, 8 Dec 2008 07:26:02 +0100, Hans-Christian Egtvedt wrote:
Hi,
Another bug/issue I tripped over when compiling alsa-utils in an environment using uClibc to supply the C library functions. Here I have enabled some old BSD style functions. The attached patch will honor them if they are enabled.
Without this patch I get a redefined error during compile.
Hmm, but with this patch, I get undefined reference errors :) alsactl/init_sysfs.c:39: undefined reference to `strlcpy' ....
Checking __USB_BSD seems insufficient, unfortunately.
Perhaps it should be UCLIBC specific? Something like "&& !(defined(__UCLIBC__) && defined(__USE_BSD))"
Should be fine. This fix is committed now.
Thanks,
Takashi
participants (2)
-
Hans-Christian Egtvedt -
Takashi Iwai