At Tue, 4 Nov 2008 18:27:11 +0100, Elimar Riesebieter wrote:

• Takashi Iwai [081104 17:40 +0100]

...

At Tue, 4 Nov 2008 14:44:34 +0100, Elimar Riesebieter wrote:

...

Hi all,

please note the following error:

/usr/bin/make -C /usr/src/linux-2.6.27.2 SUBDIRS=/usr/src/modules/alsa-driver CPP="gcc-4.3 -E" CC="gcc-4.3" modules make[4]: Entering directory `/usr/src/linux-2.6.27.2' CC [M] /usr/src/modules/alsa-driver/acore/hwdep.o In file included from /usr/src/linux-2.6.27.2/arch/powerpc/include/asm/system.h:528, from include/linux/list.h:7, from include/linux/module.h:9, from /usr/src/modules/alsa-driver/include/adriver.h:26, from /usr/src/modules/alsa-driver/acore/hwdep.c:1: include/asm-generic/cmpxchg-local.h: In function '__cmpxchg_local_generic': include/asm-generic/cmpxchg-local.h:23: error: implicit declaration of function 'local_irq_save' include/asm-generic/cmpxchg-local.h:44: error: implicit declaration of function 'local_irq_restore' make[6]: *** [/usr/src/modules/alsa-driver/acore/hwdep.o] Fehler 1 make[5]: *** [/usr/src/modules/alsa-driver/acore] Fehler 2 make[4]: *** [_module_/usr/src/modules/alsa-driver] Fehler 2 make[4]: Leaving directory `/usr/src/linux-2.6.27.2' make[3]: *** [compile] Fehler 2 make[3]: Leaving directory `/usr/src/modules/alsa-driver' make[2]: *** [build-stamp] Fehler 2 make[2]: Leaving directory `/usr/src/modules/alsa-driver' make[1]: *** [kdist_image] Fehler 2 make[1]: Leaving directory `/usr/src/modules/alsa-driver' Module /usr/src/modules/alsa-driver failed.

Same on 2.6.28-rc3

BTW, alsa-driver 1.0.18 builds fine on PPC 2.6.26. The PPC divers build fine out of vanilla trees (1.6.26/1.0.17 and 2.6.28/1.0.18-rc3)

Could you check the snapshot tarball below? ftp://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/alsa-driver-snapshot.tar.gz

# ./gitcompile

..... make[1]: Entering directory `/usr/src/linux-2.6.28-rc3' CC [M] /source/alsa/svn-pkg-alsa/tmp/alsa-driver/acore/hwdep.o In file included from /usr/src/linux-2.6.28-rc3/arch/powerpc/include/asm/system.h:528, from include/linux/list.h:7, from include/linux/module.h:9, from /source/alsa/svn-pkg-alsa/tmp/alsa-driver/include/adriver.h:57, from /source/alsa/svn-pkg-alsa/tmp/alsa-driver/acore/hwdep.c:1: include/asm-generic/cmpxchg-local.h: In function '__cmpxchg_local_generic': include/asm-generic/cmpxchg-local.h:23: error: implicit declaration of function 'local_irq_save' include/asm-generic/cmpxchg-local.h:44: error: implicit declaration of function 'local_irq_restore' make[3]: *** [/source/alsa/svn-pkg-alsa/tmp/alsa-driver/acore/hwdep.o] Fehler 1 make[2]: *** [/source/alsa/svn-pkg-alsa/tmp/alsa-driver/acore] Fehler 2 make[1]: *** [_module_/source/alsa/svn-pkg-alsa/tmp/alsa-driver] Fehler 2 make[1]: Leaving directory `/usr/src/linux-2.6.28-rc3' make: *** [compile] Fehler 2

Does sound-2.6.git tree work with 2.6.28-rc3? git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git

Pull master branch on 2.6.28-rc3 git. If so, possibly it's a missing include path for asm/*.h or so...

Or, just try to add #include <linux/kernel.h> before the inclusion of linux/module.h in alsa-driver/include/adriver.h.

Takashi

* Elimar Riesebieter [081104 21:00 +0100]

• Takashi Iwai [081104 19:00 +0100]

[...]

...

Does sound-2.6.git tree work with 2.6.28-rc3? git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git

Pull master branch on 2.6.28-rc3 git. If so, possibly it's a missing include path for asm/*.h or so...

Building 2.6.28-rc3 inline drivers works.

...

Or, just try to add #include <linux/kernel.h> before the inclusion of linux/module.h in alsa-driver/include/adriver.h.

That doesn't work either.

In 2.6.27, 2.6.28-rc? and sound-2.6.git we are missing include/asm-powerpc which configure is looking for:

checking for kernel linux/devfs_fs_kernel.h... no Creating a dummy <linux/devfs_fs_kernel.h>... -- checking for kernel asm/hw_irq.h... no Creating a dummy <asm/hw_irq.h>... -- checking for kernel asm/irq_regs.h... no Creating a dummy <asm/irq_regs.h>...

configure links include/asm-arch to asm, though. hw_irq.h and irq_regs.h, where local_irq_save and local_irq_restore is defined, I found in /arch/powerpc/include/asm.

My temporaire solution:

1. put #include <linux/mm.h> in alsa-driver/include/adriver.h 2. copy arch/powerpc/include/asm/* into include asm-powerpc 3. build suceeded

At this moment I need an idea how to patch configure script to do that.

But devfs_fs_kernel.h I found in none of 2.6.2[6-8]?

We don't use devfs anymore ;)

Thanks Elimar

At Wed, 05 Nov 2008 08:56:33 +0100, I wrote:

At Tue, 4 Nov 2008 23:40:01 +0100, Elimar Riesebieter wrote:

...

• Elimar Riesebieter [081104 21:00 +0100]

...

• Takashi Iwai [081104 19:00 +0100]

[...]

...

Does sound-2.6.git tree work with 2.6.28-rc3? git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git

Pull master branch on 2.6.28-rc3 git. If so, possibly it's a missing include path for asm/*.h or so...

Building 2.6.28-rc3 inline drivers works.

...

Or, just try to add #include <linux/kernel.h> before the inclusion of linux/module.h in alsa-driver/include/adriver.h.

That doesn't work either.

In 2.6.27, 2.6.28-rc? and sound-2.6.git we are missing include/asm-powerpc which configure is looking for:

checking for kernel linux/devfs_fs_kernel.h... no Creating a dummy <linux/devfs_fs_kernel.h>... -- checking for kernel asm/hw_irq.h... no Creating a dummy <asm/hw_irq.h>... -- checking for kernel asm/irq_regs.h... no Creating a dummy <asm/irq_regs.h>...

configure links include/asm-arch to asm, though. hw_irq.h and irq_regs.h, where local_irq_save and local_irq_restore is defined, I found in /arch/powerpc/include/asm.

My temporaire solution:

1. put #include <linux/mm.h> in alsa-driver/include/adriver.h
2. copy arch/powerpc/include/asm/* into include asm-powerpc
3. build suceeded

At this moment I need an idea how to patch configure script to do that.

How about the patch below?

Apparently not enough. I fixed now my git tree, so that it works at least for 2.6.28 x86*. Hopefully this also fixes PPC issues.

Takashi

At Wed, 5 Nov 2008 21:45:14 +0100, Elimar Riesebieter wrote:

• Takashi Iwai [081105 17:40 +0100]

...

At Wed, 05 Nov 2008 08:56:33 +0100, I wrote:

[...]

...

...

How about the patch below?

Apparently not enough. I fixed now my git tree, so that it works at least for 2.6.28 x86*. Hopefully this also fixes PPC issues.

Thanks a lot Takashi. I've testet the latest snapshot (081105) on x86|powerpc 2.6.2[6-8]. Builds fine.

Glad to hear now that's fixed.

So are you going to release a alsa-driver-1.0.18a?

I don't know -- it's Jaroslav's take.

This is because we want to distribute that package in DEBIAN. A patch against your latest snapshot is too much, though. Please notice, that the actual release buils only on <= 2.6.26 and on >2.6.26 only at arch x86. Else should your snapshot hopefully built on all arch/$ARCH/include. Isn't that reasonable?

The simplest way is to use the latest snapshot version for all architectures. Some other fixes are missing in 1.0.18, too.

thanks,

Takashi

Many thanks for cooperation.

For the DEBIAN ALSA maintainers: Elimar

-- It's a good thing we don't get all the government we pay for.

* Jaroslav Kysela [081106 09:00 +0100]

On Thu, 6 Nov 2008, Takashi Iwai wrote:

...

At Wed, 5 Nov 2008 21:45:14 +0100, Elimar Riesebieter wrote:

...

...

So are you going to release a alsa-driver-1.0.18a?

I don't know -- it's Jaroslav's take.

Elimar, could you test snapsnot from http://www.alsa-project.org/snapshot ?

I'll tag it as 1.0.18a if your compilation tests passes.

alsa-driver-1.0.18.16.gda570.76.gd577a.tar.bz2 compiled on:

powerpc: 2.6.2[6-8] x86: 2.6.2[6-8] 32bit x86: 2.6.2[6-8] on an amd64 kernel.

Thanks Elimar