Re: [alsa-devel] [PATCH 00/19] ASoC: SOF: improvements for ABI checks and Intel code
On 5/5/19 10:51 PM, Mark Brown wrote:
On Fri, May 03, 2019 at 09:47:39AM -0500, Pierre-Louis Bossart wrote:
On 5/3/19 12:40 AM, Mark Brown wrote:
reviewer fatigue setting in with this stuff, one thing that'd really help here is if there were some help from Intel people with review for the DPCM code.
I can certainly understand reviewer fatigue, i've had to put a time limit on daily reviews to keep my sanity, but I don't get your last point. These patches were submitted and reviewed by Intel people on GitHub, what you see here is the result of multiple iterations precisely to make sure the patches are acceptable for upstream. we've set the goal of having two Intel aprovers for each patch. Can you elaborate on how we can make your life simpler?
The last point there is that Intel only write patches, nobody from Intel is reviewing other people's patches especially in areas of the code like DPCM which are complex, fragile and where Intel is by far the most active user.
It's a valid point, and for now we indeed only check for non-regressions and provide point solutions without looking at the bigger picture. We have a couple of people ramping up (Ranjani, Libin, Guennadi, Jaska) and hopefully at some point we'll be able to review and improve.
On Mon, May 06, 2019 at 09:59:24AM -0500, Pierre-Louis Bossart wrote:
On 5/5/19 10:51 PM, Mark Brown wrote:
The last point there is that Intel only write patches, nobody from Intel is reviewing other people's patches especially in areas of the code like DPCM which are complex, fragile and where Intel is by far the most active user.
It's a valid point, and for now we indeed only check for non-regressions and provide point solutions without looking at the bigger picture. We have a couple of people ramping up (Ranjani, Libin, Guennadi, Jaska) and hopefully at some point we'll be able to review and improve.
Even just testing (rather than reviewing, though obviously reviewing would be good!) patches off the list would be very helpful and is close to the regression testing stuff you're already doing.
participants (2)
-
Mark Brown -
Pierre-Louis Bossart