[PATCH] ASoC: adau1372: add missing dependencies
SND_SOC_ADAU1372_I2C and SND_SOC_ADAU1372_SPI prpoerly select the REGMAP config they need but forget to depend on the underlying bus.
Signed-off-by: Alexandre Belloni alexandre.belloni@bootlin.com --- sound/soc/codecs/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index a457300f95da..625f762903ea 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -371,11 +371,13 @@ config SND_SOC_ADAU1372
config SND_SOC_ADAU1372_I2C tristate "Analog Devices ADAU1372 CODEC (I2C)" + depends on I2C select SND_SOC_ADAU1372 select REGMAP_I2C
config SND_SOC_ADAU1372_SPI tristate "Analog Devices ADAU1372 CODEC (SPI)" + depends on SPI select SND_SOC_ADAU1372 select REGMAP_SPI
On 30/11/2020 22:56:26+0100, Alexandre Belloni wrote:
SND_SOC_ADAU1372_I2C and SND_SOC_ADAU1372_SPI prpoerly select the REGMAP config they need but forget to depend on the underlying bus.
Signed-off-by: Alexandre Belloni alexandre.belloni@bootlin.com
I forgot:
Reported-by: kernel test robot lkp@intel.com
sound/soc/codecs/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index a457300f95da..625f762903ea 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -371,11 +371,13 @@ config SND_SOC_ADAU1372
config SND_SOC_ADAU1372_I2C tristate "Analog Devices ADAU1372 CODEC (I2C)"
- depends on I2C select SND_SOC_ADAU1372 select REGMAP_I2C
config SND_SOC_ADAU1372_SPI tristate "Analog Devices ADAU1372 CODEC (SPI)"
- depends on SPI select SND_SOC_ADAU1372 select REGMAP_SPI
-- 2.28.0
On Mon, 30 Nov 2020 22:56:26 +0100, Alexandre Belloni wrote:
SND_SOC_ADAU1372_I2C and SND_SOC_ADAU1372_SPI prpoerly select the REGMAP config they need but forget to depend on the underlying bus.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: adau1372: add missing dependencies (no commit info)
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (2)
-
Alexandre Belloni -
Mark Brown