[alsa-devel] [PATCH] ASoC: Remove redundant freq assignment for max98095->sysclk/max98088->sysclk
Current implementation set max98095->sysclk/max98088->sysclk to freq twice. Set it once is enough, this patch removes the first assignment in case we may set invalid clock frequency to max98095->sysclk/max98088->sysclk.
Signed-off-by: Axel Lin axel.lin@gmail.com --- hi Peter, I don't have this hardware handy. Can you help to test it? Thanks, Axel
sound/soc/codecs/max98088.c | 2 -- sound/soc/codecs/max98095.c | 2 -- 2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c index 4173b67..ac65a2d 100644 --- a/sound/soc/codecs/max98088.c +++ b/sound/soc/codecs/max98088.c @@ -1397,8 +1397,6 @@ static int max98088_dai_set_sysclk(struct snd_soc_dai *dai, if (freq == max98088->sysclk) return 0;
- max98088->sysclk = freq; /* remember current sysclk */ - /* Setup clocks for slave mode, and using the PLL * PSCLK = 0x01 (when master clk is 10MHz to 20MHz) * 0x02 (when master clk is 20MHz to 30MHz).. diff --git a/sound/soc/codecs/max98095.c b/sound/soc/codecs/max98095.c index e1d282d..872a5fa 100644 --- a/sound/soc/codecs/max98095.c +++ b/sound/soc/codecs/max98095.c @@ -1517,8 +1517,6 @@ static int max98095_dai_set_sysclk(struct snd_soc_dai *dai, if (freq == max98095->sysclk) return 0;
- max98095->sysclk = freq; /* remember current sysclk */ - /* Setup clocks for slave mode, and using the PLL * PSCLK = 0x01 (when master clk is 10MHz to 20MHz) * 0x02 (when master clk is 20MHz to 40MHz)..
On 27/05/11 16:30, Axel Lin wrote:
Current implementation set max98095->sysclk/max98088->sysclk to freq twice. Set it once is enough, this patch removes the first assignment in case we may set invalid clock frequency to max98095->sysclk/max98088->sysclk.
Signed-off-by: Axel Lin axel.lin@gmail.com
hi Peter, I don't have this hardware handy. Can you help to test it? Thanks, Axel
Acked-by: Liam Girdwood lrg@ti.com
On Fri, May 27, 2011, Alex Lin wrote:
Current implementation set max98095->sysclk/max98088->sysclk to freq twice. Set it once is enough, this patch removes the first assignment in case we may set invalid clock frequency to max98095->sysclk/max98088->sysclk.
Signed-off-by: Axel Lin axel.lin@gmail.com
hi Peter, I don't have this hardware handy. Can you help to test it? Thanks, Axel
Acked-by: Peter Hsiang peter.hsiang@maxim-ic.com
On Fri, May 27, 2011 at 11:30:53PM +0800, Axel Lin wrote:
Current implementation set max98095->sysclk/max98088->sysclk to freq twice. Set it once is enough, this patch removes the first assignment in case we may set invalid clock frequency to max98095->sysclk/max98088->sysclk.
Applied, thanks.
participants (4)
-
Axel Lin
-
Liam Girdwood
-
Mark Brown
-
Peter Hsiang