On Fri, Feb 15, 2019 at 06:21:04PM +0100, Takashi Iwai wrote:

Actually it's not all. As mentioned in my earlier post, there are more of refcount unbalance in the code. Lots of them, really.

Below is a patch I've fixed quickly over the whole scanning the sound tree. Some might be incorrect, so more detailed review for each piece of change is needed...

Extra references aren't such a problem for practical systems since we don't actually ever free any of the DT (there's no mainline way to use overlays yet...), that's how none of this stuff ever gets noticed. I'm not surprised there's loads of missing frees TBH. In contrast if we've got extra frees they will get noticed and cause problems.