[alsa-devel] device_create_drvdata missing on older kernels
I could not compile current git. (Error on acore/init.c)
Adding this to adriver.h fixed it for me. I'm not sure if this is the correct general fix?
#ifndef CONFIG_SND_HAS_DEVICE_CREATE_DRVDATA #define device_create_drvdata(c,d,m,p,s,n) device_create((c),(d),(m),(s),(n)) #endif
(My kernel 2.6.24-19-generic)
On Wed, 30 Jul 2008, Eliot Blennerhassett wrote:
I could not compile current git. (Error on acore/init.c)
Adding this to adriver.h fixed it for me. I'm not sure if this is the correct general fix?
#ifndef CONFIG_SND_HAS_DEVICE_CREATE_DRVDATA #define device_create_drvdata(c,d,m,p,s,n) device_create((c),(d),(m),(s),(n)) #endif
It looks like a correct fix. Applied. Thanks.
Jaroslav
----- Jaroslav Kysela perex@perex.cz Linux Kernel Sound Maintainer ALSA Project, Red Hat, Inc.
At Wed, 30 Jul 2008 15:00:34 +1200, Eliot Blennerhassett wrote:
I could not compile current git. (Error on acore/init.c)
Adding this to adriver.h fixed it for me. I'm not sure if this is the correct general fix?
#ifndef CONFIG_SND_HAS_DEVICE_CREATE_DRVDATA #define device_create_drvdata(c,d,m,p,s,n) device_create((c),(d),(m),(s),(n)) #endif
It works right now for vanilla, but not for linux-next, unfortunately. device_create_drvdata() is gone again in the next kernel. Long live the function.
Could you check it's fixed on the snapshot tarball? http://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/
Takashi
On Wednesday 30 July 2008 22:31:47 Takashi Iwai wrote:
Could you check it's fixed on the snapshot tarball? http://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/
yes thanks compiles fine for me
-- Eliot
participants (3)
-
Eliot Blennerhassett -
Jaroslav Kysela -
Takashi Iwai