On Mon, Aug 22, 2011 at 7:16 PM, Felipe Balbi balbi@ti.com wrote:

...

But that would mean having two drivers in one file, because they are so different.

then make only a differnt function driver, f_uac2.c, which gets added as another interface (or configuration) to audio.c.

Yup, by audio.c I meant {audio.c + f_audio.c} and audio2.c {audio2.c + f_audio2.c}

...

Otherwise, please have a look at audio.c and audio2.c and suggest what exactly you mean.

audio.c doesn't do anything audio related. It's just adding the configuration to composite layer. The real specification is implemented in f_audio.c (should probably be called f_uac1.c, though).

Agreed. Reusing audio.c is quite reasonable. So, I'll :- * Merge audio2.c into audio.c * Rename f_audio.c -> f_uac1.c * Add new f_audio2.c as f_uac2.c * Add Kconfig switch to compile UAC_1 (audio.c + f_uac1.c) or UAC_2 (audio.c + f_uac2.c)

I'll wait for other comments and revise the patch after a few days.

Thanks.