On Wed, Dec 22, 2010 at 11:25:29PM +0530, Mark Brown wrote:

On Wed, Dec 22, 2010 at 10:39:55PM +0530, Koul, Vinod wrote:

...

So my codec map looks like: /*headset map*/ { "HSDAC Left", NULL, "PCM_In"}, { "HSDAC Right", NULL, "PCM_In"}, { "PCM_In", NULL, "Headset Rail"}, { "Headset Rail", NULL, "Audio Rail"},

...

    /*speaker map*/
    { "IHFDAC Left", NULL, "PCM_In"},
    { "IHFDAC Right", NULL, "PCM_In"},
    { "PCM_In", NULL, "Speaker Rail"},
    { "Speaker Rail", NULL, "Audio Rail"},

...

But when the stream is started now all the widgets get powered on. The debugfs entry says

You have unconditionally connected both speaker and headphone widgets to the same input so when that input becomes active paths are completed to both outputs and both outpus are enabled.

Okay, that makes sense.

These "Rail" widgets look quite unusual - what are they?

Audio Supply rails, I have one global audio rail which controls most of audio widgets and then separate rails for speakers and headset. For example I need to turn on Audio supply rail and then headset rail for headsets to work properly. So I described them as SND_SOC_DAPM_SUPPLY. Added events so that I power them on and power off when stream becomes active or inactive.

...

What could I be doing wrong here? I want to add this PCM button for all

streams

...

(4 eventually) and this be enabled whenever anyone of them is started.

What is a "PCM button" and what do you mean by starting a "stream"? Normally a stream would be a path between the CPU and the CODEC.

This is PCM interface enable between codec and cpu. So for PCM port to work between codec and cpu, we need to enable the PCM port, this one does that. This is going to be a global switch to be turned on for all streams (I have 4 playback and 1 capture, and can be simultaneous).

The way this works is that as described in reply to your previous mail DAPM powers anything on which has a completed path from input to output. As mentioned then if you have no routing control in the device the machine driver will arrange to enable and disable input and output widgets on the edge of the CODEC, either automatically using jack detection or by offering SOC_DAPM_PIN_SWITCH() or similar controls to applications.

So what I have is below picture in codec

PCM PORT -> HSDAC -> Earpiece/Headset* -> IHFDAC ->Speaker <- ADC <- MICs

(*this will be toggled by user using controls exposed by machine driver which will using SOC_DAPM_PIN_SWITCH as suggested by you)

Here I was trying 1) Putting the PCM_In Button as SND_SOC_DAPM_AIF_IN() 2) Add this to codec map for streams so that its enabled for all streams 3) Add supply rails before this so they are powered for this(which is working for me)

Now only problem for me is to how to add PCM button for all streams? I have few alternatives like doing this in supply events or in dai start function, but was hoping that since this can be represented as a widget it should be done thru the audio map

Any suggestions....

~Vinod

"Audio Supply" sounds like the main analogue bias for the CODEC - that would normally be managed by set_bias_level() rather than by having it supply every single widget in the CODEC map.

Yes that would make sense. But only for Audio rail which is global codec rail. What do you recommend for headset and speaker rails? They would be required only for headset and speaker DAI not rest.

If you have multiple links between the CPU and the CODEC with a single power bit to control them all I'd suggest defining several AIF widgets, each with no power management, then making the actual power controlled by a supply widget. That way the power will be enabled as required but you won't have tied all the data streams together in the DAPM map.

Okay so then why should I do with several AIF widgets, wont doing that in DAI startup be a better idea?

...

Here I was trying

1. Putting the PCM_In Button as SND_SOC_DAPM_AIF_IN()

I'm still not sure what you mean by "Button"? I'm guessing it's a register control for power.

Yes :)

~Vinod