[alsa-devel] [asoc:topic/ak4458 1/2] sound/soc/codecs/ak4458.c:577:28: sparse: symbol 'ak4458_regmap' was not declared. Should it be static?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/ak4458 head: 17e2304f0ad31d3f9bba4285b7024bf3c3626600 commit: 08660086eff9e9e69246a65ee48aba5c3901bf5e [1/2] ASoC: ak4458: Add support for AK4458 DAC driver reproduce: # apt-get install sparse git checkout 08660086eff9e9e69246a65ee48aba5c3901bf5e make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
sound/soc/codecs/ak4458.c:577:28: sparse: symbol 'ak4458_regmap' was not declared. Should it be sound/soc/codecs/ak4458.c:587:25: sparse: symbol 'ak4458_pm' was not declared. Should it be
Please review and possibly fold the followup patch.
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Fixes: 08660086eff9 ("ASoC: ak4458: Add support for AK4458 DAC driver") Signed-off-by: Fengguang Wu fengguang.wu@intel.com --- ak4458.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c index b579cda..c976216 100644 --- a/sound/soc/codecs/ak4458.c +++ b/sound/soc/codecs/ak4458.c @@ -574,7 +574,7 @@ struct snd_soc_codec_driver soc_codec_dev_ak4458 = { }, };
-const struct regmap_config ak4458_regmap = { +static const struct regmap_config ak4458_regmap = { .reg_bits = 8, .val_bits = 8,
@@ -584,7 +584,7 @@ const struct regmap_config ak4458_regmap = { .cache_type = REGCACHE_RBTREE, };
-const struct dev_pm_ops ak4458_pm = { +static const struct dev_pm_ops ak4458_pm = { SET_RUNTIME_PM_OPS(ak4458_runtime_suspend, ak4458_runtime_resume, NULL) SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume)
The patch
ASoC: ak4458: ak4458_regmap can be static
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 71ca54b6e87df90ecab3ce1968d60543750c7507 Mon Sep 17 00:00:00 2001
From: kbuild test robot fengguang.wu@intel.com Date: Fri, 16 Feb 2018 21:55:28 +0800 Subject: [PATCH] ASoC: ak4458: ak4458_regmap can be static
Fixes: 08660086eff9 ("ASoC: ak4458: Add support for AK4458 DAC driver") Signed-off-by: Fengguang Wu fengguang.wu@intel.com Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/ak4458.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c index b579cda8e418..c9762162b53f 100644 --- a/sound/soc/codecs/ak4458.c +++ b/sound/soc/codecs/ak4458.c @@ -574,7 +574,7 @@ struct snd_soc_codec_driver soc_codec_dev_ak4458 = { }, };
-const struct regmap_config ak4458_regmap = { +static const struct regmap_config ak4458_regmap = { .reg_bits = 8, .val_bits = 8,
@@ -584,7 +584,7 @@ const struct regmap_config ak4458_regmap = { .cache_type = REGCACHE_RBTREE, };
-const struct dev_pm_ops ak4458_pm = { +static const struct dev_pm_ops ak4458_pm = { SET_RUNTIME_PM_OPS(ak4458_runtime_suspend, ak4458_runtime_resume, NULL) SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume)
participants (2)
-
kbuild test robot -
Mark Brown