[alsa-devel] [PATCH] ASoC: imx: Allow using sound with DT descriptions only
This patch adds new Kconfig symbol to allow using generic sound cards/codecs based on DT description.
Signed-off-by: Alexander Shiyan shc_work@mail.ru --- sound/soc/fsl/Kconfig | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index bb4ab96..51fabc6 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -126,6 +126,16 @@ config SND_SOC_IMX_PCM_DMA config SND_SOC_IMX_AUDMUX tristate
+config SND_SOC_IMX_DT + tristate "SoC Audio support for i.MX DT boards" + depends on OF + select SND_SOC_FSL_SSI + select SND_SOC_IMX_AUDMUX + select SND_SOC_IMX_PCM_DMA + help + Say Y if you want to add support for SoC audio on an i.MX boards + described in devicetree. + config SND_MXC_SOC_WM1133_EV1 tristate "Audio on the i.MX31ADS with WM1133-EV1 fitted" depends on MACH_MX31ADS_WM1133_EV1
On Sun, Jan 05, 2014 at 10:35:26AM +0400, Alexander Shiyan wrote:
This patch adds new Kconfig symbol to allow using generic sound cards/codecs based on DT description.
Signed-off-by: Alexander Shiyan shc_work@mail.ru
sound/soc/fsl/Kconfig | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index bb4ab96..51fabc6 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -126,6 +126,16 @@ config SND_SOC_IMX_PCM_DMA config SND_SOC_IMX_AUDMUX tristate
+config SND_SOC_IMX_DT
- tristate "SoC Audio support for i.MX DT boards"
"i.MX ASoC generic sound card support" would be better?
- depends on OF
It seems to me that we should depend on SND_SIMPLE_CARD and add OF dependency for SND_SIMPLE_CARD symbol?
Shawn
- select SND_SOC_FSL_SSI
- select SND_SOC_IMX_AUDMUX
- select SND_SOC_IMX_PCM_DMA
- help
Say Y if you want to add support for SoC audio on an i.MX boardsdescribed in devicetree.config SND_MXC_SOC_WM1133_EV1 tristate "Audio on the i.MX31ADS with WM1133-EV1 fitted" depends on MACH_MX31ADS_WM1133_EV1 -- 1.8.3.2
Hello.
This patch adds new Kconfig symbol to allow using generic sound cards/codecs based on DT description.
Signed-off-by: Alexander Shiyan shc_work@mail.ru
sound/soc/fsl/Kconfig | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index bb4ab96..51fabc6 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -126,6 +126,16 @@ config SND_SOC_IMX_PCM_DMA config SND_SOC_IMX_AUDMUX tristate
+config SND_SOC_IMX_DT
- tristate "SoC Audio support for i.MX DT boards"
"i.MX ASoC generic sound card support" would be better?
- depends on OF
It seems to me that we should depend on SND_SIMPLE_CARD and add OF dependency for SND_SIMPLE_CARD symbol?
SND_SIMPLE_CARD can be used with pdata. For i.MX non-DT boards the imx-ssi driver is used, but for OF - fsl-ssi only, so I think OF dependency should be still here. Thanks.
---
On Sun, Jan 05, 2014 at 10:35:26AM +0400, Alexander Shiyan wrote:
+config SND_SOC_IMX_DT
- tristate "SoC Audio support for i.MX DT boards"
- depends on OF
- select SND_SOC_FSL_SSI
- select SND_SOC_IMX_AUDMUX
- select SND_SOC_IMX_PCM_DMA
- help
Say Y if you want to add support for SoC audio on an i.MX boardsdescribed in devicetree.
Rather than adding a separate Kconfig option it seems better to just move these to being selected by SND_IMX_SOC and delete all the extra selects from the individual machine drivers - I don't think it's worth worrying about building the extra driver for S/PDIF only systems and it's easier for users to work out what they need to set.
Hello.
+config SND_SOC_IMX_DT
- tristate "SoC Audio support for i.MX DT boards"
- depends on OF
- select SND_SOC_FSL_SSI
- select SND_SOC_IMX_AUDMUX
- select SND_SOC_IMX_PCM_DMA
- help
Say Y if you want to add support for SoC audio on an i.MX boardsdescribed in devicetree.Rather than adding a separate Kconfig option it seems better to just move these to being selected by SND_IMX_SOC and delete all the extra selects from the individual machine drivers - I don't think it's worth worrying about building the extra driver for S/PDIF only systems and it's easier for users to work out what they need to set.
OK, probably this will be better. Thanks.
---
participants (3)
-
Alexander Shiyan -
Mark Brown -
Shawn Guo