Re: [alsa-devel] [PATCH] Acer 7730G support update.
Yes it is 70 MB in archived state and 266.6 when decompressed. After decompressing i have such folders in linux-2.6.37-rc3:
drivers Documentation crypto block arch
I have used find tool to locate sound folder and I have found it only in documentation.
2010/11/22 Takashi Iwai tiwai@suse.de:
At Mon, 22 Nov 2010 17:46:31 +0300, Denis Kup wrote:
There is no such directory in archive.
You must be kidding. Double-check you downloaded the whole file. It's 70M big in the compressed form.
Takashi
2010/11/22 Takashi Iwai tiwai@suse.de:
At Mon, 22 Nov 2010 15:40:31 +0300, Denis Kup wrote:
I can't find patch_realtek.c in this archive. Where should it be situated?
It's in sound/pci/hda/patch_realtek.c.
Takashi
2010/11/22 Takashi Iwai tiwai@suse.de:
At Mon, 22 Nov 2010 15:24:16 +0300, Denis Kup wrote:
Do you mean that? http://www.kernel.org/pub/linux/kernel/v2.6/testing/linux-2.6.37-rc3.tar.bz2
Yes.
Takashi
2010/11/22 Takashi Iwai tiwai@suse.de: > At Mon, 22 Nov 2010 13:51:45 +0300, > Denis Kup wrote: >> >> 2010/11/22 Takashi Iwai tiwai@suse.de: >> > At Mon, 8 Nov 2010 00:01:45 +0300, >> > Denis Kup wrote: >> >> >> >> [1 <multipart/alternative (7bit)>] >> >> [1.1 <text/plain; ISO-8859-1 (7bit)>] >> >> Hello! >> >> >> >> I want to commit patch that fix no-sound on acer 7730G laptop. All work >> >> history you can see here >> >> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=5123 . >> >> This patch for the latest snapshot, where this changes have been made: >> >> http://www.kerneltrap.com/mailarchive/git-commits-head/2010/5/20/35023 . >> >> >> >> Acer 7730G support patch. >> >> >> >> Changes: >> >> 1) Fixes automatic EAPD configuration on Acer 7730G laptop. >> >> >> >> Denis Kuplyakov dener.kup@gmail.com >> >> 8.11.10 00:00:50 >> > >> > [Sorry for the late reply - the mail was stuck in my output queue >> > without triggering for weeks!] >> > >> > Thanks for the patch. >> > Unfortunately, your patch isn't applicable as is to the latest code. >> > The patch gives fuzz and errors. >> > >> > Could you rebase your patch to the latest 2.6.37-rc kernel code? >> > >> > Also, don't forget to give your sign-off. It's simply a line like >> > Signed-off-by: Foo Bar foo@bar.com >> > >> > >> > thanks, >> > >> > Takashi >> > >> >> Can you send me a link to the latest version, that should I patch. > > It's Linus tree, e.g. 2.6.37-rc3 should suffice. > > > Takashi >
At Mon, 22 Nov 2010 17:53:22 +0300, Denis Kup wrote:
Yes it is 70 MB in archived state and 266.6 when decompressed. After decompressing i have such folders in linux-2.6.37-rc3:
drivers Documentation crypto block arch
There must be more directories like include, lib, sound, etc. I checked the tarball here and it contains correctly.
Either your filesystem is filled up to full or the downloaded archive is broken, I guess.
Takashi
I have used find tool to locate sound folder and I have found it only in documentation.
2010/11/22 Takashi Iwai tiwai@suse.de:
At Mon, 22 Nov 2010 17:46:31 +0300, Denis Kup wrote:
There is no such directory in archive.
You must be kidding. Double-check you downloaded the whole file. It's 70M big in the compressed form.
Takashi
2010/11/22 Takashi Iwai tiwai@suse.de:
At Mon, 22 Nov 2010 15:40:31 +0300, Denis Kup wrote:
I can't find patch_realtek.c in this archive. Where should it be situated?
It's in sound/pci/hda/patch_realtek.c.
Takashi
2010/11/22 Takashi Iwai tiwai@suse.de:
At Mon, 22 Nov 2010 15:24:16 +0300, Denis Kup wrote: > > Do you mean that? > http://www.kernel.org/pub/linux/kernel/v2.6/testing/linux-2.6.37-rc3.tar.bz2
Yes.
Takashi
> 2010/11/22 Takashi Iwai tiwai@suse.de: > > At Mon, 22 Nov 2010 13:51:45 +0300, > > Denis Kup wrote: > >> > >> 2010/11/22 Takashi Iwai tiwai@suse.de: > >> > At Mon, 8 Nov 2010 00:01:45 +0300, > >> > Denis Kup wrote: > >> >> > >> >> [1 <multipart/alternative (7bit)>] > >> >> [1.1 <text/plain; ISO-8859-1 (7bit)>] > >> >> Hello! > >> >> > >> >> I want to commit patch that fix no-sound on acer 7730G laptop. All work > >> >> history you can see here > >> >> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=5123 . > >> >> This patch for the latest snapshot, where this changes have been made: > >> >> http://www.kerneltrap.com/mailarchive/git-commits-head/2010/5/20/35023 . > >> >> > >> >> Acer 7730G support patch. > >> >> > >> >> Changes: > >> >> 1) Fixes automatic EAPD configuration on Acer 7730G laptop. > >> >> > >> >> Denis Kuplyakov dener.kup@gmail.com > >> >> 8.11.10 00:00:50 > >> > > >> > [Sorry for the late reply - the mail was stuck in my output queue > >> > without triggering for weeks!] > >> > > >> > Thanks for the patch. > >> > Unfortunately, your patch isn't applicable as is to the latest code. > >> > The patch gives fuzz and errors. > >> > > >> > Could you rebase your patch to the latest 2.6.37-rc kernel code? > >> > > >> > Also, don't forget to give your sign-off. It's simply a line like > >> > Signed-off-by: Foo Bar foo@bar.com > >> > > >> > > >> > thanks, > >> > > >> > Takashi > >> > > >> > >> Can you send me a link to the latest version, that should I patch. > > > > It's Linus tree, e.g. 2.6.37-rc3 should suffice. > > > > > > Takashi > > >
I have downloaded file normally. I found that all tabs was converted to spaces in patch file. So I am sending new version.
2010/11/22 Takashi Iwai tiwai@suse.de:
At Mon, 22 Nov 2010 17:53:22 +0300, Denis Kup wrote:
Yes it is 70 MB in archived state and 266.6 when decompressed. After decompressing i have such folders in linux-2.6.37-rc3:
drivers Documentation crypto block arch
There must be more directories like include, lib, sound, etc. I checked the tarball here and it contains correctly.
Either your filesystem is filled up to full or the downloaded archive is broken, I guess.
Takashi
I have used find tool to locate sound folder and I have found it only in documentation.
2010/11/22 Takashi Iwai tiwai@suse.de:
At Mon, 22 Nov 2010 17:46:31 +0300, Denis Kup wrote:
There is no such directory in archive.
You must be kidding. Double-check you downloaded the whole file. It's 70M big in the compressed form.
Takashi
2010/11/22 Takashi Iwai tiwai@suse.de:
At Mon, 22 Nov 2010 15:40:31 +0300, Denis Kup wrote:
I can't find patch_realtek.c in this archive. Where should it be situated?
It's in sound/pci/hda/patch_realtek.c.
Takashi
2010/11/22 Takashi Iwai tiwai@suse.de: > At Mon, 22 Nov 2010 15:24:16 +0300, > Denis Kup wrote: >> >> Do you mean that? >> http://www.kernel.org/pub/linux/kernel/v2.6/testing/linux-2.6.37-rc3.tar.bz2 > > Yes. > > > Takashi > >> 2010/11/22 Takashi Iwai tiwai@suse.de: >> > At Mon, 22 Nov 2010 13:51:45 +0300, >> > Denis Kup wrote: >> >> >> >> 2010/11/22 Takashi Iwai tiwai@suse.de: >> >> > At Mon, 8 Nov 2010 00:01:45 +0300, >> >> > Denis Kup wrote: >> >> >> >> >> >> [1 <multipart/alternative (7bit)>] >> >> >> [1.1 <text/plain; ISO-8859-1 (7bit)>] >> >> >> Hello! >> >> >> >> >> >> I want to commit patch that fix no-sound on acer 7730G laptop. All work >> >> >> history you can see here >> >> >> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=5123 . >> >> >> This patch for the latest snapshot, where this changes have been made: >> >> >> http://www.kerneltrap.com/mailarchive/git-commits-head/2010/5/20/35023 . >> >> >> >> >> >> Acer 7730G support patch. >> >> >> >> >> >> Changes: >> >> >> 1) Fixes automatic EAPD configuration on Acer 7730G laptop. >> >> >> >> >> >> Denis Kuplyakov dener.kup@gmail.com >> >> >> 8.11.10 00:00:50 >> >> > >> >> > [Sorry for the late reply - the mail was stuck in my output queue >> >> > without triggering for weeks!] >> >> > >> >> > Thanks for the patch. >> >> > Unfortunately, your patch isn't applicable as is to the latest code. >> >> > The patch gives fuzz and errors. >> >> > >> >> > Could you rebase your patch to the latest 2.6.37-rc kernel code? >> >> > >> >> > Also, don't forget to give your sign-off. It's simply a line like >> >> > Signed-off-by: Foo Bar foo@bar.com >> >> > >> >> > >> >> > thanks, >> >> > >> >> > Takashi >> >> > >> >> >> >> Can you send me a link to the latest version, that should I patch. >> > >> > It's Linus tree, e.g. 2.6.37-rc3 should suffice. >> > >> > >> > Takashi >> > >> >
At Mon, 22 Nov 2010 19:09:32 +0300, Denis Kup wrote:
I have downloaded file normally. I found that all tabs was converted to spaces in patch file. So I am sending new version.
Thanks. Could you give a proper changelog and your sign-off? Otherwise it can't be applied to the upstream.
The change itself looks fine to me.
Takashi
That is it:
Acer 7730G support patch.
Changes: 1) Fixes automatic EAPD configuration on Acer 7730G laptop.
Signed-off-by: Denis Kuplyakov dener.kup@gmail.com 23.11.10 08:29
2010/11/23 Takashi Iwai tiwai@suse.de:
At Mon, 22 Nov 2010 19:09:32 +0300, Denis Kup wrote:
I have downloaded file normally. I found that all tabs was converted to spaces in patch file. So I am sending new version.
Thanks. Could you give a proper changelog and your sign-off? Otherwise it can't be applied to the upstream.
The change itself looks fine to me.
Takashi
At Tue, 23 Nov 2010 11:29:44 +0300, Denis Kup wrote:
[1 <text/plain; ISO-8859-1 (quoted-printable)>] That is it:
Acer 7730G support patch.
Changes:
- Fixes automatic EAPD configuration on Acer 7730G laptop.
Signed-off-by: Denis Kuplyakov dener.kup@gmail.com 23.11.10 08:29
Thanks, applied now to sound git tree.
Takashi
participants (2)
-
Denis Kup -
Takashi Iwai