[alsa-devel] [PATCH] ALSA: emu10k1: fix device names for Live!/Audigy1/2/4/E-mu and coding style
ALSA: emu10k1: fix device names for Live!/Audigy1/2/4/E-mu and coding style
Changelog: * added missing SBxxxx, CTxxxx, PCxxx and MAEMxxxx where they were missing, and fixed some of them which were wrong (according to kx.inf, which is pretty accurate compared to anything out there) * fixed device names to make them more consistent across various cards * fixed lots of coding style errors and some warnings, now it is down to: checkpatch.pl-0.24 --no-tree --file --strict --terse emu10k1_main.c total: 0 errors, 62 warnings, 7 checks, 2074 lines checked
Signed-off-by: Vedran Miletic rivanvx@gmail.com
At Sun, 19 Oct 2008 14:33:53 +0200, =?UTF-8?Q?Vedran_Mileti=C4=87?= wrote:
Changelog:
- added missing SBxxxx, CTxxxx, PCxxx and MAEMxxxx where they were missing,
and fixed some of them which were wrong (according to kx.inf, which is pretty accurate compared to anything out there)
- fixed device names to make them more consistent across various cards
- fixed lots of coding style errors and some warnings, now it is down to:
checkpatch.pl-0.24 --no-tree --file --strict --terse emu10k1_main.c total: 0 errors, 62 warnings, 7 checks, 2074 lines checked
Could you split your changes to separate patches? They shouldn't be mixed up in a single patch.
Also, make sure that your change itself passes the checkpatch.pl...
thanks,
Takashi
First part. Please checkin this if possible, and then I will send you the second part (coding style fixes).
ALSA: emu10k1: fix device names for Live!/Audigy1/2/4/E-mu
Changelog: * added missing SBxxxx, CTxxxx, PCxxx and MAEMxxxx where they were missing, and fixed some of them which were wrong (according to kx.inf, which is pretty accurate compared to anything out there) * fixed device names to make them more consistent across various cards * fixed order of devices where appropriate
Signed-off-by: Vedran Miletic rivanvx@gmail.com
2008/10/20 Takashi Iwai tiwai@suse.de:
At Sun, 19 Oct 2008 14:33:53 +0200, =?UTF-8?Q?Vedran_Mileti=C4=87?= wrote:
Changelog:
- added missing SBxxxx, CTxxxx, PCxxx and MAEMxxxx where they were missing,
and fixed some of them which were wrong (according to kx.inf, which is pretty accurate compared to anything out there)
- fixed device names to make them more consistent across various cards
- fixed lots of coding style errors and some warnings, now it is down to:
checkpatch.pl-0.24 --no-tree --file --strict --terse emu10k1_main.c total: 0 errors, 62 warnings, 7 checks, 2074 lines checked
Could you split your changes to separate patches? They shouldn't be mixed up in a single patch.
Also, make sure that your change itself passes the checkpatch.pl...
thanks,
Takashi
At Tue, 21 Oct 2008 11:00:11 +0200, =?UTF-8?Q?Vedran_Mileti=C4=87?= wrote:
First part. Please checkin this if possible, and then I will send you the second part (coding style fixes).
ALSA: emu10k1: fix device names for Live!/Audigy1/2/4/E-mu
Changelog:
- added missing SBxxxx, CTxxxx, PCxxx and MAEMxxxx where they were missing,
and fixed some of them which were wrong (according to kx.inf, which is pretty accurate compared to anything out there)
- fixed device names to make them more consistent across various cards
- fixed order of devices where appropriate
Signed-off-by: Vedran Miletic rivanvx@gmail.com
Thanks, applied now (with a slight coding-style fix).
Takashi
Here's a fix for my commit. Sorry again.
ALSA: emu10k1: fix faulty commit 18c7109289625106cdc810b20b628cd13b46d6dd
Commit 18c7109289625106cdc810b20b628cd13b46d6dd had #endif leftoff from compilation. This patch fixes it. Also, I replaced a misplaced comment by a useful one, that explains why are here #ifdef and #endif added in compilation.
Signed-off-by: Vedran Miletic rivanvx@gmail.com
2008/10/21 Takashi Iwai tiwai@suse.de:
At Tue, 21 Oct 2008 11:00:11 +0200, =?UTF-8?Q?Vedran_Mileti=C4=87?= wrote:
First part. Please checkin this if possible, and then I will send you the second part (coding style fixes).
ALSA: emu10k1: fix device names for Live!/Audigy1/2/4/E-mu
Changelog:
- added missing SBxxxx, CTxxxx, PCxxx and MAEMxxxx where they were missing,
and fixed some of them which were wrong (according to kx.inf, which is pretty accurate compared to anything out there)
- fixed device names to make them more consistent across various cards
- fixed order of devices where appropriate
Signed-off-by: Vedran Miletic rivanvx@gmail.com
Thanks, applied now (with a slight coding-style fix).
Takashi
At Tue, 21 Oct 2008 19:18:31 +0200, =?UTF-8?Q?Vedran_Mileti=C4=87?= wrote:
Here's a fix for my commit. Sorry again.
ALSA: emu10k1: fix faulty commit 18c7109289625106cdc810b20b628cd13b46d6dd
Commit 18c7109289625106cdc810b20b628cd13b46d6dd had #endif leftoff from compilation. This patch fixes it. Also, I replaced a misplaced comment by a useful one, that explains why are here #ifdef and #endif added in compilation.
Signed-off-by: Vedran Miletic rivanvx@gmail.com
Applied. I should have checked better, too...
Thanks,
Takashi
2008/10/21 Takashi Iwai tiwai@suse.de:
At Tue, 21 Oct 2008 11:00:11 +0200, =?UTF-8?Q?Vedran_Mileti=C4=87?= wrote:
First part. Please checkin this if possible, and then I will send you the second part (coding style fixes).
ALSA: emu10k1: fix device names for Live!/Audigy1/2/4/E-mu
Changelog:
- added missing SBxxxx, CTxxxx, PCxxx and MAEMxxxx where they were missing,
and fixed some of them which were wrong (according to kx.inf, which is pretty accurate compared to anything out there)
- fixed device names to make them more consistent across various cards
- fixed order of devices where appropriate
Signed-off-by: Vedran Miletic rivanvx@gmail.com
Thanks, applied now (with a slight coding-style fix).
Takashi
-- Vedran Miletić
Vedran,
With regard to the SB0228 comment, just make sure you're reading the product ID from the correct location. The silk-screened number on the PCB will always end in 0, but if you read the serial number label on the back of the card, you'll find the real product ID. Generally something along the lines of M1SB0228xxxxxxxxx Skip the first two characters, read the next 6. This works on Creative soundcards that are Live! or newer, before then their serial numbers looked different.
This may help you find more specific product IDs for other OEM Live! & Audigy boards.
Regards, Tony V.
OK, great. Will check that one, I have one "Dell OEM" SB Live! (it's not from Dell at all, that's why I quoted that part).
2008/10/22 Tony Vroon tony@vroon.org:
Vedran,
With regard to the SB0228 comment, just make sure you're reading the product ID from the correct location. The silk-screened number on the PCB will always end in 0, but if you read the serial number label on the back of the card, you'll find the real product ID. Generally something along the lines of M1SB0228xxxxxxxxx Skip the first two characters, read the next 6. This works on Creative soundcards that are Live! or newer, before then their serial numbers looked different.
This may help you find more specific product IDs for other OEM Live! & Audigy boards.
Regards, Tony V.
participants (3)
-
Takashi Iwai
-
Tony Vroon
-
Vedran Miletić