[alsa-devel] [PATCH 0/4] add NULL test
Add NULL tests on various calls to kzalloc and devm_kzalloc.
The semantic match that finds these problems is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression x,y; identifier fld; @@
( x = (vmalloc|kmalloc|kzalloc|kcalloc|kmem_cache_alloc|krealloc| kmemdup|kstrdup| devm_kzalloc|devm_kmalloc|devm_kcalloc|devm_kasprintf| kmalloc_array)(...,<+... __GFP_NOFAIL ...+>,...); | * x = (vmalloc|kmalloc|kzalloc|kcalloc|kmem_cache_alloc|krealloc| kmemdup|kstrdup| devm_kzalloc|devm_kmalloc|devm_kcalloc|devm_kasprintf| kmalloc_array)(...); ) ... when != (x) == NULL when != (x) != NULL when != (x) == 0 when != (x) != 0 when != x = y ( x->fld | *x | x[...] ) // </smpl>
---
drivers/s390/char/con3215.c | 2 ++ drivers/s390/char/raw3270.c | 2 ++ sound/soc/fsl/imx-pcm-dma.c | 2 ++ sound/soc/intel/baytrail/sst-baytrail-pcm.c | 2 ++ sound/soc/omap/omap-hdmi-audio.c | 2 ++ 5 files changed, 10 insertions(+)
Add NULL test on call to devm_kzalloc.
The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression x; @@
* x = devm_kzalloc(...); ... when != x == NULL *x // </smpl>
Signed-off-by: Julia Lawall Julia.Lawall@lip6.fr
--- sound/soc/fsl/imx-pcm-dma.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/fsl/imx-pcm-dma.c b/sound/soc/fsl/imx-pcm-dma.c index 1fc01ed..f3d3d1f 100644 --- a/sound/soc/fsl/imx-pcm-dma.c +++ b/sound/soc/fsl/imx-pcm-dma.c @@ -62,6 +62,8 @@ int imx_pcm_dma_init(struct platform_device *pdev, size_t size)
config = devm_kzalloc(&pdev->dev, sizeof(struct snd_dmaengine_pcm_config), GFP_KERNEL); + if (!config) + return -ENOMEM; *config = imx_dmaengine_pcm_config; if (size) config->prealloc_buffer_size = size;
On Sun, Dec 20, 2015 at 12:15:50PM +0100, Julia Lawall wrote:
Add NULL test on call to devm_kzalloc.
The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression x; @@
- x = devm_kzalloc(...); ... when != x == NULL *x
// </smpl>
Signed-off-by: Julia Lawall Julia.Lawall@lip6.fr
Acked-by: Nicolin Chen nicoleotsuka@gmail.com
Thank you
sound/soc/fsl/imx-pcm-dma.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/fsl/imx-pcm-dma.c b/sound/soc/fsl/imx-pcm-dma.c index 1fc01ed..f3d3d1f 100644 --- a/sound/soc/fsl/imx-pcm-dma.c +++ b/sound/soc/fsl/imx-pcm-dma.c @@ -62,6 +62,8 @@ int imx_pcm_dma_init(struct platform_device *pdev, size_t size)
config = devm_kzalloc(&pdev->dev, sizeof(struct snd_dmaengine_pcm_config), GFP_KERNEL);
- if (!config)
return -ENOMEM;
The patch
ASoC: imx-pcm-dma: add NULL test
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 10974ccf04b096fd79ad90fd50276b79c069f2cc Mon Sep 17 00:00:00 2001
From: Julia Lawall Julia.Lawall@lip6.fr Date: Sun, 20 Dec 2015 12:15:50 +0100 Subject: [PATCH] ASoC: imx-pcm-dma: add NULL test
Add NULL test on call to devm_kzalloc.
The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression x; @@
* x = devm_kzalloc(...); ... when != x == NULL *x // </smpl>
Signed-off-by: Julia Lawall Julia.Lawall@lip6.fr Acked-by: Nicolin Chen nicoleotsuka@gmail.com Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/fsl/imx-pcm-dma.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/fsl/imx-pcm-dma.c b/sound/soc/fsl/imx-pcm-dma.c index 1fc01ed3279d..f3d3d1ffa84e 100644 --- a/sound/soc/fsl/imx-pcm-dma.c +++ b/sound/soc/fsl/imx-pcm-dma.c @@ -62,6 +62,8 @@ int imx_pcm_dma_init(struct platform_device *pdev, size_t size)
config = devm_kzalloc(&pdev->dev, sizeof(struct snd_dmaengine_pcm_config), GFP_KERNEL); + if (!config) + return -ENOMEM; *config = imx_dmaengine_pcm_config; if (size) config->prealloc_buffer_size = size;
Add NULL test on call to devm_kzalloc.
The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression x; identifier fld; @@
* x = devm_kzalloc(...); ... when != x == NULL x->fld // </smpl>
Signed-off-by: Julia Lawall Julia.Lawall@lip6.fr
--- sound/soc/omap/omap-hdmi-audio.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/omap/omap-hdmi-audio.c b/sound/soc/omap/omap-hdmi-audio.c index 584b237..f83cc2b 100644 --- a/sound/soc/omap/omap-hdmi-audio.c +++ b/sound/soc/omap/omap-hdmi-audio.c @@ -368,6 +368,8 @@ static int omap_hdmi_audio_probe(struct platform_device *pdev) card->owner = THIS_MODULE; card->dai_link = devm_kzalloc(dev, sizeof(*(card->dai_link)), GFP_KERNEL); + if (!card->dai_link) + return -ENOMEM; card->dai_link->name = card->name; card->dai_link->stream_name = card->name; card->dai_link->cpu_dai_name = dev_name(ad->dssdev);
On 12/20/2015 01:15 PM, Julia Lawall wrote:
Add NULL test on call to devm_kzalloc.
The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression x; identifier fld; @@
- x = devm_kzalloc(...); ... when != x == NULL x->fld
// </smpl>
Signed-off-by: Julia Lawall Julia.Lawall@lip6.fr
Acked-by: Peter Ujfalusi peter.ujfalusi@ti.com
sound/soc/omap/omap-hdmi-audio.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/omap/omap-hdmi-audio.c b/sound/soc/omap/omap-hdmi-audio.c index 584b237..f83cc2b 100644 --- a/sound/soc/omap/omap-hdmi-audio.c +++ b/sound/soc/omap/omap-hdmi-audio.c @@ -368,6 +368,8 @@ static int omap_hdmi_audio_probe(struct platform_device *pdev) card->owner = THIS_MODULE; card->dai_link = devm_kzalloc(dev, sizeof(*(card->dai_link)), GFP_KERNEL);
- if (!card->dai_link)
return -ENOMEM;
The patch
ASoC: omap-hdmi-audio: add NULL test
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 18c94a043d6a466938f13761081a5cbee802dad1 Mon Sep 17 00:00:00 2001
From: Julia Lawall Julia.Lawall@lip6.fr Date: Sun, 20 Dec 2015 12:15:51 +0100 Subject: [PATCH] ASoC: omap-hdmi-audio: add NULL test
Add NULL test on call to devm_kzalloc.
The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression x; identifier fld; @@
* x = devm_kzalloc(...); ... when != x == NULL x->fld // </smpl>
Signed-off-by: Julia Lawall Julia.Lawall@lip6.fr Acked-by: Peter Ujfalusi peter.ujfalusi@ti.com Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/omap/omap-hdmi-audio.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/omap/omap-hdmi-audio.c b/sound/soc/omap/omap-hdmi-audio.c index 584b2372339e..f83cc2bc0fc4 100644 --- a/sound/soc/omap/omap-hdmi-audio.c +++ b/sound/soc/omap/omap-hdmi-audio.c @@ -368,6 +368,8 @@ static int omap_hdmi_audio_probe(struct platform_device *pdev) card->owner = THIS_MODULE; card->dai_link = devm_kzalloc(dev, sizeof(*(card->dai_link)), GFP_KERNEL); + if (!card->dai_link) + return -ENOMEM; card->dai_link->name = card->name; card->dai_link->stream_name = card->name; card->dai_link->cpu_dai_name = dev_name(ad->dssdev);
Add NULL test on call to devm_kzalloc.
The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression x; identifier fld; @@
* x = devm_kzalloc(...); ... when != x == NULL x->fld // </smpl>
Signed-off-by: Julia Lawall Julia.Lawall@lip6.fr
--- sound/soc/intel/baytrail/sst-baytrail-pcm.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/intel/baytrail/sst-baytrail-pcm.c b/sound/soc/intel/baytrail/sst-baytrail-pcm.c index 79547be..4765ad4 100644 --- a/sound/soc/intel/baytrail/sst-baytrail-pcm.c +++ b/sound/soc/intel/baytrail/sst-baytrail-pcm.c @@ -377,6 +377,8 @@ static int sst_byt_pcm_probe(struct snd_soc_platform *platform)
priv_data = devm_kzalloc(platform->dev, sizeof(*priv_data), GFP_KERNEL); + if (!priv_data) + return -ENOMEM; priv_data->byt = plat_data->dsp; snd_soc_platform_set_drvdata(platform, priv_data);
On Sun, Dec 20, 2015 at 12:15:53PM +0100, Julia Lawall wrote:
Add NULL test on call to devm_kzalloc.
The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
If there was a patch 3 in this series I seem to be missing it.
On Wed, 23 Dec 2015, Mark Brown wrote:
On Sun, Dec 20, 2015 at 12:15:53PM +0100, Julia Lawall wrote:
Add NULL test on call to devm_kzalloc.
The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
If there was a patch 3 in this series I seem to be missing it.
It's not for you (drivers/s390/char/con3215.c). Sorry for the confusion.
julia
The patch
ASoC: Intel: add NULL test
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 3f317c9faabc546a503bc62e806fa2e8e93e76be Mon Sep 17 00:00:00 2001
From: Julia Lawall Julia.Lawall@lip6.fr Date: Sun, 20 Dec 2015 12:15:53 +0100 Subject: [PATCH] ASoC: Intel: add NULL test
Add NULL test on call to devm_kzalloc.
The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression x; identifier fld; @@
* x = devm_kzalloc(...); ... when != x == NULL x->fld // </smpl>
Signed-off-by: Julia Lawall Julia.Lawall@lip6.fr Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/intel/baytrail/sst-baytrail-pcm.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/intel/baytrail/sst-baytrail-pcm.c b/sound/soc/intel/baytrail/sst-baytrail-pcm.c index 79547bec558b..4765ad474544 100644 --- a/sound/soc/intel/baytrail/sst-baytrail-pcm.c +++ b/sound/soc/intel/baytrail/sst-baytrail-pcm.c @@ -377,6 +377,8 @@ static int sst_byt_pcm_probe(struct snd_soc_platform *platform)
priv_data = devm_kzalloc(platform->dev, sizeof(*priv_data), GFP_KERNEL); + if (!priv_data) + return -ENOMEM; priv_data->byt = plat_data->dsp; snd_soc_platform_set_drvdata(platform, priv_data);
participants (4)
-
Julia Lawall -
Mark Brown -
Nicolin Chen -
Peter Ujfalusi