[alsa-devel] [PATCH 0/3] ASoC: Fix SND_SOC_ALL_CODECS imply fallout

newer
[alsa-devel] [PATCH] dt-bindings:...

older
[alsa-devel] [patch] tas571x: use...

Geert Uytterhoeven

12 Feb 2020 12 Feb '20

2:56 p.m.

Hi Mark,

As expected[*], commit ea00d95200d02ece ("ASoC: Use imply for SND_SOC_ALL_CODECS") introduced several build failures, due to missing dependencies.

This patch series fixes several of them. There are probably more.

Do we want to pursue this, or just revert instead? Thanks!

[*] https://lore.kernel.org/alsa-devel/20200207091351.18133-1-geert@linux-m68k.o...

Geert Uytterhoeven (3): ASoC: Fix SND_SOC_ALL_CODECS imply SPI fallout ASoC: Fix SND_SOC_ALL_CODECS imply I2C fallout ASoC: Fix SND_SOC_ALL_CODECS imply misc fallout

sound/soc/codecs/Kconfig | 88 +++++++++++++++++++++++++++++++++++++--- 1 file changed, 82 insertions(+), 6 deletions(-)

-- 2.17.1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

Show replies by date

Geert Uytterhoeven

12 Feb 12 Feb

2:56 p.m.

New subject: [alsa-devel] [PATCH 1/3] ASoC: Fix SND_SOC_ALL_CODECS imply SPI fallout

Fixes for CONFIG_SPI=n:

WARNING: unmet direct dependencies detected for REGMAP_SPI Depends on [n]: SPI [=n] Selected by [m]: - SND_SOC_ADAU1781_SPI [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] - SND_SOC_ADAU1977_SPI [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m]

ERROR: "spi_async" [...] undefined! ERROR: "spi_get_device_id" [...] undefined! ERROR: "__spi_register_driver" [...] undefined! ERROR: "spi_setup" [...] undefined! ERROR: "spi_sync" [...] undefined! ERROR: "spi_write_then_read" [...] undefined!

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 7a14b1c416b55e46..c2fb985de8c4e02a 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -327,12 +327,14 @@ config SND_SOC_AC97_CODEC

config SND_SOC_AD1836 tristate + depends on SPI_MASTER

config SND_SOC_AD193X tristate

config SND_SOC_AD193X_SPI tristate + depends on SPI_MASTER select SND_SOC_AD193X

config SND_SOC_AD193X_I2C @@ -390,6 +392,7 @@ config SND_SOC_ADAU1781_I2C

config SND_SOC_ADAU1781_SPI tristate + depends on SPI_MASTER select SND_SOC_ADAU1781 select REGMAP_SPI

@@ -398,6 +401,7 @@ config SND_SOC_ADAU1977

config SND_SOC_ADAU1977_SPI tristate + depends on SPI_MASTER select SND_SOC_ADAU1977 select REGMAP_SPI

@@ -441,6 +445,7 @@ config SND_SOC_ADAV80X

config SND_SOC_ADAV801 tristate + depends on SPI_MASTER select SND_SOC_ADAV80X

config SND_SOC_ADAV803 @@ -498,6 +503,7 @@ config SND_SOC_ALC5623

config SND_SOC_ALC5632 tristate + depends on I2C

config SND_SOC_BD28623 tristate "ROHM BD28623 CODEC" @@ -698,6 +704,7 @@ config SND_SOC_L3

config SND_SOC_DA7210 tristate + depends on I2C

config SND_SOC_DA7213 tristate "Dialog DA7213 CODEC" @@ -705,15 +712,19 @@ config SND_SOC_DA7213

config SND_SOC_DA7218 tristate + depends on I2C

config SND_SOC_DA7219 tristate + depends on I2C

config SND_SOC_DA732X tristate + depends on I2C

config SND_SOC_DA9055 tristate + depends on I2C

config SND_SOC_DMIC tristate "Generic Digital Microphone CODEC" @@ -773,9 +784,11 @@ config SND_SOC_INNO_RK3036

config SND_SOC_ISABELLE tristate + depends on I2C

config SND_SOC_LM49453 tristate + depends on I2C

config SND_SOC_LOCHNAGAR_SC tristate "Lochnagar Sound Card" @@ -802,17 +815,20 @@ config SND_SOC_MAX98088 depends on I2C

config SND_SOC_MAX98090 - tristate + tristate + depends on I2C

config SND_SOC_MAX98095 - tristate + tristate + depends on I2C

config SND_SOC_MAX98357A tristate "Maxim MAX98357A CODEC" depends on GPIOLIB

config SND_SOC_MAX98371 - tristate + tristate + depends on I2C

config SND_SOC_MAX98504 tristate "Maxim MAX98504 speaker amplifier" @@ -823,10 +839,12 @@ config SND_SOC_MAX9867 depends on I2C

config SND_SOC_MAX98925 - tristate + tristate + depends on I2C

config SND_SOC_MAX98926 tristate + depends on I2C

config SND_SOC_MAX98927 tristate "Maxim Integrated MAX98927 Speaker Amplifier" @@ -838,6 +856,7 @@ config SND_SOC_MAX98373

config SND_SOC_MAX9850 tristate + depends on I2C

config SND_SOC_MAX9860 tristate "Maxim MAX9860 Mono Audio Voice Codec" @@ -1016,26 +1035,32 @@ config SND_SOC_RT298

config SND_SOC_RT1011 tristate + depends on I2C

config SND_SOC_RT1015 tristate + depends on I2C

config SND_SOC_RT1305 tristate + depends on I2C

config SND_SOC_RT1308 tristate + depends on I2C

config SND_SOC_RT1308_SDW tristate "Realtek RT1308 Codec - SDW" - depends on SOUNDWIRE + depends on I2C && SOUNDWIRE select REGMAP_SOUNDWIRE

config SND_SOC_RT5514 tristate + depends on I2C

config SND_SOC_RT5514_SPI tristate + depends on SPI_MASTER

config SND_SOC_RT5514_SPI_BUILTIN bool # force RT5514_SPI to be built-in to avoid link errors @@ -1051,30 +1076,39 @@ config SND_SOC_RT5631

config SND_SOC_RT5640 tristate + depends on I2C

config SND_SOC_RT5645 tristate + depends on I2C

config SND_SOC_RT5651 tristate + depends on I2C

config SND_SOC_RT5659 tristate + depends on I2C

config SND_SOC_RT5660 tristate + depends on I2C

config SND_SOC_RT5663 tristate + depends on I2C

config SND_SOC_RT5665 tristate + depends on I2C

config SND_SOC_RT5668 tristate + depends on I2C

config SND_SOC_RT5670 tristate + depends on I2C

config SND_SOC_RT5677 tristate @@ -1087,6 +1121,7 @@ config SND_SOC_RT5677_SPI

config SND_SOC_RT5682 tristate + depends on I2C

config SND_SOC_RT700 tristate @@ -1154,6 +1189,7 @@ config SND_SOC_SSM2305

config SND_SOC_SSM2518 tristate + depends on I2C

config SND_SOC_SSM2602 tristate @@ -1185,6 +1221,7 @@ config SND_SOC_STA350

config SND_SOC_STA529 tristate + depends on I2C

config SND_SOC_STAC9766 tristate @@ -1282,6 +1319,7 @@ config SND_SOC_TLV320AIC3X

config SND_SOC_TLV320DAC33 tristate + depends on I2C

config SND_SOC_TS3A227E tristate "TI Headset/Mic detect and keypress chip" @@ -1348,18 +1386,23 @@ config SND_SOC_WL1273

config SND_SOC_WM0010 tristate + depends on SPI_MASTER

config SND_SOC_WM1250_EV1 tristate + depends on I2C

config SND_SOC_WM2000 tristate + depends on I2C

config SND_SOC_WM2200 tristate + depends on I2C

config SND_SOC_WM5100 tristate + depends on I2C

config SND_SOC_WM5102 tristate @@ -1462,9 +1505,11 @@ config SND_SOC_WM8904

config SND_SOC_WM8940 tristate + depends on I2C

config SND_SOC_WM8955 tristate + depends on I2C

config SND_SOC_WM8960 tristate "Wolfson Microelectronics WM8960 CODEC" @@ -1472,6 +1517,7 @@ config SND_SOC_WM8960

config SND_SOC_WM8961 tristate + depends on I2C

config SND_SOC_WM8962 tristate "Wolfson Microelectronics WM8962 CODEC" @@ -1479,6 +1525,7 @@ config SND_SOC_WM8962

config SND_SOC_WM8971 tristate + depends on I2C

config SND_SOC_WM8974 tristate "Wolfson Microelectronics WM8974 codec" @@ -1490,6 +1537,7 @@ config SND_SOC_WM8978

config SND_SOC_WM8983 tristate + depends on I2C

config SND_SOC_WM8985 tristate "Wolfson Microelectronics WM8985 and WM8758 codec driver" @@ -1500,12 +1548,15 @@ config SND_SOC_WM8988

config SND_SOC_WM8990 tristate + depends on I2C

config SND_SOC_WM8991 tristate + depends on I2C

config SND_SOC_WM8993 tristate + depends on I2C

config SND_SOC_WM8994 tristate @@ -1515,6 +1566,7 @@ config SND_SOC_WM8995

config SND_SOC_WM8996 tristate + depends on I2C

config SND_SOC_WM8997 tristate @@ -1528,6 +1580,7 @@ config SND_SOC_WM9081

config SND_SOC_WM9090 tristate + depends on I2C

config SND_SOC_WM9705 tristate @@ -1561,6 +1614,7 @@ config SND_SOC_ZX_AUD96P22 # Amp config SND_SOC_LM4857 tristate + depends on I2C

config SND_SOC_MAX9759 tristate "Maxim MAX9759 speaker Amplifier" @@ -1568,15 +1622,18 @@ config SND_SOC_MAX9759

config SND_SOC_MAX9768 tristate + depends on I2C

config SND_SOC_MAX9877 tristate + depends on I2C

config SND_SOC_MC13783 tristate

config SND_SOC_ML26124 tristate + depends on I2C

config SND_SOC_MT6351 tristate "MediaTek MT6351 Codec" @@ -1614,6 +1671,7 @@ config SND_SOC_NAU8824

config SND_SOC_NAU8825 tristate + depends on I2C

config SND_SOC_TPA6130A2 tristate "Texas Instruments TPA6130A2 headphone amplifier"

-- 2.17.1

Randy Dunlap

4:20 p.m.

New subject: [alsa-devel] [PATCH 1/3] ASoC: Fix SND_SOC_ALL_CODECS imply SPI fallout

On 2/12/20 6:56 AM, Geert Uytterhoeven wrote:

...

Fixes for CONFIG_SPI=n:

WARNING: unmet direct dependencies detected for REGMAP_SPI
  Depends on [n]: SPI [=n]
  Selected by [m]:
  - SND_SOC_ADAU1781_SPI [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m]
  - SND_SOC_ADAU1977_SPI [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m]

ERROR: "spi_async" [...] undefined!
ERROR: "spi_get_device_id" [...] undefined!
ERROR: "__spi_register_driver" [...] undefined!
ERROR: "spi_setup" [...] undefined!
ERROR: "spi_sync" [...] undefined!
ERROR: "spi_write_then_read" [...] undefined!

Reported-by: Randy Dunlap rdunlap@infradead.org Fixes: ea00d95200d02ece ("ASoC: Use imply for SND_SOC_ALL_CODECS") Signed-off-by: Geert Uytterhoeven geert@linux-m68k.org

Acked-by: Randy Dunlap rdunlap@infradead.org # build-tested

thanks.

-- ~Randy

Mark Brown

11:57 p.m.

New subject: [alsa-devel] Applied "ASoC: Fix SND_SOC_ALL_CODECS imply SPI fallout" to the asoc tree

The patch

ASoC: Fix SND_SOC_ALL_CODECS imply SPI fallout

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.7

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks, Mark

...

From ce0c97f8a2936d05951da7093b881c8eaaee72e0 Mon Sep 17 00:00:00 2001

From: Geert Uytterhoeven geert@linux-m68k.org Date: Wed, 12 Feb 2020 15:56:48 +0100 Subject: [PATCH] ASoC: Fix SND_SOC_ALL_CODECS imply SPI fallout

Fixes for CONFIG_SPI=n:

Reported-by: Randy Dunlap rdunlap@infradead.org Fixes: ea00d95200d02ece ("ASoC: Use imply for SND_SOC_ALL_CODECS") Signed-off-by: Geert Uytterhoeven geert@linux-m68k.org Acked-by: Randy Dunlap rdunlap@infradead.org # build-tested Link: https://lore.kernel.org/r/20200212145650.4602-2-geert@linux-m68k.org Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/Kconfig | 68 +++++++++++++++++++++++++++++++++++++--- 1 file changed, 63 insertions(+), 5 deletions(-)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 7a14b1c416b5..c2fb985de8c4 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -327,12 +327,14 @@ config SND_SOC_AC97_CODEC

config SND_SOC_AD1836 tristate + depends on SPI_MASTER

config SND_SOC_AD193X tristate

config SND_SOC_AD193X_SPI tristate + depends on SPI_MASTER select SND_SOC_AD193X

config SND_SOC_AD193X_I2C @@ -390,6 +392,7 @@ config SND_SOC_ADAU1781_I2C

config SND_SOC_ADAU1781_SPI tristate + depends on SPI_MASTER select SND_SOC_ADAU1781 select REGMAP_SPI

@@ -398,6 +401,7 @@ config SND_SOC_ADAU1977

config SND_SOC_ADAU1977_SPI tristate + depends on SPI_MASTER select SND_SOC_ADAU1977 select REGMAP_SPI

@@ -441,6 +445,7 @@ config SND_SOC_ADAV80X

config SND_SOC_ADAV801 tristate + depends on SPI_MASTER select SND_SOC_ADAV80X

config SND_SOC_ADAV803 @@ -498,6 +503,7 @@ config SND_SOC_ALC5623

config SND_SOC_ALC5632 tristate + depends on I2C

config SND_SOC_BD28623 tristate "ROHM BD28623 CODEC" @@ -698,6 +704,7 @@ config SND_SOC_L3

config SND_SOC_DA7210 tristate + depends on I2C

config SND_SOC_DA7213 tristate "Dialog DA7213 CODEC" @@ -705,15 +712,19 @@ config SND_SOC_DA7213

config SND_SOC_DA7218 tristate + depends on I2C

config SND_SOC_DA7219 tristate + depends on I2C

config SND_SOC_DA732X tristate + depends on I2C

config SND_SOC_DA9055 tristate + depends on I2C

config SND_SOC_DMIC tristate "Generic Digital Microphone CODEC" @@ -773,9 +784,11 @@ config SND_SOC_INNO_RK3036

config SND_SOC_ISABELLE tristate + depends on I2C

config SND_SOC_LM49453 tristate + depends on I2C

config SND_SOC_LOCHNAGAR_SC tristate "Lochnagar Sound Card" @@ -802,17 +815,20 @@ config SND_SOC_MAX98088 depends on I2C

config SND_SOC_MAX98090 - tristate + tristate + depends on I2C

config SND_SOC_MAX98095 - tristate + tristate + depends on I2C

config SND_SOC_MAX98357A tristate "Maxim MAX98357A CODEC" depends on GPIOLIB

config SND_SOC_MAX98371 - tristate + tristate + depends on I2C

config SND_SOC_MAX98504 tristate "Maxim MAX98504 speaker amplifier" @@ -823,10 +839,12 @@ config SND_SOC_MAX9867 depends on I2C

config SND_SOC_MAX98925 - tristate + tristate + depends on I2C

config SND_SOC_MAX98926 tristate + depends on I2C

config SND_SOC_MAX98927 tristate "Maxim Integrated MAX98927 Speaker Amplifier" @@ -838,6 +856,7 @@ config SND_SOC_MAX98373

config SND_SOC_MAX9850 tristate + depends on I2C

config SND_SOC_MAX9860 tristate "Maxim MAX9860 Mono Audio Voice Codec" @@ -1016,26 +1035,32 @@ config SND_SOC_RT298

config SND_SOC_RT1011 tristate + depends on I2C

config SND_SOC_RT1015 tristate + depends on I2C

config SND_SOC_RT1305 tristate + depends on I2C

config SND_SOC_RT1308 tristate + depends on I2C

config SND_SOC_RT1308_SDW tristate "Realtek RT1308 Codec - SDW" - depends on SOUNDWIRE + depends on I2C && SOUNDWIRE select REGMAP_SOUNDWIRE

config SND_SOC_RT5514 tristate + depends on I2C

config SND_SOC_RT5514_SPI tristate + depends on SPI_MASTER

config SND_SOC_RT5514_SPI_BUILTIN bool # force RT5514_SPI to be built-in to avoid link errors @@ -1051,30 +1076,39 @@ config SND_SOC_RT5631

config SND_SOC_RT5640 tristate + depends on I2C

config SND_SOC_RT5645 tristate + depends on I2C

config SND_SOC_RT5651 tristate + depends on I2C

config SND_SOC_RT5659 tristate + depends on I2C

config SND_SOC_RT5660 tristate + depends on I2C

config SND_SOC_RT5663 tristate + depends on I2C

config SND_SOC_RT5665 tristate + depends on I2C

config SND_SOC_RT5668 tristate + depends on I2C

config SND_SOC_RT5670 tristate + depends on I2C

config SND_SOC_RT5677 tristate @@ -1087,6 +1121,7 @@ config SND_SOC_RT5677_SPI

config SND_SOC_RT5682 tristate + depends on I2C

config SND_SOC_RT700 tristate @@ -1154,6 +1189,7 @@ config SND_SOC_SSM2305

config SND_SOC_SSM2518 tristate + depends on I2C

config SND_SOC_SSM2602 tristate @@ -1185,6 +1221,7 @@ config SND_SOC_STA350

config SND_SOC_STA529 tristate + depends on I2C

config SND_SOC_STAC9766 tristate @@ -1282,6 +1319,7 @@ config SND_SOC_TLV320AIC3X

config SND_SOC_TLV320DAC33 tristate + depends on I2C

config SND_SOC_TS3A227E tristate "TI Headset/Mic detect and keypress chip" @@ -1348,18 +1386,23 @@ config SND_SOC_WL1273

config SND_SOC_WM0010 tristate + depends on SPI_MASTER

config SND_SOC_WM1250_EV1 tristate + depends on I2C

config SND_SOC_WM2000 tristate + depends on I2C

config SND_SOC_WM2200 tristate + depends on I2C

config SND_SOC_WM5100 tristate + depends on I2C

config SND_SOC_WM5102 tristate @@ -1462,9 +1505,11 @@ config SND_SOC_WM8904

config SND_SOC_WM8940 tristate + depends on I2C

config SND_SOC_WM8955 tristate + depends on I2C

config SND_SOC_WM8960 tristate "Wolfson Microelectronics WM8960 CODEC" @@ -1472,6 +1517,7 @@ config SND_SOC_WM8960

config SND_SOC_WM8961 tristate + depends on I2C

config SND_SOC_WM8962 tristate "Wolfson Microelectronics WM8962 CODEC" @@ -1479,6 +1525,7 @@ config SND_SOC_WM8962

config SND_SOC_WM8971 tristate + depends on I2C

config SND_SOC_WM8974 tristate "Wolfson Microelectronics WM8974 codec" @@ -1490,6 +1537,7 @@ config SND_SOC_WM8978

config SND_SOC_WM8983 tristate + depends on I2C

config SND_SOC_WM8985 tristate "Wolfson Microelectronics WM8985 and WM8758 codec driver" @@ -1500,12 +1548,15 @@ config SND_SOC_WM8988

config SND_SOC_WM8990 tristate + depends on I2C

config SND_SOC_WM8991 tristate + depends on I2C

config SND_SOC_WM8993 tristate + depends on I2C

config SND_SOC_WM8994 tristate @@ -1515,6 +1566,7 @@ config SND_SOC_WM8995

config SND_SOC_WM8996 tristate + depends on I2C

config SND_SOC_WM8997 tristate @@ -1528,6 +1580,7 @@ config SND_SOC_WM9081

config SND_SOC_WM9090 tristate + depends on I2C

config SND_SOC_WM9705 tristate @@ -1561,6 +1614,7 @@ config SND_SOC_ZX_AUD96P22 # Amp config SND_SOC_LM4857 tristate + depends on I2C

config SND_SOC_MAX9759 tristate "Maxim MAX9759 speaker Amplifier" @@ -1568,15 +1622,18 @@ config SND_SOC_MAX9759

config SND_SOC_MAX9768 tristate + depends on I2C

config SND_SOC_MAX9877 tristate + depends on I2C

config SND_SOC_MC13783 tristate

config SND_SOC_ML26124 tristate + depends on I2C

config SND_SOC_MT6351 tristate "MediaTek MT6351 Codec" @@ -1614,6 +1671,7 @@ config SND_SOC_NAU8824

config SND_SOC_NAU8825 tristate + depends on I2C

config SND_SOC_TPA6130A2 tristate "Texas Instruments TPA6130A2 headphone amplifier"

-- 2.20.1

Geert Uytterhoeven

2:56 p.m.

New subject: [alsa-devel] [PATCH 2/3] ASoC: Fix SND_SOC_ALL_CODECS imply I2C fallout

Fixes for CONFIG_I2C=n:

WARNING: unmet direct dependencies detected for REGMAP_I2C Depends on [n]: I2C [=n] Selected by [m]: - SND_SOC_ADAU1781_I2C [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] - SND_SOC_ADAU1977_I2C [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] - SND_SOC_RT5677 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m]

sound/soc/codecs/...: error: type defaults to ‘int’ in declaration of ‘module_i2c_driver’ [-Werror=implicit-int]

drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_byte_reg_read’: drivers/base/regmap/regmap-i2c.c:25:8: error: implicit declaration of function ‘i2c_smbus_read_byte_data’; did you mean ‘i2c_set_adapdata’? [-Werror=implicit-function-declaration]

Fixes: ea00d95200d02ece ("ASoC: Use imply for SND_SOC_ALL_CODECS") Signed-off-by: Geert Uytterhoeven geert@linux-m68k.org --- sound/soc/codecs/Kconfig | 9 +++++++++ 1 file changed, 9 insertions(+)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index c2fb985de8c4e02a..3ef804d07deea41d 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -339,6 +339,7 @@ config SND_SOC_AD193X_SPI

config SND_SOC_AD193X_I2C tristate + depends on I2C select SND_SOC_AD193X

config SND_SOC_AD1980 @@ -353,6 +354,7 @@ config SND_SOC_ADAU_UTILS

config SND_SOC_ADAU1373 tristate + depends on I2C select SND_SOC_ADAU_UTILS

config SND_SOC_ADAU1701 @@ -387,6 +389,7 @@ config SND_SOC_ADAU1781

config SND_SOC_ADAU1781_I2C tristate + depends on I2C select SND_SOC_ADAU1781 select REGMAP_I2C

@@ -407,6 +410,7 @@ config SND_SOC_ADAU1977_SPI

config SND_SOC_ADAU1977_I2C tristate + depends on I2C select SND_SOC_ADAU1977 select REGMAP_I2C

@@ -450,6 +454,7 @@ config SND_SOC_ADAV801

config SND_SOC_ADAV803 tristate + depends on I2C select SND_SOC_ADAV80X

config SND_SOC_ADS117X @@ -471,6 +476,7 @@ config SND_SOC_AK4458

config SND_SOC_AK4535 tristate + depends on I2C

config SND_SOC_AK4554 tristate "AKM AK4554 CODEC" @@ -481,6 +487,7 @@ config SND_SOC_AK4613

config SND_SOC_AK4641 tristate + depends on I2C

config SND_SOC_AK4642 tristate "AKM AK4642 CODEC" @@ -488,6 +495,7 @@ config SND_SOC_AK4642

config SND_SOC_AK4671 tristate + depends on I2C

config SND_SOC_AK5386 tristate "AKM AK5638 CODEC" @@ -1112,6 +1120,7 @@ config SND_SOC_RT5670

config SND_SOC_RT5677 tristate + depends on I2C select REGMAP_I2C select REGMAP_IRQ

-- 2.17.1

Mark Brown

11:57 p.m.

New subject: [alsa-devel] Applied "ASoC: Fix SND_SOC_ALL_CODECS imply I2C fallout" to the asoc tree

The patch

ASoC: Fix SND_SOC_ALL_CODECS imply I2C fallout

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.7

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks, Mark

...

From 1d0158f547e0dbefa9e18930e93f270ab0309707 Mon Sep 17 00:00:00 2001

From: Geert Uytterhoeven geert@linux-m68k.org Date: Wed, 12 Feb 2020 15:56:49 +0100 Subject: [PATCH] ASoC: Fix SND_SOC_ALL_CODECS imply I2C fallout MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit

Fixes for CONFIG_I2C=n:

sound/soc/codecs/...: error: type defaults to ‘int’ in declaration of ‘module_i2c_driver’ [-Werror=implicit-int]

Fixes: ea00d95200d02ece ("ASoC: Use imply for SND_SOC_ALL_CODECS") Signed-off-by: Geert Uytterhoeven geert@linux-m68k.org Link: https://lore.kernel.org/r/20200212145650.4602-3-geert@linux-m68k.org Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/Kconfig | 9 +++++++++ 1 file changed, 9 insertions(+)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index c2fb985de8c4..3ef804d07dee 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -339,6 +339,7 @@ config SND_SOC_AD193X_SPI

config SND_SOC_AD193X_I2C tristate + depends on I2C select SND_SOC_AD193X

config SND_SOC_AD1980 @@ -353,6 +354,7 @@ config SND_SOC_ADAU_UTILS

config SND_SOC_ADAU1373 tristate + depends on I2C select SND_SOC_ADAU_UTILS

config SND_SOC_ADAU1701 @@ -387,6 +389,7 @@ config SND_SOC_ADAU1781

config SND_SOC_ADAU1781_I2C tristate + depends on I2C select SND_SOC_ADAU1781 select REGMAP_I2C

@@ -407,6 +410,7 @@ config SND_SOC_ADAU1977_SPI

config SND_SOC_ADAU1977_I2C tristate + depends on I2C select SND_SOC_ADAU1977 select REGMAP_I2C

@@ -450,6 +454,7 @@ config SND_SOC_ADAV801

config SND_SOC_ADAV803 tristate + depends on I2C select SND_SOC_ADAV80X

config SND_SOC_ADS117X @@ -471,6 +476,7 @@ config SND_SOC_AK4458

config SND_SOC_AK4535 tristate + depends on I2C

config SND_SOC_AK4554 tristate "AKM AK4554 CODEC" @@ -481,6 +487,7 @@ config SND_SOC_AK4613

config SND_SOC_AK4641 tristate + depends on I2C

config SND_SOC_AK4642 tristate "AKM AK4642 CODEC" @@ -488,6 +495,7 @@ config SND_SOC_AK4642

config SND_SOC_AK4671 tristate + depends on I2C

config SND_SOC_AK5386 tristate "AKM AK5638 CODEC" @@ -1112,6 +1120,7 @@ config SND_SOC_RT5670

config SND_SOC_RT5677 tristate + depends on I2C select REGMAP_I2C select REGMAP_IRQ

-- 2.20.1

Geert Uytterhoeven

2:56 p.m.

New subject: [alsa-devel] [PATCH 3/3] ASoC: Fix SND_SOC_ALL_CODECS imply misc fallout

Fixes for missing miscellaneous support:

ERROR: "abx500_get_register_interruptible" [...] undefined! ERROR: "abx500_set_register_interruptible" [...] undefined! ERROR: "arizona_free_irq" [...] undefined! ERROR: "arizona_request_irq" [...] undefined! ERROR: "arizona_set_irq_wake" [...] undefined! ERROR: "mc13xxx_reg_rmw" [...] undefined! ERROR: "mc13xxx_reg_write" [...] undefined! ERROR: "snd_soc_free_ac97_component" [...] undefined! ERROR: "snd_soc_new_ac97_component" [...] undefined!

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 3ef804d07deea41d..d957fd6980b10a92 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -319,6 +319,7 @@ config SND_SOC_WM_ADSP

config SND_SOC_AB8500_CODEC tristate + depends on ABX500_CORE

config SND_SOC_AC97_CODEC tristate "Build generic ASoC AC97 CODEC driver" @@ -343,8 +344,9 @@ config SND_SOC_AD193X_I2C select SND_SOC_AD193X

config SND_SOC_AD1980 - select REGMAP_AC97 tristate + depends on SND_SOC_AC97_BUS + select REGMAP_AC97

config SND_SOC_AD73311 tristate @@ -646,6 +648,7 @@ config SND_SOC_CS47L15

config SND_SOC_CS47L24 tristate + depends on MFD_CS47L24

config SND_SOC_CS47L35 tristate @@ -1234,6 +1237,7 @@ config SND_SOC_STA529

config SND_SOC_STAC9766 tristate + depends on SND_SOC_AC97_BUS

config SND_SOC_STI_SAS tristate "codec Audio support for STI SAS codec" @@ -1415,9 +1419,11 @@ config SND_SOC_WM5100

config SND_SOC_WM5102 tristate + depends on MFD_WM5102

config SND_SOC_WM5110 tristate + depends on MFD_WM5110

config SND_SOC_WM8350 tristate @@ -1579,9 +1585,11 @@ config SND_SOC_WM8996

config SND_SOC_WM8997 tristate + depends on MFD_WM8997

config SND_SOC_WM8998 tristate + depends on MFD_WM8998

config SND_SOC_WM9081 tristate @@ -1639,6 +1647,7 @@ config SND_SOC_MAX9877

config SND_SOC_MC13783 tristate + depends on MFD_MC13XXX

config SND_SOC_ML26124 tristate

-- 2.17.1

Mark Brown

11:57 p.m.

New subject: [alsa-devel] Applied "ASoC: Fix SND_SOC_ALL_CODECS imply misc fallout" to the asoc tree

The patch

ASoC: Fix SND_SOC_ALL_CODECS imply misc fallout

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.7

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks, Mark

...

From d8dd3f92a6ba11f9046df48765e6f12ad70a3946 Mon Sep 17 00:00:00 2001

From: Geert Uytterhoeven geert@linux-m68k.org Date: Wed, 12 Feb 2020 15:56:50 +0100 Subject: [PATCH] ASoC: Fix SND_SOC_ALL_CODECS imply misc fallout

Fixes for missing miscellaneous support:

Reported-by: Randy Dunlap rdunlap@infradead.org Fixes: ea00d95200d02ece ("ASoC: Use imply for SND_SOC_ALL_CODECS") Signed-off-by: Geert Uytterhoeven geert@linux-m68k.org Link: https://lore.kernel.org/r/20200212145650.4602-4-geert@linux-m68k.org Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/Kconfig | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 3ef804d07dee..d957fd6980b1 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -319,6 +319,7 @@ config SND_SOC_WM_ADSP

config SND_SOC_AB8500_CODEC tristate + depends on ABX500_CORE

config SND_SOC_AC97_CODEC tristate "Build generic ASoC AC97 CODEC driver" @@ -343,8 +344,9 @@ config SND_SOC_AD193X_I2C select SND_SOC_AD193X

config SND_SOC_AD1980 - select REGMAP_AC97 tristate + depends on SND_SOC_AC97_BUS + select REGMAP_AC97

config SND_SOC_AD73311 tristate @@ -646,6 +648,7 @@ config SND_SOC_CS47L15

config SND_SOC_CS47L24 tristate + depends on MFD_CS47L24

config SND_SOC_CS47L35 tristate @@ -1234,6 +1237,7 @@ config SND_SOC_STA529

config SND_SOC_STAC9766 tristate + depends on SND_SOC_AC97_BUS

config SND_SOC_STI_SAS tristate "codec Audio support for STI SAS codec" @@ -1415,9 +1419,11 @@ config SND_SOC_WM5100

config SND_SOC_WM5102 tristate + depends on MFD_WM5102

config SND_SOC_WM5110 tristate + depends on MFD_WM5110

config SND_SOC_WM8350 tristate @@ -1579,9 +1585,11 @@ config SND_SOC_WM8996

config SND_SOC_WM8997 tristate + depends on MFD_WM8997

config SND_SOC_WM8998 tristate + depends on MFD_WM8998

config SND_SOC_WM9081 tristate @@ -1639,6 +1647,7 @@ config SND_SOC_MAX9877

config SND_SOC_MC13783 tristate + depends on MFD_MC13XXX

config SND_SOC_ML26124 tristate

-- 2.20.1

1738

Age (days ago)

1738

Last active (days ago)

List overview

Download

7 comments

3 participants

tags (0)

participants (3)

Geert Uytterhoeven
Mark Brown
Randy Dunlap