ASoC: amd: yc: Fix non-functional mic on ASUS E1504FA
Like other ASUS models the Asus Vivobook E1504FA requires an entry in the quirk list to enable the internal microphone.
Showing with 7 additions and 0 deletions. 7 changes: 7 additions & 0 deletions 7 sound/soc/amd/yc/acp6x-mach.c @@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "M6500RC"), } }, { .driver_data = &acp6x_card, .matches = { DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."), DMI_MATCH(DMI_PRODUCT_NAME, "E1504FA"), } }, {
I have this laptop and I have tested this patch successfully.
Malcolm
On Mon, Nov 27, 2023 at 12:24:59PM +0000, Malcolm Hart wrote:
Like other ASUS models the Asus Vivobook E1504FA requires an entry in the quirk list to enable the internal microphone.
Showing with 7 additions and 0 deletions. 7 changes: 7 additions & 0 deletions 7 sound/soc/amd/yc/acp6x-mach.c @@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
The patch appears to have been unusably corrupted by your e-mail software and is also missing a Signed-off-by. See email-cleints.rst for some suggestions on configuring things, or it might be worth looking into b4 and it's web submission endpoint:
From da1e023a39987c1bc2d5b27ecf659d61d9a4724c Mon Sep 17 00:00:00 2001 From: foolishhart 62256078+foolishhart@users.noreply.github.com Date: Mon, 27 Nov 2023 11:51:04 +0000 Subject: [PATCH] Update acp6x-mach.c
Added ASUSTeK COMPUTER INC "E1504FA" to quirks file to enable microphone array on ASUS Vivobook GO 15. --- sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 15a864dcd7bd3a..3babb17a56bb55 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "M6500RC"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "E1504FA"), + } + }, { .driver_data = &acp6x_card, .matches = {
Mark Brown broonie@kernel.org writes:
[[PGP Signed Part:Undecided]] On Mon, Nov 27, 2023 at 12:24:59PM +0000, Malcolm Hart wrote:
Like other ASUS models the Asus Vivobook E1504FA requires an entry in the quirk list to enable the internal microphone.
Showing with 7 additions and 0 deletions. 7 changes: 7 additions & 0 deletions 7 sound/soc/amd/yc/acp6x-mach.c @@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
The patch appears to have been unusably corrupted by your e-mail software and is also missing a Signed-off-by. See email-cleints.rst for some suggestions on configuring things, or it might be worth looking into b4 and it's web submission endpoint:
https://b4.docs.kernel.org/en/latest/
[[End of PGP Signed Part]]
On 11/27/2023 09:23, Malcolm Hart wrote:
From da1e023a39987c1bc2d5b27ecf659d61d9a4724c Mon Sep 17 00:00:00 2001 From: foolishhart 62256078+foolishhart@users.noreply.github.com Date: Mon, 27 Nov 2023 11:51:04 +0000 Subject: [PATCH] Update acp6x-mach.c
Added ASUSTeK COMPUTER INC "E1504FA" to quirks file to enable microphone array on ASUS Vivobook GO 15.
You're missing a Signed-off-by: tag. Also as this should be going to stable you should have a tag for:
Cc: stable@vger.kernel.org
sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 15a864dcd7bd3a..3babb17a56bb55 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "M6500RC"), } },
- {
.driver_data = &acp6x_card,.matches = {DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),DMI_MATCH(DMI_PRODUCT_NAME, "E1504FA"),}- }, { .driver_data = &acp6x_card, .matches = {
Mark Brown broonie@kernel.org writes:
[[PGP Signed Part:Undecided]] On Mon, Nov 27, 2023 at 12:24:59PM +0000, Malcolm Hart wrote:
Like other ASUS models the Asus Vivobook E1504FA requires an entry in the quirk list to enable the internal microphone.
Showing with 7 additions and 0 deletions. 7 changes: 7 additions & 0 deletions 7 sound/soc/amd/yc/acp6x-mach.c @@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
The patch appears to have been unusably corrupted by your e-mail software and is also missing a Signed-off-by. See email-cleints.rst for some suggestions on configuring things, or it might be worth looking into b4 and it's web submission endpoint:
https://b4.docs.kernel.org/en/latest/[[End of PGP Signed Part]]
From da1e023a39987c1bc2d5b27ecf659d61d9a4724c Mon Sep 17 00:00:00 2001 From: foolishhart 62256078+foolishhart@users.noreply.github.com Date: Mon, 27 Nov 2023 11:51:04 +0000 Subject: [PATCH] Update acp6x-mach.c
Added ASUSTeK COMPUTER INC "E1504FA" to quirks file to enable microphone array on ASUS Vivobook GO 15. --- sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 15a864dcd7bd3a..3babb17a56bb55 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "M6500RC"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "E1504FA"), + } + }, { .driver_data = &acp6x_card, .matches = {
Signed-off-by: Malcolm Hart malcolm@5harts.com
Mario Limonciello mario.limonciello@amd.com writes:
On 11/27/2023 09:23, Malcolm Hart wrote:
From da1e023a39987c1bc2d5b27ecf659d61d9a4724c Mon Sep 17 00:00:00 2001 From: foolishhart 62256078+foolishhart@users.noreply.github.com Date: Mon, 27 Nov 2023 11:51:04 +0000 Subject: [PATCH] Update acp6x-mach.c Added ASUSTeK COMPUTER INC "E1504FA" to quirks file to enable microphone array on ASUS Vivobook GO 15.
You're missing a Signed-off-by: tag. Also as this should be going to stable you should have a tag for:
Cc: stable@vger.kernel.org
sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 15a864dcd7bd3a..3babb17a56bb55 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "M6500RC"), } },
- {
.driver_data = &acp6x_card,.matches = {DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),DMI_MATCH(DMI_PRODUCT_NAME, "E1504FA"),}- }, { .driver_data = &acp6x_card, .matches = {
Mark Brown broonie@kernel.org writes:
[[PGP Signed Part:Undecided]] On Mon, Nov 27, 2023 at 12:24:59PM +0000, Malcolm Hart wrote:
Like other ASUS models the Asus Vivobook E1504FA requires an entry in the quirk list to enable the internal microphone.
Showing with 7 additions and 0 deletions. 7 changes: 7 additions & 0 deletions 7 sound/soc/amd/yc/acp6x-mach.c @@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
The patch appears to have been unusably corrupted by your e-mail software and is also missing a Signed-off-by. See email-cleints.rst for some suggestions on configuring things, or it might be worth looking into b4 and it's web submission endpoint:
https://b4.docs.kernel.org/en/latest/[[End of PGP Signed Part]]
On Mon, Nov 27, 2023 at 03:44:37PM +0000, Malcolm Hart wrote:
From da1e023a39987c1bc2d5b27ecf659d61d9a4724c Mon Sep 17 00:00:00 2001
From: foolishhart 62256078+foolishhart@users.noreply.github.com Date: Mon, 27 Nov 2023 11:51:04 +0000 Subject: [PATCH] Update acp6x-mach.c
Added ASUSTeK COMPUTER INC "E1504FA" to quirks file to enable microphone array on ASUS Vivobook GO 15.
sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+)
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.
</formletter>
On Mon, Nov 27, 2023 at 03:44:37PM +0000, Malcolm Hart wrote:
From da1e023a39987c1bc2d5b27ecf659d61d9a4724c Mon Sep 17 00:00:00 2001
From: foolishhart 62256078+foolishhart@users.noreply.github.com Date: Mon, 27 Nov 2023 11:51:04 +0000 Subject: [PATCH] Update acp6x-mach.c
Added ASUSTeK COMPUTER INC "E1504FA" to quirks file to enable microphone array on ASUS Vivobook GO 15.
sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- Your patch was attached, please place it inline so that it can be applied directly from the email message itself.
- Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/process/submitting-patches.rst and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature.
- You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what is needed in order to properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what a proper Subject: line should look like.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot
On Mon, Nov 27, 2023 at 03:44:37PM +0000, Malcolm Hart wrote:
From da1e023a39987c1bc2d5b27ecf659d61d9a4724c Mon Sep 17 00:00:00 2001 From: foolishhart 62256078+foolishhart@users.noreply.github.com Date: Mon, 27 Nov 2023 11:51:04 +0000 Subject: [PATCH] Update acp6x-mach.c
Added ASUSTeK COMPUTER INC "E1504FA" to quirks file to enable microphone array on ASUS Vivobook GO 15.
sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+)
You've not provided a Signed-off-by for this so I can't do anything with it, please see Documentation/process/submitting-patches.rst for details on what this is and why it's important.
Please don't send new patches in reply to old patches or serieses, this makes it harder for both people and tools to understand what is going on - it can bury things in mailboxes and make it difficult to keep track of what current patches are, both for the new patches and the old ones.
On Mon, Nov 27, 2023 at 03:23:08PM +0000, Malcolm Hart wrote:
From da1e023a39987c1bc2d5b27ecf659d61d9a4724c Mon Sep 17 00:00:00 2001 From: foolishhart 62256078+foolishhart@users.noreply.github.com Date: Mon, 27 Nov 2023 11:51:04 +0000 Subject: [PATCH] Update acp6x-mach.c
Added ASUSTeK COMPUTER INC "E1504FA" to quirks file to enable microphone array on ASUS Vivobook GO 15.
sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+)
You've not provided a Signed-off-by for this so I can't do anything with it, please see Documentation/process/submitting-patches.rst for details on what this is and why it's important.
participants (2)
-
Greg KH -
Greg KH -
Malcolm Hart -
Mario Limonciello -
Mark Brown