[PATCH 0/7] dt-bindings: restrict node name suffixes
Hi,
Tree-wide cleanup of DTS node name suffixes "-N", e.g. "pwm-5", so we allow only decimal numbers. In few cases narrow the pattern to also disallow multiple suffixes, e.g. "pwm-5-5".
No dependencies, can be applied by individual subsystems.
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de
Link: https://lore.kernel.org/all/20221127182232.GA128974-robh@kernel.org/
Best regards, Krzysztof
Krzysztof Kozlowski (7): dt-bindings: phy: intel,combo-phy: restrict node name suffixes dt-bindings: pwm: restrict node name suffixes dt-bindings: rtc: restrict node name suffixes dt-bindings: slimbus: restrict node name suffixes spi: dt-bindings: restrict node name suffixes dt-bindings: timestamp: restrict node name suffixes dt-bindings: watchdog: restrict node name suffixes
Documentation/devicetree/bindings/phy/intel,combo-phy.yaml | 2 +- Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +- Documentation/devicetree/bindings/rtc/rtc.yaml | 2 +- Documentation/devicetree/bindings/slimbus/slimbus.yaml | 2 +- Documentation/devicetree/bindings/spi/spi-controller.yaml | 2 +- .../bindings/timestamp/hardware-timestamps-common.yaml | 2 +- Documentation/devicetree/bindings/watchdog/watchdog.yaml | 4 ++-- 7 files changed, 8 insertions(+), 8 deletions(-)
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to: 1. Only one unit address or one -N suffix, 2. -N suffixes to decimal numbers.
Suggested-by: Rob Herring robh@kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
---
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de --- Documentation/devicetree/bindings/phy/intel,combo-phy.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/phy/intel,combo-phy.yaml b/Documentation/devicetree/bindings/phy/intel,combo-phy.yaml index 5d54b0a0e873..7dd6a4d94b48 100644 --- a/Documentation/devicetree/bindings/phy/intel,combo-phy.yaml +++ b/Documentation/devicetree/bindings/phy/intel,combo-phy.yaml @@ -15,7 +15,7 @@ description: |
properties: $nodename: - pattern: "combophy(@.*|-[0-9a-f])*$" + pattern: "combophy(@.*|-([0-9]|[1-9][0-9]+))?$"
compatible: items:
* Krzysztof Kozlowski krzysztof.kozlowski@linaro.org [230530 14:49]:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to:
- Only one unit address or one -N suffix,
- -N suffixes to decimal numbers.
Reviewed-by: Tony Lindgren tony@atomide.com
On Tue, 30 May 2023 16:48:45 +0200, Krzysztof Kozlowski wrote:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to:
- Only one unit address or one -N suffix,
- -N suffixes to decimal numbers.
Suggested-by: Rob Herring robh@kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de
Documentation/devicetree/bindings/phy/intel,combo-phy.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Rob Herring robh@kernel.org
On 30-05-23, 16:48, Krzysztof Kozlowski wrote:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to:
- Only one unit address or one -N suffix,
- -N suffixes to decimal numbers.
Applied, thanks
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to: 1. Only one unit address or one -N suffix, 2. -N suffixes to decimal numbers.
Suggested-by: Rob Herring robh@kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
---
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de --- Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml index 3c01f85029e5..abd9fa873354 100644 --- a/Documentation/devicetree/bindings/pwm/pwm.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml @@ -13,7 +13,7 @@ select: false
properties: $nodename: - pattern: "^pwm(@.*|-[0-9a-f])*$" + pattern: "^pwm(@.*|-([0-9]|[1-9][0-9]+))?$"
"#pwm-cells": description:
* Krzysztof Kozlowski krzysztof.kozlowski@linaro.org [230530 14:49]:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to:
- Only one unit address or one -N suffix,
- -N suffixes to decimal numbers.
Suggested-by: Rob Herring robh@kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Reviewed-by: Tony Lindgren tony@atomide.com
On Tue, May 30, 2023 at 04:48:46PM +0200, Krzysztof Kozlowski wrote:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to:
- Only one unit address or one -N suffix,
- -N suffixes to decimal numbers.
Suggested-by: Rob Herring robh@kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de
Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml index 3c01f85029e5..abd9fa873354 100644 --- a/Documentation/devicetree/bindings/pwm/pwm.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml @@ -13,7 +13,7 @@ select: false
properties: $nodename:
- pattern: "^pwm(@.*|-[0-9a-f])*$"
- pattern: "^pwm(@.*|-([0-9]|[1-9][0-9]+))?$"
With this patch we forbid now the following patterns:
pwm-[0-9a-f][@-].* pwm-0[0-9a-f]+ pwm-[a-f]([@-].*)?
Checking for such names:
$ git grep -oP '\bpwm-([0-9a-f][@-].*|0[0-9a-f]+|[0-9]*[a-f][0-9a-f]*)(*pla:\s*{)' arch/*/boot/dts arch/arm/boot/dts/meson8.dtsi:pwm-f-ao arch/arm/boot/dts/meson8.dtsi:pwm-e arch/arm/boot/dts/meson8b.dtsi:pwm-d arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-a arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-b-x7 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-b-x19 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-c-c arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-c-x5 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-c-x8 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-d-x3 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-d-x6 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-e arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-f-z arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-f-a arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-f-x arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-f-h arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-a-e
These are all pinmux-settings and no pwm nodes, so the change is fine. (But arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi isn't properly sorted alphabetically.)
Reviewed-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de
Best regards and Thanks Uwe
On 07/06/2023 09:36, Uwe Kleine-König wrote:
On Tue, May 30, 2023 at 04:48:46PM +0200, Krzysztof Kozlowski wrote:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to:
- Only one unit address or one -N suffix,
- -N suffixes to decimal numbers.
Suggested-by: Rob Herring robh@kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de
Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml index 3c01f85029e5..abd9fa873354 100644 --- a/Documentation/devicetree/bindings/pwm/pwm.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml @@ -13,7 +13,7 @@ select: false
properties: $nodename:
- pattern: "^pwm(@.*|-[0-9a-f])*$"
- pattern: "^pwm(@.*|-([0-9]|[1-9][0-9]+))?$"
With this patch we forbid now the following patterns:
pwm-[0-9a-f][@-].* pwm-0[0-9a-f]+ pwm-[a-f]([@-].*)?
Yes, this was discussed last time: https://lore.kernel.org/all/20221127182232.GA128974-robh@kernel.org/
Checking for such names:
$ git grep -oP '\bpwm-([0-9a-f][@-].*|0[0-9a-f]+|[0-9]*[a-f][0-9a-f]*)(*pla:\s*{)' arch/*/boot/dts arch/arm/boot/dts/meson8.dtsi:pwm-f-ao arch/arm/boot/dts/meson8.dtsi:pwm-e arch/arm/boot/dts/meson8b.dtsi:pwm-d arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-a arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-b-x7 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-b-x19 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-c-c arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-c-x5 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-c-x8 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-d-x3 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-d-x6 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-e arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-f-z arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-f-a arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-f-x arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-f-h arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-a-e
Are you sure these are pwms, not pins?
These are all pinmux-settings and no pwm nodes, so the change is fine. (But arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi isn't properly sorted alphabetically.)
Exactly...
Reviewed-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de
Best regards, Krzysztof
On Tue, 30 May 2023 16:48:46 +0200, Krzysztof Kozlowski wrote:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to:
- Only one unit address or one -N suffix,
- -N suffixes to decimal numbers.
Suggested-by: Rob Herring robh@kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de
Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Rob Herring robh@kernel.org
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to: 1. Only one unit address or one -N suffix, 2. -N suffixes to decimal numbers.
Suggested-by: Rob Herring robh@kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
---
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de --- Documentation/devicetree/bindings/rtc/rtc.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/rtc/rtc.yaml b/Documentation/devicetree/bindings/rtc/rtc.yaml index c6fff5486fe6..efb66df82782 100644 --- a/Documentation/devicetree/bindings/rtc/rtc.yaml +++ b/Documentation/devicetree/bindings/rtc/rtc.yaml @@ -15,7 +15,7 @@ description: |
properties: $nodename: - pattern: "^rtc(@.*|-[0-9a-f])*$" + pattern: "^rtc(@.*|-([0-9]|[1-9][0-9]+))?$"
aux-voltage-chargeable: $ref: /schemas/types.yaml#/definitions/uint32
* Krzysztof Kozlowski krzysztof.kozlowski@linaro.org [230530 14:49]:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to:
- Only one unit address or one -N suffix,
- -N suffixes to decimal numbers.
Reviewed-by: Tony Lindgren tony@atomide.com
On Tue, 30 May 2023 16:48:47 +0200, Krzysztof Kozlowski wrote:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to:
- Only one unit address or one -N suffix,
- -N suffixes to decimal numbers.
Applied, thanks!
[3/7] dt-bindings: rtc: restrict node name suffixes commit: 93eff1e0e67a0b54fc16f07f0ca88f8b5afd9f89
Best regards,
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to: 1. Only one unit address or one -N suffix, 2. -N suffixes to decimal numbers.
Suggested-by: Rob Herring robh@kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
---
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de --- Documentation/devicetree/bindings/slimbus/slimbus.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/slimbus/slimbus.yaml b/Documentation/devicetree/bindings/slimbus/slimbus.yaml index 22513fb7c59a..3b8cae9d1016 100644 --- a/Documentation/devicetree/bindings/slimbus/slimbus.yaml +++ b/Documentation/devicetree/bindings/slimbus/slimbus.yaml @@ -15,7 +15,7 @@ description:
properties: $nodename: - pattern: "^slim(@.*|-[0-9a-f])*$" + pattern: "^slim(@.*|-([0-9]|[1-9][0-9]+))?$"
"#address-cells": const: 2
* Krzysztof Kozlowski krzysztof.kozlowski@linaro.org [230530 14:49]:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to:
- Only one unit address or one -N suffix,
- -N suffixes to decimal numbers.
Reviewed-by: Tony Lindgren tony@atomide.com
On Tue, 30 May 2023 16:48:48 +0200, Krzysztof Kozlowski wrote:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to:
- Only one unit address or one -N suffix,
- -N suffixes to decimal numbers.
Suggested-by: Rob Herring robh@kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de
Documentation/devicetree/bindings/slimbus/slimbus.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Rob Herring robh@kernel.org
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to: 1. Only one unit address or one -N suffix, 2. -N suffixes to decimal numbers.
Suggested-by: Rob Herring robh@kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
---
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de --- Documentation/devicetree/bindings/spi/spi-controller.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/spi/spi-controller.yaml b/Documentation/devicetree/bindings/spi/spi-controller.yaml index 90945f59b7e8..524f6fe8c27b 100644 --- a/Documentation/devicetree/bindings/spi/spi-controller.yaml +++ b/Documentation/devicetree/bindings/spi/spi-controller.yaml @@ -17,7 +17,7 @@ description: |
properties: $nodename: - pattern: "^spi(@.*|-[0-9a-f])*$" + pattern: "^spi(@.*|-([0-9]|[1-9][0-9]+))?$"
"#address-cells": enum: [0, 1]
* Krzysztof Kozlowski krzysztof.kozlowski@linaro.org [230530 14:49]:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to:
- Only one unit address or one -N suffix,
- -N suffixes to decimal numbers.
Reviewed-by: Tony Lindgren tony@atomide.com
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to -N suffixes to decimal numbers.
Suggested-by: Rob Herring robh@kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
---
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de --- .../bindings/timestamp/hardware-timestamps-common.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml b/Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml index fd6a7b51f571..95f42acd0c54 100644 --- a/Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml +++ b/Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml @@ -17,7 +17,7 @@ description:
properties: $nodename: - pattern: "^timestamp(@.*|-[0-9a-f])?$" + pattern: "^timestamp(@.*|-([0-9]|[1-9][0-9]+))?$"
"#timestamp-cells": description:
* Krzysztof Kozlowski krzysztof.kozlowski@linaro.org [230530 14:49]:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to -N suffixes to decimal numbers.
Reviewed-by: Tony Lindgren tony@atomide.com
On Tue, 30 May 2023 16:48:50 +0200, Krzysztof Kozlowski wrote:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to -N suffixes to decimal numbers.
Suggested-by: Rob Herring robh@kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de
.../bindings/timestamp/hardware-timestamps-common.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Rob Herring robh@kernel.org
On Tue, 30 May 2023 16:48:50 +0200, Krzysztof Kozlowski wrote:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to -N suffixes to decimal numbers.
Suggested-by: Rob Herring robh@kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de
.../bindings/timestamp/hardware-timestamps-common.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to -N suffixes to decimal numbers.
Suggested-by: Rob Herring robh@kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
---
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de --- Documentation/devicetree/bindings/watchdog/watchdog.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/watchdog/watchdog.yaml b/Documentation/devicetree/bindings/watchdog/watchdog.yaml index 519b48889eb1..f0a584af1223 100644 --- a/Documentation/devicetree/bindings/watchdog/watchdog.yaml +++ b/Documentation/devicetree/bindings/watchdog/watchdog.yaml @@ -17,11 +17,11 @@ description: | select: properties: $nodename: - pattern: "^watchdog(@.*|-[0-9a-f])?$" + pattern: "^watchdog(@.*|-([0-9]|[1-9][0-9]+))?$"
properties: $nodename: - pattern: "^(timer|watchdog)(@.*|-[0-9a-f])?$" + pattern: "^(timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$"
timeout-sec: description:
On Tue, May 30, 2023 at 04:48:51PM +0200, Krzysztof Kozlowski wrote:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to -N suffixes to decimal numbers.
Suggested-by: Rob Herring robh@kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Reviewed-by: Guenter Roeck linux@roeck-us.net
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de
Documentation/devicetree/bindings/watchdog/watchdog.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/watchdog/watchdog.yaml b/Documentation/devicetree/bindings/watchdog/watchdog.yaml index 519b48889eb1..f0a584af1223 100644 --- a/Documentation/devicetree/bindings/watchdog/watchdog.yaml +++ b/Documentation/devicetree/bindings/watchdog/watchdog.yaml @@ -17,11 +17,11 @@ description: | select: properties: $nodename:
pattern: "^watchdog(@.*|-[0-9a-f])?$"
pattern: "^watchdog(@.*|-([0-9]|[1-9][0-9]+))?$"properties: $nodename:
- pattern: "^(timer|watchdog)(@.*|-[0-9a-f])?$"
pattern: "^(timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$"
timeout-sec: description:
-- 2.34.1
* Krzysztof Kozlowski krzysztof.kozlowski@linaro.org [230530 14:49]:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to -N suffixes to decimal numbers.
Reviewed-by: Tony Lindgren tony@atomide.com
On Tue, 30 May 2023 16:48:51 +0200, Krzysztof Kozlowski wrote:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to -N suffixes to decimal numbers.
Suggested-by: Rob Herring robh@kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de
Documentation/devicetree/bindings/watchdog/watchdog.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Rob Herring robh@kernel.org
On Tue, 30 May 2023 16:48:51 +0200, Krzysztof Kozlowski wrote:
Make the pattern matching node names a bit stricter to improve DTS consistency. The pattern is restricted to -N suffixes to decimal numbers.
Suggested-by: Rob Herring robh@kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de
Documentation/devicetree/bindings/watchdog/watchdog.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Seems watchdog patches aren't getting applied... Applied, thanks!
Hello,
On Tue, May 30, 2023 at 04:48:44PM +0200, Krzysztof Kozlowski wrote:
Hi,
Tree-wide cleanup of DTS node name suffixes "-N", e.g. "pwm-5", so we allow only decimal numbers. In few cases narrow the pattern to also disallow multiple suffixes, e.g. "pwm-5-5".
No dependencies, can be applied by individual subsystems.
Acked-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de
Thanks Uwe
On Tue, May 30, 2023 at 04:48:44PM +0200, Krzysztof Kozlowski wrote:
Hi,
Tree-wide cleanup of DTS node name suffixes "-N", e.g. "pwm-5", so we allow only decimal numbers. In few cases narrow the pattern to also disallow multiple suffixes, e.g. "pwm-5-5".
I figure there'll be quite a bit of stuff to fix up afterwards? Reviewed-by: Conor Dooley conor.dooley@microchip.com
Thanks, Conor.
No dependencies, can be applied by individual subsystems.
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de
Link: https://lore.kernel.org/all/20221127182232.GA128974-robh@kernel.org/
Best regards, Krzysztof
Krzysztof Kozlowski (7): dt-bindings: phy: intel,combo-phy: restrict node name suffixes dt-bindings: pwm: restrict node name suffixes dt-bindings: rtc: restrict node name suffixes dt-bindings: slimbus: restrict node name suffixes spi: dt-bindings: restrict node name suffixes dt-bindings: timestamp: restrict node name suffixes dt-bindings: watchdog: restrict node name suffixes
Documentation/devicetree/bindings/phy/intel,combo-phy.yaml | 2 +- Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +- Documentation/devicetree/bindings/rtc/rtc.yaml | 2 +- Documentation/devicetree/bindings/slimbus/slimbus.yaml | 2 +- Documentation/devicetree/bindings/spi/spi-controller.yaml | 2 +- .../bindings/timestamp/hardware-timestamps-common.yaml | 2 +- Documentation/devicetree/bindings/watchdog/watchdog.yaml | 4 ++-- 7 files changed, 8 insertions(+), 8 deletions(-)
-- 2.34.1
On 30/05/2023 19:11, Conor Dooley wrote:
On Tue, May 30, 2023 at 04:48:44PM +0200, Krzysztof Kozlowski wrote:
Hi,
Tree-wide cleanup of DTS node name suffixes "-N", e.g. "pwm-5", so we allow only decimal numbers. In few cases narrow the pattern to also disallow multiple suffixes, e.g. "pwm-5-5".
I figure there'll be quite a bit of stuff to fix up afterwards? Reviewed-by: Conor Dooley conor.dooley@microchip.com
Quick grep shown zero fixes needed.
Best regards, Krzysztof
On Tue, 30 May 2023 16:48:44 +0200, Krzysztof Kozlowski wrote:
Tree-wide cleanup of DTS node name suffixes "-N", e.g. "pwm-5", so we allow only decimal numbers. In few cases narrow the pattern to also disallow multiple suffixes, e.g. "pwm-5-5".
No dependencies, can be applied by individual subsystems.
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[5/7] spi: dt-bindings: restrict node name suffixes commit: c4fb6880edc15866a530c7b8f2698ae65f80cfab
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
On Tue, 30 May 2023 16:48:44 +0200, Krzysztof Kozlowski wrote:
Tree-wide cleanup of DTS node name suffixes "-N", e.g. "pwm-5", so we allow only decimal numbers. In few cases narrow the pattern to also disallow multiple suffixes, e.g. "pwm-5-5".
No dependencies, can be applied by individual subsystems.
Cc: Tony Lindgren tony@atomide.com Cc: Oleksij Rempel o.rempel@pengutronix.de
[...]
Applied, thanks!
[2/7] dt-bindings: pwm: restrict node name suffixes commit: 05b743db9d8cc4e51b3eb77889d24ab9aa2bf169
Best regards,
participants (10)
-
Alexandre Belloni -
Conor Dooley -
Guenter Roeck -
Krzysztof Kozlowski -
Mark Brown -
Rob Herring -
Thierry Reding -
Tony Lindgren -
Uwe Kleine-König -
Vinod Koul