[alsa-devel] [RESEND PATCH] ASoC: OMAP: HDMI: Initialize IEC-60958 channel status word
As the IEC-60958 channel status word is set by ANDing and ORing with the appropriate definitions, the word bytes need to be initialized to zero to avoid misconfiguration due to previous hw_params calls.
Signed-off-by: Ricardo Neri rneri@dextratech.com --- sound/soc/omap/omap-hdmi.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/omap/omap-hdmi.c b/sound/soc/omap/omap-hdmi.c index f59c69f..75ad378 100644 --- a/sound/soc/omap/omap-hdmi.c +++ b/sound/soc/omap/omap-hdmi.c @@ -110,6 +110,8 @@ static int omap_hdmi_dai_hw_params(struct snd_pcm_substream *substream, /* * fill the IEC-60958 channel status word */ + /* initialize the word bytes */ + memset(iec->status, 0, sizeof(iec->status));
/* specify IEC-60958-3 (commercial use) */ iec->status[0] &= ~IEC958_AES0_PROFESSIONAL; -- 1.7.10.4
On Thu, Jan 10, 2013 at 06:32:13PM -0600, Ricardo Neri wrote:
As the IEC-60958 channel status word is set by ANDing and ORing with the appropriate definitions, the word bytes need to be initialized to zero to avoid misconfiguration due to previous hw_params calls.
Signed-off-by: Ricardo Neri rneri@dextratech.com
You've dropped my ack from this, you should keep acks on patches you resubmit to save people time on review.
Anyway, I guess there's no need to merge via the video tree now so applied.
Hi Mark,
On 01/11/2013 05:59 PM, Mark Brown wrote:
On Thu, Jan 10, 2013 at 06:32:13PM -0600, Ricardo Neri wrote:
As the IEC-60958 channel status word is set by ANDing and ORing with the appropriate definitions, the word bytes need to be initialized to zero to avoid misconfiguration due to previous hw_params calls.
Signed-off-by: Ricardo Neri rneri@dextratech.com
You've dropped my ack from this, you should keep acks on patches you resubmit to save people time on review.
Sorry, I missed that. I just basically went ahead and resubmitted because you ack'ed it but the patch was not applied. I guess I should have clarified that this change was independent of the video tree.
Anyway, I guess there's no need to merge via the video tree now so applied.
Thanks!
Ricardo
participants (2)
-
Mark Brown
-
Ricardo Neri