[alsa-devel] [PATCH] ASoC: Intel: Don't issue ipc when processing response
From: Paweł Piskorski pawel.piskorski@intel.com
Make sure we dont issue IPC when we are processing a response.
Signed-off-by: Paweł Piskorski pawel.piskorski@intel.com Signed-off-by: Liam Girdwood liam.r.girdwood@linux.intel.com Signed-off-by: Jie Yang yang.jie@intel.com --- sound/soc/intel/sst-haswell-ipc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/soc/intel/sst-haswell-ipc.c b/sound/soc/intel/sst-haswell-ipc.c index 5a607ab..0fec686 100644 --- a/sound/soc/intel/sst-haswell-ipc.c +++ b/sound/soc/intel/sst-haswell-ipc.c @@ -457,9 +457,10 @@ static void ipc_tx_msgs(struct kthread_work *work) return; }
- /* if the DSP is busy we will TX messages after IRQ */ + /* if the DSP is busy, we will TX messages after IRQ. + * also postpone if we are in the middle of procesing completion irq*/ ipcx = sst_dsp_shim_read_unlocked(hsw->dsp, SST_IPCX); - if (ipcx & SST_IPCX_BUSY) { + if (ipcx & (SST_IPCX_BUSY | SST_IPCX_DONE)) { spin_unlock_irqrestore(&hsw->dsp->spinlock, flags); return; }
On Fri, Aug 01, 2014 at 11:09:44PM +0800, Jie Yang wrote:
From: Paweł Piskorski pawel.piskorski@intel.com
Make sure we dont issue IPC when we are processing a response.
Applied, thanks.
participants (2)
-
Jie Yang
-
Mark Brown