[alsa-devel] [PATCH 0/2] ASoC: codec tlv320aic32x4 fixes
Hi,
Here are two fixes for the tlv320aic32x4 codec. The first patch fixes a regmap bug introduced in 3.13. The second is not as important, it adds the codec to the compatible list in the binding documentation.
Regards,
Markus
Markus Pargmann (2): ASoC: codec: tlv320aic32x4: Fix regmap range config ASoC: codec doc, tlv320aic3x: Add tlv320aic32x4 as compatible
Documentation/devicetree/bindings/sound/tlv320aic3x.txt | 1 + sound/soc/codecs/tlv320aic32x4.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)
This codec driver fails to probe because it has a higher regmap range_max value than max_register. This patch sets the range_max to the max_register value as described in the for struct regmap_range_cfg: "@range_max: Address of the highest register in virtual range."
Signed-off-by: Markus Pargmann mpa@pengutronix.de --- sound/soc/codecs/tlv320aic32x4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tlv320aic32x4.c b/sound/soc/codecs/tlv320aic32x4.c index 18cdcca..6941fa9 100644 --- a/sound/soc/codecs/tlv320aic32x4.c +++ b/sound/soc/codecs/tlv320aic32x4.c @@ -268,7 +268,7 @@ static const struct regmap_range_cfg aic32x4_regmap_pages[] = { .window_start = 0, .window_len = 128, .range_min = AIC32X4_PAGE1, - .range_max = AIC32X4_PAGE1 + 127, + .range_max = AIC32X4_RMICPGAVOL, }, };
On Sat, Jan 11, 2014 at 02:48:30PM +0100, Markus Pargmann wrote:
This codec driver fails to probe because it has a higher regmap range_max value than max_register. This patch sets the range_max to the max_register value as described in the for struct regmap_range_cfg: "@range_max: Address of the highest register in virtual range."
Applied, thanks.
Add tlv320aic32x4 to the compatible list in the binding documentation.
Signed-off-by: Markus Pargmann mpa@pengutronix.de --- Documentation/devicetree/bindings/sound/tlv320aic3x.txt | 1 + 1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/sound/tlv320aic3x.txt b/Documentation/devicetree/bindings/sound/tlv320aic3x.txt index 5e6040c..9d8ea14 100644 --- a/Documentation/devicetree/bindings/sound/tlv320aic3x.txt +++ b/Documentation/devicetree/bindings/sound/tlv320aic3x.txt @@ -6,6 +6,7 @@ Required properties:
- compatible - "string" - One of: "ti,tlv320aic3x" - Generic TLV320AIC3x device + "ti,tlv320aic32x4" - TLV320AIC32x4 "ti,tlv320aic33" - TLV320AIC33 "ti,tlv320aic3007" - TLV320AIC3007 "ti,tlv320aic3106" - TLV320AIC3106
On Sat, Jan 11, 2014 at 02:48:31PM +0100, Markus Pargmann wrote:
Add tlv320aic32x4 to the compatible list in the binding documentation.
Signed-off-by: Markus Pargmann mpa@pengutronix.de
Documentation/devicetree/bindings/sound/tlv320aic3x.txt | 1 + 1 file changed, 1 insertion(+)
Applied, thanks but you should really also add this compatible string to the driver.
Hi,
On Mon, Jan 13, 2014 at 12:37:21PM +0000, Mark Brown wrote:
On Sat, Jan 11, 2014 at 02:48:31PM +0100, Markus Pargmann wrote:
Add tlv320aic32x4 to the compatible list in the binding documentation.
Signed-off-by: Markus Pargmann mpa@pengutronix.de
Documentation/devicetree/bindings/sound/tlv320aic3x.txt | 1 + 1 file changed, 1 insertion(+)
Applied, thanks but you should really also add this compatible string to the driver.
Oh, I didn't notice that the 320aic3x driver actually has of_device_ids. I was using the 320aic3x4 driver which only defines i2c_device_id but it still matches with the compatible fields from my devicetree.
So perhaps it is better to drop this patch as it is no explicit compatible in the driver?
Thanks,
Markus
On Mon, Jan 13, 2014 at 02:18:28PM +0100, Markus Pargmann wrote:
On Mon, Jan 13, 2014 at 12:37:21PM +0000, Mark Brown wrote:
Applied, thanks but you should really also add this compatible string to the driver.
Oh, I didn't notice that the 320aic3x driver actually has of_device_ids. I was using the 320aic3x4 driver which only defines i2c_device_id but it still matches with the compatible fields from my devicetree.
So perhaps it is better to drop this patch as it is no explicit compatible in the driver?
Or you could add the compatible string to the driver as I suggested... I don't see any reason for the device not to have a compatible string?
Hi,
On Mon, Jan 13, 2014 at 03:44:57PM +0000, Mark Brown wrote:
On Mon, Jan 13, 2014 at 02:18:28PM +0100, Markus Pargmann wrote:
On Mon, Jan 13, 2014 at 12:37:21PM +0000, Mark Brown wrote:
Applied, thanks but you should really also add this compatible string to the driver.
Oh, I didn't notice that the 320aic3x driver actually has of_device_ids. I was using the 320aic3x4 driver which only defines i2c_device_id but it still matches with the compatible fields from my devicetree.
So perhaps it is better to drop this patch as it is no explicit compatible in the driver?
Or you could add the compatible string to the driver as I suggested... I don't see any reason for the device not to have a compatible string?
The codec is not working here at the moment, so I can't test if the aic3204 codec is really working with the aic3x driver.
Regards,
Markus
On Tue, Jan 14, 2014 at 09:50:19AM +0100, Markus Pargmann wrote:
On Mon, Jan 13, 2014 at 03:44:57PM +0000, Mark Brown wrote:
Or you could add the compatible string to the driver as I suggested... I don't see any reason for the device not to have a compatible string?
The codec is not working here at the moment, so I can't test if the aic3204 codec is really working with the aic3x driver.
Why would you add the compatible string to the aic3x driver, there is a separate driver for this chip?
On Tue, Jan 14, 2014 at 12:14:26PM +0000, Mark Brown wrote:
On Tue, Jan 14, 2014 at 09:50:19AM +0100, Markus Pargmann wrote:
On Mon, Jan 13, 2014 at 03:44:57PM +0000, Mark Brown wrote:
Or you could add the compatible string to the driver as I suggested... I don't see any reason for the device not to have a compatible string?
The codec is not working here at the moment, so I can't test if the aic3204 codec is really working with the aic3x driver.
Why would you add the compatible string to the aic3x driver, there is a separate driver for this chip?
Right, was confused a little. I will add proper bindings for aic32x4 as soon as I have everything up and running.
Thanks,
Markus
participants (2)
-
Mark Brown -
Markus Pargmann