On Tue, May 12, 2015 at 05:26:35PM +0800, Xing Zheng wrote:

sound/soc/rockchip/Kconfig | 10 ++ sound/soc/rockchip/Makefile | 2 + sound/soc/rockchip/rockchip_machine_driver.c | 6 + sound/soc/rockchip/rockchip_machine_driver.h | 6 + sound/soc/rockchip/rockchip_max98090.c | 185 ++++++++++++++++++++++++++

This looks more like a normal and reasonable machine driver but then why have you created the generic rockchip machine driver? It seems like this should just be a regular machine driver like other platforms have, were it not for that this would be mostly fine apart from a couple of nitpicks below.

+config SND_SOC_ROCKCHIP_MAX98090

• tristate "ASoC support for Rockchip boards using a MAX98090 codec"
• depends on SND_SOC_ROCKCHIP && I2C && GPIOLIB
• select SND_SOC_ROCKCHIP_I2S
• select SND_SOC_MAX98090
• select SND_SOC_TS3A227E

This looks like it's a driver specific to Chromebooks (possibly even specific Chromeooks) and so should be named as such.

• card->dapm.idle_bias_off = true;

Just set this when declaring the card, don't do it at runtime.

• snd_soc_dapm_enable_pin(dapm, "Headset Mic");
• snd_soc_dapm_enable_pin(dapm, "Headphone");
• snd_soc_dapm_enable_pin(dapm, "Speaker");
• snd_soc_dapm_enable_pin(dapm, "Int Mic");

No need to do this, all pins are enabled by default.

• snd_soc_dapm_sync(dapm);

This has no effect during initialization.