Re: [alsa-devel] [PATCH Resend 7/8] ASoC: add snd_soc_of_parse_audio_simple_widgets for DeviceTree
On Fri, Jan 24, 2014 at 02:46:33AM +0000, Li.Xiubo@freescale.com wrote:
+static struct snd_soc_dapm_widget simple_widgets[] = {
- SND_SOC_DAPM_MIC("Mic", NULL),
- SND_SOC_DAPM_LINE("Line", NULL),
- SND_SOC_DAPM_HP("Hp", NULL),
- SND_SOC_DAPM_SPK("Spk", NULL),
+};
This is the templates for "Microphone XXX", "Line XXX", "Headphone XXX" and "Spk XXX" .
Does this mean we're restricted to a particular set of names? That seems sad and won't work if there's a desire for more than one of a given widget - the main use case I can see is multiple microphones with separate microphone biases. How about having some templates that we copy and then replace the name with the one the user supplied?
This code has already supplied this I think.
OK, that's fine - this is one of the things that the lack of binding documentation doesn't help with, it says what the code is supposed to do. When reviewing DT code without bindings I tend to just skim the code.
participants (1)
-
Mark Brown