On Mon, Oct 13, 2025 at 05:08:04PM +0800, Oder Chiou wrote:

This codec driver is for the ALC5575 that has a built-in audio DSP. The firmware can be loaded by the SPI from the SOC or the external flash.

• regmap_update_bits(rt5575->regmap, RT5575_SW_INT, 1, 1);

• ret = 1;
• for (i = 0; i < 100 && ret; i++) {

• regmap_read(rt5575->regmap, RT5575_SW_INT, &ret);
  

• msleep(100);
  

• }
• return 0;

Shouldn't there be an error reported if we get to the end of our 100 loops and ret is still set?

+static int rt5575_hw_params(struct snd_pcm_substream *substream,

• struct snd_pcm_hw_params *params, struct snd_soc_dai *dai)

+{

• return 0;

+}

Just delete this if it's empty.

+static int rt5575_set_bias_level(struct snd_soc_component *component,

• 	enum snd_soc_bias_level level)
  

+{

• switch (level) {

This also does nothing and could be removed.

+static irqreturn_t rt5575_irq(int irq, void *data) +{

• return IRQ_HANDLED;

+}

This seems strange? Why even register an interrupt handler if we're just going to ignore it?