[PATCH 0/3] Dead structs in sound/soc/codecs
From: "Dr. David Alan Gilbert" linux@treblig.org
Clean out a bunch of old structs in sound/soc/codecs. Build tested only.
Signed-off-by: Dr. David Alan Gilbert linux@treblig.org
Dr. David Alan Gilbert (3): ASoC: codecs: lpass-rx-macro: remove unused struct 'rx_macro_reg_mask_val' ASoC: codecs: wm0010: remove unused struct 'wm0010_spi_msg' ASoC: codecs: cx2072x: remove unused struct 'cx2072x_eq_ctrl'
sound/soc/codecs/cx2072x.c | 5 ----- sound/soc/codecs/lpass-rx-macro.c | 6 ------ sound/soc/codecs/wm0010.c | 8 -------- 3 files changed, 19 deletions(-)
From: "Dr. David Alan Gilbert" linux@treblig.org
'rx_macro_reg_mask_val' is unused since the original commit af3d54b99764 ("ASoC: codecs: lpass-rx-macro: add support for lpass rx macro").
Remove it.
Signed-off-by: Dr. David Alan Gilbert linux@treblig.org --- sound/soc/codecs/lpass-rx-macro.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/sound/soc/codecs/lpass-rx-macro.c b/sound/soc/codecs/lpass-rx-macro.c index f35187d69cac..dfb7e4c69683 100644 --- a/sound/soc/codecs/lpass-rx-macro.c +++ b/sound/soc/codecs/lpass-rx-macro.c @@ -463,12 +463,6 @@ static const struct comp_coeff_val comp_coeff_table[HPH_MODE_MAX][COMP_MAX_COEFF }, };
-struct rx_macro_reg_mask_val { - u16 reg; - u8 mask; - u8 val; -}; - enum { INTERP_HPHL, INTERP_HPHR,
On 01/06/2024 23:54, linux@treblig.org wrote:
From: "Dr. David Alan Gilbert" linux@treblig.org
'rx_macro_reg_mask_val' is unused since the original commit af3d54b99764 ("ASoC: codecs: lpass-rx-macro: add support for lpass rx macro").
Remove it.
Signed-off-by: Dr. David Alan Gilbert linux@treblig.org
thanks for the patch,
Reviewed-by: Srinivas Kandagatla srinivas.kandagatla@linaro.org
--srini
sound/soc/codecs/lpass-rx-macro.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/sound/soc/codecs/lpass-rx-macro.c b/sound/soc/codecs/lpass-rx-macro.c index f35187d69cac..dfb7e4c69683 100644 --- a/sound/soc/codecs/lpass-rx-macro.c +++ b/sound/soc/codecs/lpass-rx-macro.c @@ -463,12 +463,6 @@ static const struct comp_coeff_val comp_coeff_table[HPH_MODE_MAX][COMP_MAX_COEFF }, };
-struct rx_macro_reg_mask_val {
- u16 reg;
- u8 mask;
- u8 val;
-};
- enum { INTERP_HPHL, INTERP_HPHR,
From: "Dr. David Alan Gilbert" linux@treblig.org
'wm0010_spi_msg' has been unused since the original commit e3523e01869d ("ASoC: wm0010: Add initial wm0010 DSP driver").
Remove it.
Signed-off-by: Dr. David Alan Gilbert linux@treblig.org --- sound/soc/codecs/wm0010.c | 8 -------- 1 file changed, 8 deletions(-)
diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c index 8f862729a2ca..edd2cb185c42 100644 --- a/sound/soc/codecs/wm0010.c +++ b/sound/soc/codecs/wm0010.c @@ -115,14 +115,6 @@ struct wm0010_priv { struct completion boot_completion; };
-struct wm0010_spi_msg { - struct spi_message m; - struct spi_transfer t; - u8 *tx_buf; - u8 *rx_buf; - size_t len; -}; - static const struct snd_soc_dapm_widget wm0010_dapm_widgets[] = { SND_SOC_DAPM_SUPPLY("CLKIN", SND_SOC_NOPM, 0, 0, NULL, 0), };
On Sat, Jun 01, 2024 at 11:54:45PM +0100, linux@treblig.org wrote:
From: "Dr. David Alan Gilbert" linux@treblig.org
'wm0010_spi_msg' has been unused since the original commit e3523e01869d ("ASoC: wm0010: Add initial wm0010 DSP driver").
Remove it.
Signed-off-by: Dr. David Alan Gilbert linux@treblig.org
Reviewed-by: Charles Keepax ckeepax@opensource.cirrus.com
Thanks, Charles
From: "Dr. David Alan Gilbert" linux@treblig.org
'cx2072x_eq_ctrl' has been unused since the original commit a497a4363706 ("ASoC: Add support for Conexant CX2072X CODEC").
Remove it.
Signed-off-by: Dr. David Alan Gilbert linux@treblig.org --- sound/soc/codecs/cx2072x.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/sound/soc/codecs/cx2072x.c b/sound/soc/codecs/cx2072x.c index e8e22b1a1963..8cfec8dcf839 100644 --- a/sound/soc/codecs/cx2072x.c +++ b/sound/soc/codecs/cx2072x.c @@ -63,11 +63,6 @@ static const DECLARE_TLV_DB_SCALE(adc_tlv, -7400, 100, 0); static const DECLARE_TLV_DB_SCALE(dac_tlv, -7400, 100, 0); static const DECLARE_TLV_DB_SCALE(boost_tlv, 0, 1200, 0);
-struct cx2072x_eq_ctrl { - u8 ch; - u8 band; -}; - static const DECLARE_TLV_DB_RANGE(hpf_tlv, 0, 0, TLV_DB_SCALE_ITEM(120, 0, 0), 1, 63, TLV_DB_SCALE_ITEM(30, 30, 0)
On Sat, 01 Jun 2024 23:54:43 +0100, linux@treblig.org wrote:
Clean out a bunch of old structs in sound/soc/codecs. Build tested only.
Signed-off-by: Dr. David Alan Gilbert linux@treblig.org
Dr. David Alan Gilbert (3): ASoC: codecs: lpass-rx-macro: remove unused struct 'rx_macro_reg_mask_val' ASoC: codecs: wm0010: remove unused struct 'wm0010_spi_msg' ASoC: codecs: cx2072x: remove unused struct 'cx2072x_eq_ctrl'
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/3] ASoC: codecs: lpass-rx-macro: remove unused struct 'rx_macro_reg_mask_val' commit: 44e55f9de9950dba091401898a931fc1a3a99146 [2/3] ASoC: codecs: wm0010: remove unused struct 'wm0010_spi_msg' commit: 62ccbe8cbe2a1b6911ec47bea8b1510dc1f82dd5 [3/3] ASoC: codecs: cx2072x: remove unused struct 'cx2072x_eq_ctrl' commit: 8080dde80a2d3657529c2172471c06cfcd9a228e
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (4)
-
Charles Keepax -
linux＠treblig.org -
Mark Brown -
Srinivas Kandagatla