[alsa-devel] dapm_widget_power_read_file() symmetry issue?
5 Jun
2012
5 Jun
'12
12:39 a.m.
In dapm_widget_power_read_file(), there is first:
list_for_each_entry(p, &w->sources, list_sink) { if (p->connected && !p->connected(w, p->sink)) continue;
then right after that:
list_for_each_entry(p, &w->sinks, list_source) { if (p->connected && !p->connected(w, p->sink)) continue;
Should that last call to p->connected() be p->connected(p->source, w), since the function's parameters are (source, sink)?
5 Jun
5 Jun
6:46 p.m.
On Mon, Jun 04, 2012 at 04:39:57PM -0600, Stephen Warren wrote:
list_for_each_entry(p, &w->sinks, list_source) { if (p->connected && !p->connected(w, p->sink)) continue;
Should that last call to p->connected() be p->connected(p->source, w), since the function's parameters are (source, sink)?
Probably, yes.
4583
Age (days ago)
4584
Last active (days ago)
1 comments
2 participants
participants (2)
-
Mark Brown
-
Stephen Warren