At Tue, 23 Jul 2013 11:15:06 +0200, Eldad Zack wrote:

Return SNDRV_PCM_POS_XRUN (snd_pcm_uframes_t) instead of SNDRV_PCM_STATE_XRUN (snd_pcm_state_t) from the pointer function of hiface, as expected by snd_pcm_update_hw_ptr0().

Caught by sparse.

Cc: Antonio Ospite ospite@studenti.unina.it Signed-off-by: Eldad Zack eldad@fogrefinery.com

Thanks, applied.

Takashi

---

• Corrected commit message

sound/usb/hiface/pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/usb/hiface/pcm.c b/sound/usb/hiface/pcm.c index 6430ed2..c21a3df 100644 --- a/sound/usb/hiface/pcm.c +++ b/sound/usb/hiface/pcm.c @@ -503,7 +503,7 @@ static snd_pcm_uframes_t hiface_pcm_pointer(struct snd_pcm_substream *alsa_sub) snd_pcm_uframes_t dma_offset;

if (rt->panic || !sub)

• return SNDRV_PCM_STATE_XRUN;
  

• return SNDRV_PCM_POS_XRUN;
  
  

  spin_lock_irqsave(&sub->lock, flags); dma_offset = sub->dma_off;

-- 1.8.1.5