[alsa-devel] sound/pci/hda/hda_generic.c:1529 indep_hp_put() warn: inconsistent returns mutex:&spec->pcm_mutex: locked (1526) unlocked (1517, 1529)
Hi Takashi,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-unstable.git master head: 02e5aa7b459f69538d4ec88658d064816a7692d6 commit: a5de6f4d021608c50ff5ff51d208b5030da92957 ALSA: hda - Implement independent HP control date: 33 hours ago
sound/pci/hda/hda_generic.c:1529 indep_hp_put() warn: inconsistent returns mutex:&spec->pcm_mutex: locked (1526) unlocked (1517,1529)
vim +1529 sound/pci/hda/hda_generic.c
a5de6f4d Takashi Iwai 2012-12-21 1511 struct hda_gen_spec *spec = codec->spec; a5de6f4d Takashi Iwai 2012-12-21 1512 unsigned int select = ucontrol->value.enumerated.item[0]; a5de6f4d Takashi Iwai 2012-12-21 1513 a5de6f4d Takashi Iwai 2012-12-21 1514 mutex_lock(&spec->pcm_mutex); a5de6f4d Takashi Iwai 2012-12-21 1515 if (spec->active_streams) { a5de6f4d Takashi Iwai 2012-12-21 1516 mutex_unlock(&spec->pcm_mutex); a5de6f4d Takashi Iwai 2012-12-21 @1517 return -EBUSY; a5de6f4d Takashi Iwai 2012-12-21 1518 } a5de6f4d Takashi Iwai 2012-12-21 1519 a5de6f4d Takashi Iwai 2012-12-21 1520 if (spec->indep_hp_enabled != select) { a5de6f4d Takashi Iwai 2012-12-21 1521 spec->indep_hp_enabled = select; a5de6f4d Takashi Iwai 2012-12-21 1522 if (spec->indep_hp_enabled) a5de6f4d Takashi Iwai 2012-12-21 1523 spec->multiout.hp_out_nid[0] = 0; a5de6f4d Takashi Iwai 2012-12-21 1524 else a5de6f4d Takashi Iwai 2012-12-21 1525 spec->multiout.hp_out_nid[0] = spec->alt_dac_nid; a5de6f4d Takashi Iwai 2012-12-21 @1526 return 1; a5de6f4d Takashi Iwai 2012-12-21 1527 } a5de6f4d Takashi Iwai 2012-12-21 1528 mutex_unlock(&spec->pcm_mutex); a5de6f4d Takashi Iwai 2012-12-21 @1529 return 0; a5de6f4d Takashi Iwai 2012-12-21 1530 } a5de6f4d Takashi Iwai 2012-12-21 1531 a5de6f4d Takashi Iwai 2012-12-21 1532 static const struct snd_kcontrol_new indep_hp_ctl = {
--- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu Intel Corporation
participants (1)
-
Fengguang Wu